Skip to content

Commit 3096fe5

Browse files
author
Ben Grynhaus
committed
Slight code simplification
1 parent 5089e77 commit 3096fe5

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

libs/fabric/src/components/contextual-menu/directives/contextual-menu-item.directive.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,14 @@ export class ContextualMenuItemDirective
6969
}
7070

7171
ngAfterContentInit() {
72-
// Currently @ContentChildren selects host component as well.
73-
// Relevant Github issue: https://github.com/angular/angular/issues/10098
72+
// @ContentChildren selects host component as well.
73+
// Relevant GitHub issue: https://github.com/angular/angular/issues/10098
7474
const nonSelfMenuItemsDirectives = this.menuItemsDirectives.filter(directive => directive !== this);
7575
if (nonSelfMenuItemsDirectives.length === 0) {
7676
return;
7777
}
7878

79-
const items = nonSelfMenuItemsDirectives.map<IContextualMenuItem>(
80-
ContextualMenuItemDirective.directiveToContextualMenuItem
81-
);
79+
const items = nonSelfMenuItemsDirectives.map(directive => this._directiveToContextualMenuItem(directive));
8280
if (!this.subMenuProps) {
8381
this.subMenuProps = { items: items };
8482
} else {
@@ -93,7 +91,7 @@ export class ContextualMenuItemDirective
9391
subMenuProps: {
9492
currentValue: {
9593
...this.subMenuProps,
96-
items: newValue.map(ContextualMenuItemDirective.directiveToContextualMenuItem),
94+
items: newValue.map(directive => this._directiveToContextualMenuItem(directive)),
9795
},
9896
},
9997
},
@@ -106,7 +104,7 @@ export class ContextualMenuItemDirective
106104
this._subscriptions.forEach(subscription => subscription.unsubscribe());
107105
}
108106

109-
static directiveToContextualMenuItem(directive: ContextualMenuItemDirective): IContextualMenuItem {
107+
private _directiveToContextualMenuItem(directive: ContextualMenuItemDirective): IContextualMenuItem {
110108
return {
111109
...directive,
112110
onClick: (ev, item) => {

0 commit comments

Comments
 (0)