Skip to content

Commit 88bf7e3

Browse files
author
Ben Grynhaus
committed
[Fabric][CommandBar] Marked transformed '*Items' properties internal
1 parent 2f84392 commit 88bf7e3

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

libs/fabric/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"$schema": "../../node_modules/ng-packagr/package.schema.json",
33
"name": "@angular-react/fabric",
4-
"version": "0.2.1",
4+
"version": "0.2.2",
55
"ngPackage": {
66
"lib": {
77
"entryFile": "public-api.ts",

libs/fabric/src/components/command-bar/command-bar.component.ts

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import omit from "../../utils/omit";
1111
<CommandBar
1212
#reactNode
1313
[componentRef]="componentRef"
14-
[items]="transformedItems"
15-
[farItems]="transformedFarItems"
16-
[overflowItems]="transformedOverflowItems"
14+
[items]="transformedItems_"
15+
[farItems]="transformedFarItems_"
16+
[overflowItems]="transformedOverflowItems_"
1717
[overflowButtonProps]="overflowButtonProps"
1818
[overflowButtonAs]="overflowButtonAs"
1919
[overflowMenuProps]="overflowMenuProps"
@@ -56,9 +56,12 @@ export class FabCommandBarComponent extends ReactWrapperComponent<ICommandBarPro
5656
@Output() readonly onDataReduced = new EventEmitter<{ movedItem: ICommandBarItemProps }>();
5757
@Output() readonly onDataGrown = new EventEmitter<{ movedItem: ICommandBarItemProps }>();
5858

59-
transformedItems: ReadonlyArray<ICommandBarItemProps>;
60-
transformedFarItems: ReadonlyArray<ICommandBarItemProps>;
61-
transformedOverflowItems: ReadonlyArray<ICommandBarItemProps>;
59+
/** @internal */
60+
transformedItems_: ReadonlyArray<ICommandBarItemProps>;
61+
/** @internal */
62+
transformedFarItems_: ReadonlyArray<ICommandBarItemProps>;
63+
/** @internal */
64+
transformedOverflowItems_: ReadonlyArray<ICommandBarItemProps>;
6265

6366
constructor(elementRef: ElementRef, changeDetectorRef: ChangeDetectorRef) {
6467
super(elementRef, changeDetectorRef, true);
@@ -69,19 +72,19 @@ export class FabCommandBarComponent extends ReactWrapperComponent<ICommandBarPro
6972
if (changes['farItems'] && changes['farItems'].previousValue !== changes['farItems'].currentValue && changes['farItems'].currentValue) this._createTransformedFarItems(changes['farItems'].currentValue);
7073
if (changes['overflowItems'] && changes['overflowItems'].previousValue !== changes['overflowItems'].currentValue && changes['overflowItems'].currentValue) this._createTransformedOverflowItems(changes['overflowItems'].currentValue);
7174

72-
this.detectChanges();
75+
super.ngOnChanges(changes);
7376
}
7477

7578
private _createTransformedItems(newItems: ReadonlyArray<ICommandBarItemOptions>) {
76-
this.transformedItems = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
79+
this.transformedItems_ = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
7780
}
7881

7982
private _createTransformedFarItems(newItems: ReadonlyArray<ICommandBarItemOptions>) {
80-
this.transformedFarItems = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
83+
this.transformedFarItems_ = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
8184
}
8285

8386
private _createTransformedOverflowItems(newItems: ReadonlyArray<ICommandBarItemOptions>) {
84-
this.transformedOverflowItems = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
87+
this.transformedOverflowItems_ = newItems.map(item => this._transformCommandBarItemOptionsToProps(item));
8588
}
8689

8790
private _transformCommandBarItemOptionsToProps(itemOptions: ICommandBarItemOptions): ICommandBarItemProps {

0 commit comments

Comments
 (0)