Adding detection of JSON.Net version for line info handling

Author: davilimap

src/Microsoft.VisualStudio.Jdt/JdtExtensions.cs

@@ -55,7 +55,7 @@ internal static JObject CloneWithLineInfo(this JObject objectToClone)
         {
             var loadSettings = new JsonLoadSettings()
             {
-                LineInfoHandling = LineInfoHandling.Load
+                LineInfoHandling = JdtUtilities.GetLineInfoHandling()
             };
 
             using (var objectReader = objectToClone.CreateReader())

src/Microsoft.VisualStudio.Jdt/JdtUtilities.cs

@@ -3,6 +3,10 @@
 
 namespace Microsoft.VisualStudio.Jdt
 {
+    using System;
+    using System.Reflection;
+    using Newtonsoft.Json.Linq;
+
     /// <summary>
     /// Utilities class for handling JSON files
     /// </summary>
@@ -13,6 +17,8 @@ public static class JdtUtilities
         /// </summary>
         internal const string JdtSyntaxPrefix = "@jdt.";
 
+        private static LineInfoHandling? lineInfoHandling = null;
+
         /// <summary>
         /// Wheter the given key corresponds to a JDT verb
         /// </summary>
@@ -36,5 +42,32 @@ public static string GetJdtSyntax(string key)
             // If it is a JDT verb, remove the prefix
             return IsJdtSyntax(key) ? key.Substring(JdtSyntaxPrefix.Length) : null;
         }
+
+        /// <summary>
+        /// Gets the <see cref="LineInfoHandling"/> depending on the Newtonsoft version
+        /// This is due to a bug in previous versions of JSON.Net that loaded line info on ignore and vice-versa
+        /// See https://github.com/JamesNK/Newtonsoft.Json/pull/1250
+        /// </summary>
+        /// <returns>The correct line info handling</returns>
+        internal static LineInfoHandling GetLineInfoHandling()
+        {
+            if (lineInfoHandling == null)
+            {
+                Version newtonsoftVersion = typeof(JObject).GetTypeInfo().Assembly.GetName().Version;
+
+                if (newtonsoftVersion >= new Version("10.0.2"))
+                {
+                    return LineInfoHandling.Load;
+                }
+                else
+                {
+                    return LineInfoHandling.Ignore;
+                }
+            }
+            else
+            {
+                return lineInfoHandling.Value;
+            }
+        }
     }
 }

src/Microsoft.VisualStudio.Jdt/JsonTransformation.cs

@@ -162,7 +162,7 @@ private void SetTransform(Stream transformStream)
             this.loadSettings = new JsonLoadSettings()
             {
                 CommentHandling = CommentHandling.Ignore,
-                LineInfoHandling = LineInfoHandling.Load
+                LineInfoHandling = JdtUtilities.GetLineInfoHandling()
             };
 
             using (StreamReader transformStreamReader = new StreamReader(transformStream))