Removing unnecessary entry point

Add test logger

Author: davilimap

src/Microsoft.VisualStudio.Jdt.Tests/JsonTransformationTestLogger.cs

@@ -0,0 +1,114 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See LICENSE file in the project root for full license information.
+
+namespace Microsoft.VisualStudio.Jdt.Tests
+{
+    using System;
+    using System.Text;
+
+    /// <summary>
+    /// Mock logger to test <see cref="JsonTransformation"/>
+    /// </summary>
+    public class JsonTransformationTestLogger : IJsonTransformationLogger
+    {
+        private readonly StringBuilder errorLog = new StringBuilder();
+
+        private readonly StringBuilder warningLog = new StringBuilder();
+
+        private readonly StringBuilder messageLog = new StringBuilder();
+
+        /// <summary>
+        /// Gets the text from the error log
+        /// </summary>
+        public string ErrorLogText
+        {
+            get
+            {
+                return this.errorLog.ToString();
+            }
+        }
+
+        /// <summary>
+        /// Gets the text from the warning log
+        /// </summary>
+        public string WarningLogText
+        {
+            get
+            {
+                return this.warningLog.ToString();
+            }
+        }
+
+        /// <summary>
+        /// Gets the text from the message log
+        /// </summary>
+        public string MessageLogText
+        {
+            get
+            {
+                return this.messageLog.ToString();
+            }
+        }
+
+        /// <inheritdoc/>
+        public void LogError(string message)
+        {
+            this.errorLog.AppendLine(message);
+        }
+
+        /// <inheritdoc/>
+        public void LogError(string message, string fileName, int lineNumber, int linePosition)
+        {
+            this.errorLog.AppendLine(this.BuildLine(message, fileName, lineNumber, linePosition));
+        }
+
+        /// <inheritdoc/>
+        public void LogErrorFromException(Exception ex)
+        {
+            this.errorLog.AppendLine($"Exception: {ex.Message}");
+        }
+
+        /// <inheritdoc/>
+        public void LogErrorFromException(Exception ex, string fileName, int lineNumber, int linePosition)
+        {
+            this.errorLog.AppendLine(this.BuildLine($"Exception: {ex.Message}", fileName, lineNumber, linePosition));
+        }
+
+        /// <inheritdoc/>
+        public void LogMessage(string message)
+        {
+            this.messageLog.AppendLine(message);
+        }
+
+        /// <inheritdoc/>
+        public void LogWarning(string message)
+        {
+            this.warningLog.AppendLine(message);
+        }
+
+        /// <inheritdoc/>
+        public void LogWarning(string message, string fileName)
+        {
+            this.warningLog.AppendLine($"{message} {fileName}");
+        }
+
+        /// <inheritdoc/>
+        public void LogWarning(string message, string fileName, int lineNumber, int linePosition)
+        {
+            this.warningLog.AppendLine(this.BuildLine(message, fileName, lineNumber, linePosition));
+        }
+
+        private string BuildLine(string message, string fileName, int lineNumber, int linePosition)
+        {
+            string line = message;
+            if (fileName != null)
+            {
+                line += " " + fileName;
+            }
+
+            line += $" {lineNumber} {linePosition}";
+
+            return line;
+        }
+    }
+}

src/Microsoft.VisualStudio.Jdt/IJsonTransformationLogger.cs

@@ -16,15 +16,6 @@ public interface IJsonTransformationLogger
         /// <param name="message">The message text</param>
         void LogMessage(string message);
 
-        /// <summary>
-        /// Logs a message
-        /// </summary>
-        /// <param name="message">The message</param>
-        /// <param name="fileName">The full path to the file that caused the message. Can be null</param>
-        /// <param name="lineNumber">The line that caused the message</param>
-        /// <param name="linePosition">The position in the line that caused the message</param>
-        void LogMessage(string message, string fileName, int lineNumber, int linePosition);
-
         /// <summary>
         /// Logs a warning
         /// </summary>

src/Microsoft.VisualStudio.Jdt/JsonTransformation.cs

@@ -162,10 +162,7 @@ private void SetTransform(Stream transformStream)
             this.loadSettings = new JsonLoadSettings()
             {
                 CommentHandling = CommentHandling.Ignore,
-
-                // Obs: LineInfo is handled on Ignore and not Load
-                // See https://github.com/JamesNK/Newtonsoft.Json/issues/1249
-                LineInfoHandling = LineInfoHandling.Ignore
+                LineInfoHandling = LineInfoHandling.Load
             };
 
             using (StreamReader transformStreamReader = new StreamReader(transformStream))