Skip to content

Commit b8467f9

Browse files
committed
Adding comments
1 parent ff0b690 commit b8467f9

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

src/Microsoft.VisualStudio.Jdt.Tests/JsonTransformationTest.cs

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ public void InvalidVerb()
4141

4242
Assert.Empty(this.logger.MessageLog);
4343
Assert.Empty(this.logger.WarningLog);
44+
45+
// The error should be where at the location of the invalid verb
4446
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 56, true);
4547
}
4648

@@ -58,6 +60,8 @@ public void InvalidVerbValue()
5860

5961
Assert.Empty(this.logger.MessageLog);
6062
Assert.Empty(this.logger.WarningLog);
63+
64+
// The error location should be at the location of the invalid value
6165
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 58, true);
6266
}
6367

@@ -77,6 +81,8 @@ public void InvalidAttribute()
7781

7882
Assert.Empty(this.logger.MessageLog);
7983
Assert.Empty(this.logger.WarningLog);
84+
85+
// The error location should be at the position of the invalid attribute
8086
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 3, 58, true);
8187
}
8288

@@ -96,6 +102,8 @@ public void MissingAttribute()
96102

97103
Assert.Empty(this.logger.MessageLog);
98104
Assert.Empty(this.logger.WarningLog);
105+
106+
// The error location should be at the beginning of the object with the missing attribute
99107
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 57, true);
100108
}
101109

@@ -117,6 +125,8 @@ public void MixedAttributes()
117125

118126
Assert.Empty(this.logger.MessageLog);
119127
Assert.Empty(this.logger.WarningLog);
128+
129+
// The error location should be at the beginning of the object with the mixed attribute
120130
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 57, true);
121131
}
122132

@@ -136,6 +146,8 @@ public void WrongAttributeValue()
136146

137147
Assert.Empty(this.logger.MessageLog);
138148
Assert.Empty(this.logger.WarningLog);
149+
150+
// The error location should be at the position of the invalid value
139151
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 3, 61, true);
140152
}
141153

@@ -155,6 +167,8 @@ public void RemoveNonExistantNode()
155167

156168
Assert.Empty(this.logger.MessageLog);
157169
Assert.Empty(this.logger.ErrorLog);
170+
171+
// The warning location should be at the position of the path value that yielded no results
158172
LogHasSingleEntry(this.logger.WarningLog, ErrorLocation.Transform.ToString(), 3, 59, false);
159173
}
160174

@@ -172,6 +186,8 @@ public void RemoveRoot()
172186

173187
Assert.Empty(this.logger.MessageLog);
174188
Assert.Empty(this.logger.WarningLog);
189+
190+
// The error location should be at the position of the remove value
175191
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 60, true);
176192
}
177193

@@ -191,6 +207,8 @@ public void InvalidRenameValue()
191207

192208
Assert.Empty(this.logger.MessageLog);
193209
Assert.Empty(this.logger.WarningLog);
210+
211+
// The error location should be at the position of the rename property
194212
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 3, 47, true);
195213
}
196214

@@ -210,6 +228,8 @@ public void RenameNonExistantNode()
210228

211229
Assert.Empty(this.logger.MessageLog);
212230
Assert.Empty(this.logger.ErrorLog);
231+
232+
// The position of the warning should be a the beginning of the rename property
213233
LogHasSingleEntry(this.logger.WarningLog, ErrorLocation.Transform.ToString(), 3, 47, false);
214234
}
215235

@@ -227,6 +247,8 @@ public void ReplaceRoot()
227247

228248
Assert.Empty(this.logger.MessageLog);
229249
Assert.Empty(this.logger.WarningLog);
250+
251+
// The position of the error should be at the value of replace that caused it
230252
LogHasSingleEntry(this.logger.ErrorLog, ErrorLocation.Transform.ToString(), 2, 59, true);
231253
}
232254

0 commit comments

Comments
 (0)