Skip to content

Commit 508f4e8

Browse files
jsboigedmytrostruklemillermicrosoft
authored
.Net: Align Chroma memory store behavior with other stores (#2215)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This is an attempt to account for the [following PR](#1989 (comment)). Chroma logs an error when calling DoesCollectionExistAsync on a non existing collection, it should log at debug level instead Also Volatile Store and QDrant return an empty collection when calling GetNearestMatchesAsync whereas Chroma throws an exception. This PR aligns behavior with other stores. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Align chroma store behavior with other common memory stores ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Lee Miller <lemiller@microsoft.com>
1 parent a7a41d6 commit 508f4e8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

dotnet/src/Connectors/Connectors.Memory.Chroma/ChromaMemoryStore.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ await this.GetCollectionAsync(collectionName, cancellationToken).ConfigureAwait(
252252
}
253253
catch (SKException e) when (CollectionDoesNotExistException(e, collectionName))
254254
{
255-
this._logger.LogError("Collection {0} does not exist", collectionName);
255+
this._logger.LogDebug("Collection {0} does not exist", collectionName);
256256

257257
return null;
258258
}

0 commit comments

Comments
 (0)