Merge branch 'main' into build_prefs_fix

Author: benmcmorran

.ackrc

@@ -0,0 +1,2 @@
+--ignore-dir=out
+--ignore-dir=.vscode-test

.eslintrc.yml

@@ -0,0 +1,24 @@
+env:
+  browser: true
+  es6: true
+extends:
+  - 'eslint:recommended'
+  - 'plugin:react/recommended'
+  - 'plugin:@typescript-eslint/eslint-recommended'
+globals:
+  Atomics: readonly
+  SharedArrayBuffer: readonly
+parser: '@typescript-eslint/parser'
+parserOptions:
+  ecmaFeatures:
+    jsx: true
+  ecmaVersion: 2018
+  sourceType: module
+plugins:
+  - react
+  - '@typescript-eslint'
+rules: {
+  "no-empty": ["error", { "allowEmptyCatch": true }],
+  "@typescript-eslint/no-unused-vars": ["error", { "args": "none" }]
+}
+

.github/workflows/build.yml

@@ -1,116 +1,87 @@
-name: CI-Tests
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+name: CI
+
 on:
   push:
     branches:
-      - master
-      - develop
+      - main
+      - release
     tags:
       - v*
   pull_request:
     branches:
-      - master
-      - develop
-
+      - main
+      - release
 
 jobs:
   build:
-    runs-on: ${{ matrix.os }} 
+    runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ ubuntu-latest, macos-latest, windows-latest ]
-    
+
     steps:
-      - name: checkout
+      - name: Checkout
         uses: actions/checkout@v2
-      - name: get node
-        uses: actions/setup-node@v1
+
+      # Node 14 matches the version of Node used by VS Code when this was
+      # written, but it should be updated when VS Code updates its Node version.
+      # Node needs to be installed before OS-specific setup so that we can run
+      # the hash verification script.
+      - name: Use Node 14.x
+        uses: actions/setup-node@v2
         with:
-          node-version: 11.x
-      - name: linux setup
+          node-version: 14.x
+
+      - name: Windows setup
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: |
+          curl -LO https://downloads.arduino.cc/arduino-1.8.19-windows.zip
+          node build/checkHash.js arduino-1.8.19-windows.zip `
+          c704a821089eab2588f1deae775916219b1517febd1dd574ff29958dca873945
+          7z x arduino-1.8.19-windows.zip -o"$Env:TEMP\arduino-ide"
+          echo "$Env:TEMP\arduino-ide\arduino-1.8.19" | Out-File -FilePath $env:GITHUB_PATH -Append
+      - name: Linux setup
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3
-          wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
-          tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
-          sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
+          wget https://downloads.arduino.cc/arduino-1.8.19-linux64.tar.xz -P /home/$USER
+          node build/checkHash.js /home/$USER/arduino-1.8.19-linux64.tar.xz \
+          eb68bddc1d1c0120be2fca1350a03ee34531cf37f51847b21210b6e70545bc9b
+          tar -xvf /home/$USER/arduino-1.8.19-linux64.tar.xz -C /home/$USER/
+          sudo ln -s /home/$USER/arduino-1.8.19/arduino /usr/bin/arduino
           sudo apt-get update
-          sudo apt-get install g++-multilib
-          sudo apt-get install -y build-essential
-          sudo apt-get install libudev-dev
-      - name: macos setup
+          sudo apt-get install -y g++-multilib build-essential libudev-dev
+      - name: macOS setup
         if: ${{ matrix.os == 'macos-latest' }}
-        run: | 
+        run: |
           /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
           brew install arduino --cask
-      - name: preinstall 
-        run: | 
-          npm install -g node-gyp
-          npm install -g vsce
-          npm install -g gulp
-      - name: install
-        run: npm install
-      - name: scripts
-        run: |
-          gulp tslint
-          vsce package
-      - name: run tests
+
+      # Windows agents already have gulp installed.
+      - name: Install gulp
         if: ${{ matrix.os != 'windows-latest' }}
+        run: npm install --global gulp
+      - name: Install global dependencies
+        run: npm install --global node-gyp vsce
+      - name: Install project dependencies
+        run: npm install
+
+      - name: Check for linting errors
+        run: gulp tslint
+      - name: Build and pack extension
+        run: vsce package --out vscode-arduino.vsix
+      - name: Publish extension VSIX as artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: VS Code extension VSIX (${{ matrix.os }})
+          path: vscode-arduino.vsix
+
+      - name: Run tests
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent
-  
-  deploy:
-    needs: build
-    runs-on: ubuntu-latest
-    environment: vsix-publishing
-    if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
-    steps:
-    - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-    - run: echo ${{env.VERSION}}
-    - name: Checkout
-      uses: actions/checkout@v2
-    - name: get node
-      uses: actions/setup-node@v1
-      with:
-        node-version: 11.x
-    - name: linux setup
-      run: |
-        export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
-        sleep 3
-        sudo apt-get update
-        sudo apt-get install g++-multilib
-        sudo apt-get install -y build-essential
-        sudo apt-get install libudev-dev
-    - name: preinstall 
-      run: | 
-        npm install -g node-gyp
-        npm install -g vsce
-        npm install -g gulp
-    - name: install
-      run: npm install
-    - name: scripts
-      run: |
-        gulp tslint
-        vsce package
-    - name: upload .vsix to github tag
-      uses: svenstaro/upload-release-action@v2
-      with:
-        repo_token: ${{ secrets.OAUTH_TOKEN }}
-        file: ${{github.workspace}}/vscode-arduino*.vsix
-        tag: ${{ github.ref }}
-        overwrite: true
-        file_glob: true
-    - name: check for production tag
-      id: check-version
-      run: |
-        if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
-            echo ::set-output name=ISPRODUCTION::true
-        fi
-    - name: publish
-      if: steps.check-version.outputs.ISPRODUCTION == 'true'
-      env:
-        PROD_AIKEY: ${{ secrets.PROD_AIKEY }}
-      run: | 
-        gulp genAikey
-        vsce publish -p ${{ secrets.VSCE_TOKEN }}

.github/workflows/fixed-issues.yml

@@ -0,0 +1,26 @@
+name: Close fixed issues
+
+on:
+  push:
+    tags:
+      - "v[0-9]+.[0-9]+.[0-9]+"
+  workflow_dispatch:
+
+permissions:
+  issues: write
+
+jobs:
+  fixed:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/stale@v4.1.0
+      with:
+        days-before-stale: 0
+        days-before-close: 0
+        ignore-updates: true
+        remove-stale-when-updated: false
+        close-issue-message: >-
+          This issue has been fixed in the latest release of this extension,
+          which is available in the VS Code extension marketplace.
+        stale-issue-label: fixed-pending-release
+        only-labels: fixed-pending-release

.github/workflows/remove-labels.yml

@@ -0,0 +1,18 @@
+name: Remove labels from closed issues
+
+on:
+  issues:
+    types:
+      - closed
+
+permissions:
+  issues: write
+
+jobs:
+  label_issues:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Remove labels
+        uses: andymckay/labeler@e6c4322d0397f3240f0e7e30a33b5c5df2d39e90
+        with:
+          remove-labels: triage, needs-more-info

.github/workflows/stale-issues.yml

@@ -1,22 +1,29 @@
-name: Mark stale issues and close them
+name: Label and close stale issues
 
 on:
   schedule:
     - cron: "0 * * * *"
+  workflow_dispatch:
+
+permissions:
+  issues: write
 
 jobs:
   stale:
-
     runs-on: ubuntu-latest
-
     steps:
-    - uses: blackchoey/stale@releases/v1.2
+    - uses: actions/stale@v4.1.0
       with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
-        stale-issue-message: 'This issue has been automatically marked as stale because it has no recent activities. It will be closed if no further activity occurs within 3 days. Thank you for your contributions.'
-        stale-issue-label: 'stale'
-        days-before-stale: 7
-        only-labels: 'needs more info'
-        last-updated-user-type: 'collaborator'
-        days-before-close: 3
-        operations-per-run: 150
+        days-before-stale: 30
+        days-before-close: 7
+        stale-issue-message: >-
+          This issue has been automatically marked as stale because it has been
+          inactive for 30 days. To reactivate the issue, simply post a comment
+          with the requested information to help us diagnose this issue. If this
+          issue remains inactive for another 7 days, it will be automatically
+          closed.
+        close-issue-message: >-
+          This issue has been automatically closed due to inactivity. If you are
+          still experiencing problems, please open a new issue.
+        stale-issue-label: stale
+        only-labels: needs-more-info

.github/workflows/triage-issues.yml

@@ -0,0 +1,19 @@
+name: Label new issues
+
+on:
+  issues:
+    types:
+      - opened
+      - reopened
+
+permissions:
+  issues: write
+
+jobs:
+  label_issues:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Add triage label
+        uses: andymckay/labeler@e6c4322d0397f3240f0e7e30a33b5c5df2d39e90
+        with:
+          add-labels: triage

.vscode/tasks.json

@@ -15,7 +15,7 @@
     "tasks": [
         {
             "label": "build",
-            "args": [],
+            "args": ["build"],
             "type": "shell",
             "group": "build",
             "isBackground": false,
@@ -25,7 +25,7 @@
         },
         {
             "label": "build_without_view",
-            "args": [],
+            "args": ["build_without_view"],
             "group": "build",
             "isBackground": false,
             "problemMatcher": [

.vscodeignore

@@ -15,4 +15,6 @@ gulpfile.js
 *.log
 webpack.config.js
 node_modules/**
-vendor/**
+vendor/**
+azure-pipelines.yml
+build/**