Fix override

Author: Taaku18

CHANGELOG.md

@@ -22,6 +22,7 @@ however, insignificant breaking changes does not guarantee a major version bump,
 ### Internal
 
 - Use regex to parse Changes, Added, Fixed, etc and description.
+- Adds `PermissionLevel.INVALID` when commands doesn't have a permission level.
 
 # v3.1.1
 

bot.py

@@ -29,6 +29,7 @@
 except ImportError:
     pass
 
+from core import checks
 from core.clients import ApiClient, PluginDatabaseClient
 from core.config import ConfigManager
 from core.utils import human_join, strtobool, parse_alias
@@ -840,6 +841,17 @@ async def process_commands(self, message):
         ctxs = await self.get_contexts(message)
         for ctx in ctxs:
             if ctx.command:
+                if not any(
+                    1
+                    for check in ctx.command.checks
+                    if hasattr(check, "permission_level")
+                ):
+                    logger.debug(
+                        "Command %s has no permissions check, adding invalid level.",
+                        ctx.command.qualified_name,
+                    )
+                    checks.has_permissions(PermissionLevel.INVALID)(ctx.command)
+
                 await self.invoke(ctx)
                 continue
 
@@ -1074,7 +1086,7 @@ async def on_command_error(self, context, exception):
                                 color=discord.Color.red(), description=check.fail_msg
                             )
                         )
-                    if hasattr(check, 'permission_level'):
+                    if hasattr(check, "permission_level"):
                         corrected_permission_level = self.command_perm(
                             context.command.qualified_name
                         )

cogs/utility.py

@@ -646,6 +646,7 @@ async def set_presence(
     @tasks.loop(minutes=45)
     async def loop_presence(self):
         """Set presence to the configured value every 45 minutes."""
+        # TODO: Does this even work?
         presence = await self.set_presence()
         logger.debug(f'{presence["activity"][1]} {presence["status"][1]}')
 
@@ -1295,10 +1296,6 @@ async def permissions_override(
                 command.qualified_name
             ] = level.name
 
-            if not any(check for check in command.checks if hasattr(check, "permission_level")):
-                logger.debug('Command %s has no permissions check, adding invalid.', command.qualified_name)
-                checks.has_permissions(PermissionLevel.INVALID)(command)
-
             await self.bot.config.update()
             embed = Embed(
                 title="Success",
@@ -1618,25 +1615,37 @@ async def permissions_get(
                     for command in self.bot.walk_commands():
                         if command not in done:
                             done.add(command)
-                            level = self.bot.config["override_command_level"].get(command.qualified_name)
+                            level = self.bot.config["override_command_level"].get(
+                                command.qualified_name
+                            )
                             if level is not None:
                                 overrides[command.qualified_name] = level
 
                     embeds = []
                     if not overrides:
-                        embeds.append(Embed(
-                            title="Permission Overrides",
-                            description="You don't have any command level overrides at the moment.",
-                            color=Color.red()
-                        ))
+                        embeds.append(
+                            Embed(
+                                title="Permission Overrides",
+                                description="You don't have any command level overrides at the moment.",
+                                color=Color.red(),
+                            )
+                        )
                     else:
-                        for items in zip_longest(*(iter(sorted(overrides.items())),) * 15):
+                        for items in zip_longest(
+                            *(iter(sorted(overrides.items())),) * 15
+                        ):
                             description = "\n".join(
                                 ": ".join((f"`{name}`", level))
-                                for name, level in takewhile(lambda x: x is not None, items)
+                                for name, level in takewhile(
+                                    lambda x: x is not None, items
+                                )
+                            )
+                            embed = Embed(
+                                color=self.bot.main_color, description=description
+                            )
+                            embed.set_author(
+                                name="Permission Overrides", icon_url=ctx.guild.icon_url
                             )
-                            embed = Embed(color=self.bot.main_color, description=description)
-                            embed.set_author(name="Permission Overrides", icon_url=ctx.guild.icon_url)
                             embeds.append(embed)
 
                     session = EmbedPaginatorSession(ctx, *embeds)

core/checks.py

@@ -7,7 +7,9 @@
 logger = logging.getLogger("Modmail")
 
 
-def has_permissions_predicate(permission_level: PermissionLevel = PermissionLevel.REGULAR):
+def has_permissions_predicate(
+    permission_level: PermissionLevel = PermissionLevel.REGULAR
+):
     async def predicate(ctx):
         return await check_permissions(ctx, ctx.command.qualified_name)