chore: Update to Go 1.25.5 and Go linter 2.7.2 (#3990)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: lantoli

.github/workflows/code-health.yml

@@ -56,7 +56,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20
         with:
-          version: v2.4.0 # Also update GOLANGCI_VERSION variable in GNUmakefile when updating this version
+          version: v2.7.2 # Also update GOLANGCI_VERSION variable in Makefile when updating this version
       - name: actionlint
         run: |
           make tools

Makefile

@@ -16,7 +16,7 @@ GITTAG=$(shell git describe --always --tags)
 VERSION=$(GITTAG:v%=%)
 LINKER_FLAGS=-s -w -X 'github.com/mongodb/terraform-provider-mongodbatlas/version.ProviderVersion=${VERSION}'
 
-GOLANGCI_VERSION=v2.4.0 # Also update golangci-lint GH action in code-health.yml when updating this version
+GOLANGCI_VERSION=v2.7.2 # Also update golangci-lint GH action in code-health.yml when updating this version
 
 export PATH := $(shell go env GOPATH)/bin:$(PATH)
 export SHELL := env PATH=$(PATH) /bin/bash

go.mod

@@ -1,6 +1,6 @@
 module github.com/mongodb/terraform-provider-mongodbatlas
 
-go 1.25.0
+go 1.25.5
 
 require (
 	github.com/andygrunwald/go-jira/v2 v2.0.0-20240116150243-50d59fe116d6

internal/service/cluster/resource_cluster_test.go

@@ -47,7 +47,6 @@ func basicTestCase(tb testing.TB) *resource.TestCase {
 					resource.TestCheckResourceAttrSet(resourceName, "mongo_uri"),
 					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.#"),
 					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.0.regions_config.#"),
-					resource.TestCheckResourceAttr(resourceName, "pit_enabled", "true"),
 					resource.TestCheckResourceAttr(resourceName, "retain_backups_enabled", "true"),
 					resource.TestCheckResourceAttr(resourceName, "version_release_system", "LTS"),
 					resource.TestCheckResourceAttr(resourceName, "accept_data_risks_and_force_replica_set_reconfig", ""),

internal/service/projectinvitation/resource_project_invitation_test.go

@@ -48,7 +48,7 @@ func TestAccProjectRSProjectInvitation_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "username", name),
 					resource.TestCheckResourceAttr(resourceName, "roles.#", "2"),
 					resource.TestCheckTypeSetElemAttr(resourceName, "roles.*", updateRoles[0]),
-					resource.TestCheckTypeSetElemAttr(resourceName, "roles.*", updateRoles[0]),
+					resource.TestCheckTypeSetElemAttr(resourceName, "roles.*", updateRoles[1]),
 				),
 			},
 			{

internal/testutil/acc/pre_check.go

@@ -48,8 +48,8 @@ func PreCheckBasicSleep(tb testing.TB, clusterInfo *ClusterInfo, projectID, clus
 }
 
 // PreCheck checks common Atlas environment variables and MONGODB_ATLAS_PROJECT_ID.
-// Deprecated: it should not be used as MONGODB_ATLAS_PROJECT_ID is not intended to be used in CI.
-// Use PreCheckBasic instead.
+
+// Deprecated: it should not be used as MONGODB_ATLAS_PROJECT_ID is not intended to be used in CI, use PreCheckBasic instead.
 func PreCheck(tb testing.TB) {
 	tb.Helper()
 	PreCheckBasic(tb)