Coverage

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/insert/render/BatchInsert.java

@@ -56,7 +56,7 @@ public String getInsertStatementSQL() {
     }
 
     public List<T> getRecords() {
-        return Collections.unmodifiableList(records);
+        return records;
     }
 
     public static <T> Builder<T> withRecords(List<T> records) {

src/test/java/org/mybatis/dynamic/sql/DeprecatedSortMethodsTest.java

@@ -48,12 +48,43 @@ public String orderByName() {
 
             @Override
             public boolean isDescending() {
-                return true;
+                return false;
             }
        };
 
         OrderByModel model = OrderByModel.of(List.of(ss));
 
+        RenderingContext renderingContext = RenderingContext
+                .withRenderingStrategy(RenderingStrategies.MYBATIS3)
+                .withTableAliasCalculator(TableAliasCalculator.empty())
+                .withStatementConfiguration(new StatementConfiguration())
+                .build();
+        OrderByRenderer renderer = new OrderByRenderer(renderingContext);
+        FragmentAndParameters fp = renderer.render(model);
+        assertThat(fp.fragment()).isEqualTo("order by id");
+    }
+
+    @Test
+    void bothMethodsExistDescending() {
+        SortSpecification ss = new SortSpecification() {
+            @Override
+            public SortSpecification descending() {
+                return this;
+            }
+
+            @Override
+            public String orderByName() {
+                return "id";
+            }
+
+            @Override
+            public boolean isDescending() {
+                return true;
+            }
+        };
+
+        OrderByModel model = OrderByModel.of(List.of(ss));
+
         RenderingContext renderingContext = RenderingContext
                 .withRenderingStrategy(RenderingStrategies.MYBATIS3)
                 .withTableAliasCalculator(TableAliasCalculator.empty())