Update namespaces and fix warnings

Author: nemanjarogic

.editorconfig

@@ -224,19 +224,19 @@ dotnet_diagnostic.CA1028.severity = error # CA1028: Enum storage should be Int32
 dotnet_diagnostic.CA1030.severity = suggestion # CA1030: Use events where appropriate
 dotnet_diagnostic.CA1031.severity = silent # CA1031: Do not catch general exception types
 dotnet_diagnostic.CA1032.severity = silent # CA1032: Implement standard exception constructors
-dotnet_diagnostic.CA1033.severity = error # CA1033: Interface methods should be callable by child types
+dotnet_diagnostic.CA1033.severity = warning # CA1033: Interface methods should be callable by child types
 dotnet_diagnostic.CA1034.severity = none # CA1034: Nested types should not be visible
 dotnet_diagnostic.CA1036.severity = silent # CA1036: Override methods on comparable types
-dotnet_diagnostic.CA1040.severity = error # CA1040: Avoid empty interfaces
+dotnet_diagnostic.CA1040.severity = warning # CA1040: Avoid empty interfaces
 dotnet_diagnostic.CA1041.severity = error # CA1041: Provide ObsoleteAttribute message
 dotnet_diagnostic.CA1043.severity = warning # CA1043: Use integral or string argument for indexers
 dotnet_diagnostic.CA1044.severity = error # CA1044: Properties should not be write only
 dotnet_diagnostic.CA1045.severity = error # CA1045: Do not pass types by reference
 dotnet_diagnostic.CA1046.severity = silent # CA1046: Do not overload operator equals on reference types
 dotnet_diagnostic.CA1047.severity = error # CA1047: Do not declare protected members in sealed types
 dotnet_diagnostic.CA1050.severity = error # CA1050: Declare types in namespaces
-dotnet_diagnostic.CA1051.severity = error # CA1051: Do not declare visible instance fields
-dotnet_diagnostic.CA1052.severity = error # CA1052: Static holder types should be Static or NotInheritable
+dotnet_diagnostic.CA1051.severity = warning # CA1051: Do not declare visible instance fields
+dotnet_diagnostic.CA1052.severity = warning # CA1052: Static holder types should be Static or NotInheritable
 dotnet_diagnostic.CA1053.severity = error # CA1053: Static holder types should not have default constructors
 dotnet_diagnostic.CA1054.severity = suggestion # CA1054: URI parameters should not be strings
 dotnet_diagnostic.CA1055.severity = suggestion # CA1055: URI return values should not be strings
@@ -288,7 +288,7 @@ dotnet_diagnostic.CA1717.severity = suggestion # CA1717: Only FlagsAttribute enu
 dotnet_diagnostic.CA1720.severity = warning # CA1720: Identifiers should not contain type names
 dotnet_diagnostic.CA1721.severity = warning # CA1721: Property names should not match get methods
 dotnet_diagnostic.CA1724.severity = none # CA1724: Type names should not match namespaces
-dotnet_diagnostic.CA1725.severity = error # CA1725: Parameter names should match base declaration
+dotnet_diagnostic.CA1725.severity = warning # CA1725: Parameter names should match base declaration
 dotnet_diagnostic.CA1727.severity = error # CA1727: Use PascalCase for named placeholders
 dotnet_diagnostic.CA1801.severity = error # CA1801: Review unused parameters
 dotnet_diagnostic.CA1802.severity = error # CA1802: Use Literals Where Appropriate
@@ -303,7 +303,7 @@ dotnet_diagnostic.CA1816.severity = error # CA1816: Call GC.SuppressFinalize cor
 dotnet_diagnostic.CA1819.severity = warning # CA1819: Properties should not return arrays
 dotnet_diagnostic.CA1820.severity = error # CA1820: Test for empty strings using string length
 dotnet_diagnostic.CA1821.severity = error # CA1821: Remove empty finalizers
-dotnet_diagnostic.CA1822.severity = error # CA1822: Mark members as static
+dotnet_diagnostic.CA1822.severity = warning # CA1822: Mark members as static
 dotnet_diagnostic.CA1823.severity = error # CA1823: Avoid unused private fields
 dotnet_diagnostic.CA1824.severity = warning # CA1824: Mark assemblies with NeutralResourcesLanguageAttribute
 dotnet_diagnostic.CA1825.severity = error # CA1825: Avoid zero-length array allocations
@@ -468,7 +468,7 @@ dotnet_diagnostic.CA5390.severity = error # CA5390: Do not hard-code encryption
 dotnet_diagnostic.CA5391.severity = warning # CA5391: Use antiforgery tokens in ASP.NET Core MVC controllers
 dotnet_diagnostic.CA5392.severity = warning # CA5392: Use DefaultDllImportSearchPaths attribute for P/Invokes
 dotnet_diagnostic.CA5393.severity = warning # CA5393: Do not use unsafe DllImportSearchPath value
-dotnet_diagnostic.CA5394.severity = error # CA5394: Do not use insecure randomness
+dotnet_diagnostic.CA5394.severity = warning # CA5394: Do not use insecure randomness
 dotnet_diagnostic.CA5395.severity = error # CA5395: Miss HttpVerb attribute for action methods
 dotnet_diagnostic.CA5396.severity = error # CA5396: Set HttpOnly to true for HttpCookie
 dotnet_diagnostic.CA5397.severity = error # CA5397: Do not use deprecated SslProtocols values
@@ -568,7 +568,7 @@ dotnet_diagnostic.IDE0056.severity = warning # IDE0056: Use index operator
 dotnet_diagnostic.IDE0056WithoutSuggestion.severity = warning # IDE0056: Use index operator
 dotnet_diagnostic.IDE0057.severity = suggestion # IDE0057: Use range operator
 dotnet_diagnostic.IDE0057WithoutSuggestion.severity = suggestion # IDE0057: Use range operator
-dotnet_diagnostic.IDE0058.severity = error # IDE0058: Expression value is never used
+dotnet_diagnostic.IDE0058.severity = warning # IDE0058: Expression value is never used
 dotnet_diagnostic.IDE0059.severity = error # IDE0059: Expression value is never used
 dotnet_diagnostic.IDE0060.severity = warning # IDE0060: Remove unused parameter
 dotnet_diagnostic.IDE0061.severity = silent # IDE0061: Use expression body for local functions

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/EventAggregator.cs

@@ -1,6 +1,6 @@
-using EventAggregatorLibrary.Contracts;
+using StoreManagement.Contracts;
 
-namespace EventAggregatorLibrary.Components;
+namespace StoreManagement.Components;
 
 public class EventAggregator : IEventAggregator
 {
@@ -29,7 +29,7 @@ public void Publish(IEvent @event)
             observer.OnNext(@event);
         }
 
-        if (!_typedObservers.TryGetValue(@event.GetType(), out List<IObserver<IEvent>> typedObservers))
+        if (!_typedObservers.TryGetValue(@event.GetType(), out var typedObservers))
         {
             return;
         }
@@ -75,15 +75,15 @@ public IDisposable Subscribe<T>(ICustomObserver<T> newObserver)
             observers = _typedObservers[typeof(T)] = new List<IObserver<IEvent>>();
         }
 
-        return SubsribeAndSendEvents(observers, newObserver, _events.Where(evt => evt is T));
+        return SubscribeAndSendEvents(observers, newObserver, _events.Where(evt => evt is T));
     }
 
     private IDisposable SubscribeToAllEvents(IObserver<IEvent> newObserver)
     {
-        return SubsribeAndSendEvents(_observers, newObserver, _events);
+        return SubscribeAndSendEvents(_observers, newObserver, _events);
     }
 
-    private IDisposable SubsribeAndSendEvents(
+    private IDisposable SubscribeAndSendEvents(
         List<IObserver<IEvent>> currentObservers,
         IObserver<IEvent> newObserver,
         IEnumerable<IEvent> events)
@@ -101,4 +101,4 @@ private IDisposable SubsribeAndSendEvents(
 
         return new Unsubscriber<IEvent>(currentObservers, newObserver);
     }
-}
+}

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/Publishers/OrderPublisher.cs

@@ -1,7 +1,7 @@
-using EventAggregatorLibrary.Contracts;
-using EventAggregatorLibrary.Events;
+using StoreManagement.Contracts;
+using StoreManagement.Events;
 
-namespace EventAggregatorLibrary.Components.Publishers;
+namespace StoreManagement.Components.Publishers;
 
 public class OrderPublisher : IPublisher
 {

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/Publishers/WarehousePublisher.cs

@@ -1,7 +1,7 @@
-using EventAggregatorLibrary.Contracts;
-using EventAggregatorLibrary.Events;
+using StoreManagement.Contracts;
+using StoreManagement.Events;
 
-namespace EventAggregatorLibrary.Components.Publishers;
+namespace StoreManagement.Components.Publishers;
 
 public class WarehousePublisher : IPublisher
 {

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/Subscribers/BusinessTrackingSubscriber.cs

@@ -1,6 +1,6 @@
-using EventAggregatorLibrary.Contracts;
+using StoreManagement.Contracts;
 
-namespace EventAggregatorLibrary.Components.Subscribers;
+namespace StoreManagement.Components.Subscribers;
 
 /// <summary>
 /// Business tracking subscriber tracks all events in the system.

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/Subscribers/OrderSubscriber.cs

@@ -1,7 +1,7 @@
-using EventAggregatorLibrary.Contracts;
-using EventAggregatorLibrary.Events;
+using StoreManagement.Contracts;
+using StoreManagement.Events;
 
-namespace EventAggregatorLibrary.Components.Subscribers;
+namespace StoreManagement.Components.Subscribers;
 
 /// <summary>
 /// Order subscriber tracks only order created event.

src/AdditionalPatterns/EventAggregator/StoreManagement/Components/Unsubscriber.cs

@@ -1,4 +1,4 @@
-namespace EventAggregatorLibrary.Components;
+namespace StoreManagement.Components;
 
 /// <summary>
 /// Enables a subscriber to unsubscribe from further events.
@@ -7,6 +7,7 @@ public class Unsubscriber<T> : IDisposable
 {
     private readonly List<IObserver<T>> _observers;
     private readonly IObserver<T> _observerToUnsubscribe;
+    private bool _isDisposed;
 
     public Unsubscriber(List<IObserver<T>> observers, IObserver<T> observerToUnsubscribe)
     {
@@ -16,10 +17,27 @@ public Unsubscriber(List<IObserver<T>> observers, IObserver<T> observerToUnsubsc
 
     public void Dispose()
     {
-        if (_observers.Contains(_observerToUnsubscribe))
+        Dispose(true);
+        GC.SuppressFinalize(this);
+    }
+
+    // The bulk of the clean-up code is implemented in Dispose(bool)
+    protected virtual void Dispose(bool disposing)
+    {
+        if (_isDisposed)
         {
-            _observers.Remove(_observerToUnsubscribe);
-            Console.WriteLine($"Observer is unsubsribed.");
+            return;
         }
+
+        if (disposing)
+        {
+            if (_observers.Contains(_observerToUnsubscribe))
+            {
+                _observers.Remove(_observerToUnsubscribe);
+                Console.WriteLine($"Observer is unsubsribed.");
+            }
+        }
+
+        _isDisposed = true;
     }
-}
+}

src/AdditionalPatterns/EventAggregator/StoreManagement/Contracts/ICustomObserver.cs

@@ -1,4 +1,4 @@
-namespace EventAggregatorLibrary.Contracts;
+namespace StoreManagement.Contracts;
 
 public interface ICustomObserver<T> : IObserver<IEvent>
     where T : IEvent

src/AdditionalPatterns/EventAggregator/StoreManagement/Contracts/IEvent.cs

@@ -1,4 +1,4 @@
-namespace EventAggregatorLibrary.Contracts;
+namespace StoreManagement.Contracts;
 
 public interface IEvent
 {

src/AdditionalPatterns/EventAggregator/StoreManagement/Contracts/IEventAggregator.cs

@@ -1,4 +1,4 @@
-namespace EventAggregatorLibrary.Contracts;
+namespace StoreManagement.Contracts;
 
 public interface IEventAggregator : IObservable<IEvent>
 {