Merge pull request #586 from FlorentinD/fix-to-undirected

Fix to_undirected config parameter passing

Author: FlorentinD

changelog.md

@@ -13,6 +13,7 @@
 ## Bug fixes
 
 * Fixed an issue where source and target IDs of relationships in heterogeneous OGBL graphs were not parsed correctly.
+* Fixed an issue where configuration parameters such as `aggregation` were ignored by `gds.graph.toUndirected`.
 
 
 ## Improvements

graphdatascience/graph/graph_entity_ops_runner.py

@@ -250,13 +250,13 @@ def _run_procedure(
 
     @graph_type_check
     def __call__(self, G: Graph, relationship_type: str, mutate_relationship_type: str, **config: Any) -> "Series[Any]":
-        return self._run_procedure(G, relationship_type, mutate_relationship_type)
+        return self._run_procedure(G, relationship_type, mutate_relationship_type, **config)
 
     @graph_type_check
     @compatible_with("estimate", min_inclusive=ServerVersion(2, 3, 0))
     def estimate(self, G: Graph, relationship_type: str, mutate_relationship_type: str, **config: Any) -> "Series[Any]":
         self._namespace += ".estimate"
-        return self._run_procedure(G, relationship_type, mutate_relationship_type)
+        return self._run_procedure(G, relationship_type, mutate_relationship_type, **config)
 
 
 class GraphRelationshipsRunner(GraphEntityOpsBaseRunner):

graphdatascience/tests/unit/test_graph_ops.py

@@ -689,6 +689,18 @@ def test_graph_sample_cnarw(runner: CollectingQueryRunner, gds: GraphDataScience
     }
 
 
+def test_graph_relationships_to_undirected(runner: CollectingQueryRunner, gds: GraphDataScience) -> None:
+    G, _ = gds.graph.project("g", "*", "*")
+
+    gds.graph.relationships.toUndirected(G, "REL", "REL_UNDIRECTED", aggregation="MAX")
+
+    assert runner.last_query() == "CALL gds.graph.relationships.toUndirected($graph_name, $config)"
+    assert runner.last_params() == {
+        "graph_name": "g",
+        "config": {"relationshipType": "REL", "mutateRelationshipType": "REL_UNDIRECTED", "aggregation": "MAX"},
+    }
+
+
 @pytest.mark.compatible_with(min_inclusive=ServerVersion(2, 6, 0))
 def test_remote_projection_on_specific_database(runner: CollectingQueryRunner, aura_gds: AuraGraphDataScience) -> None:
     aura_gds.set_database("bar")