Delete session by id on gds.delete

Author: FlorentinD

graphdatascience/session/dedicated_sessions.py

@@ -70,7 +70,7 @@ def get_or_create(
         )
 
         return self._construct_client(
-            session_name=session_name, session_connection=session_connection, db_connection=db_connection
+            session_id=session_id, session_connection=session_connection, db_connection=db_connection
         )
 
     def delete(self, session_name: str, dbid: Optional[str] = None) -> bool:
@@ -137,12 +137,14 @@ def _create_session(
         return create_details
 
     def _construct_client(
-        self, session_name: str, session_connection: DbmsConnectionInfo, db_connection: DbmsConnectionInfo
+        self, session_id: str, session_connection: DbmsConnectionInfo, db_connection: DbmsConnectionInfo
     ) -> AuraGraphDataScience:
         return AuraGraphDataScience(
             gds_session_connection_info=session_connection,
             aura_db_connection_info=db_connection,
-            delete_fn=lambda: self.delete(session_name, dbid=AuraApi.extract_id(db_connection.uri)),
+            delete_fn=lambda: self._aura_api.delete_session(
+                session_id=session_id, dbid=AuraApi.extract_id(db_connection.uri)
+            ),
         )
 
     def _check_expiry_date(self, session: SessionDetails) -> None:

graphdatascience/tests/unit/test_dedicated_sessions.py

@@ -244,7 +244,7 @@ def test_create_session(mocker: MockerFixture, aura_api: AuraApi) -> None:
         "session_connection": DbmsConnectionInfo(
             uri="neo4j+s://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
         ),
-        "session_name": "my-session",
+        "session_id": "ffff0-ffff1",
     }
     assert [i.name for i in sessions.list()] == ["my-session"]
 
@@ -274,7 +274,7 @@ def test_get_or_create(mocker: MockerFixture, aura_api: AuraApi) -> None:
         "session_connection": DbmsConnectionInfo(
             uri="neo4j+s://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
         ),
-        "session_name": "my-session",
+        "session_id": "ffff0-ffff1",
     }
     assert gds_args1 == gds_args2