Skip to content

Commit e173edc

Browse files
committed
Use real certs to connect to GDS Session
1 parent d644d04 commit e173edc

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

graphdatascience/query_runner/aura_db_query_runner.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33

44
from pandas import DataFrame
55

6-
from graphdatascience.query_runner.graph_constructor import GraphConstructor
7-
from graphdatascience.server_version.server_version import ServerVersion
6+
from ..call_parameters import CallParameters
87
from .gds_arrow_client import GdsArrowClient
98
from .query_runner import QueryRunner
10-
from ..call_parameters import CallParameters
9+
from graphdatascience.query_runner.graph_constructor import GraphConstructor
10+
from graphdatascience.server_version.server_version import ServerVersion
1111

1212

1313
class AuraDbQueryRunner(QueryRunner):

graphdatascience/session/aura_api_responses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def fromJson(cls, json: Dict[str, Any]) -> SessionDetails:
4242
)
4343

4444
def bolt_connection_url(self) -> str:
45-
return f"neo4j+ssc://{self.host}" # TODO use neo4j+s
45+
return f"neo4j+s://{self.host}"
4646

4747
def is_expired(self) -> bool:
4848
return self.status == "Expired"

graphdatascience/tests/unit/test_aura_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def test_wait_for_session_running(requests_mock: Mocker) -> None:
235235

236236
api = AuraApi("", "", tenant_id="some-tenant")
237237

238-
assert api.wait_for_session_running("id0", "db2") == WaitResult.from_connection_url("neo4j+ssc://foo.bar")
238+
assert api.wait_for_session_running("id0", "db2") == WaitResult.from_connection_url("neo4j+s://foo.bar")
239239

240240

241241
def test_delete_instance(requests_mock: Mocker) -> None:

graphdatascience/tests/unit/test_dedicated_sessions.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,15 @@ def test_create_session(mocker: MockerFixture, aura_api: AuraApi) -> None:
190190
gds_credentials = sessions.get_or_create(
191191
"my-session",
192192
SessionMemory.m_8GB,
193-
DbmsConnectionInfo("neo4j+ssc://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
193+
DbmsConnectionInfo("neo4j+s://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
194194
)
195195

196196
assert gds_credentials == { # type: ignore
197197
"db_connection": DbmsConnectionInfo(
198-
uri="neo4j+ssc://ffff0.databases.neo4j.io", username="dbuser", password="db_pw"
198+
uri="neo4j+s://ffff0.databases.neo4j.io", username="dbuser", password="db_pw"
199199
),
200200
"session_connection": DbmsConnectionInfo(
201-
uri="neo4j+ssc://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
201+
uri="neo4j+s://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
202202
),
203203
"session_name": "my-session",
204204
}
@@ -215,20 +215,20 @@ def test_get_or_create(mocker: MockerFixture, aura_api: AuraApi) -> None:
215215
gds_args1 = sessions.get_or_create(
216216
"my-session",
217217
SessionMemory.m_8GB,
218-
DbmsConnectionInfo("neo4j+ssc://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
218+
DbmsConnectionInfo("neo4j+s://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
219219
)
220220
gds_args2 = sessions.get_or_create(
221221
"my-session",
222222
SessionMemory.m_8GB,
223-
DbmsConnectionInfo("neo4j+ssc://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
223+
DbmsConnectionInfo("neo4j+s://ffff0.databases.neo4j.io", "dbuser", "db_pw"),
224224
)
225225

226226
assert gds_args1 == { # type: ignore
227227
"db_connection": DbmsConnectionInfo(
228-
uri="neo4j+ssc://ffff0.databases.neo4j.io", username="dbuser", password="db_pw"
228+
uri="neo4j+s://ffff0.databases.neo4j.io", username="dbuser", password="db_pw"
229229
),
230230
"session_connection": DbmsConnectionInfo(
231-
uri="neo4j+ssc://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
231+
uri="neo4j+s://foo.bar", username="neo4j", password=HASHED_DB_PASSWORD
232232
),
233233
"session_name": "my-session",
234234
}

0 commit comments

Comments
 (0)