Make Nodes#schema mandatory

Co-authored-by: Sören Reichardt <soren.reichardt@neotechnology.com>

Author: s1ck

core/src/main/java/org/neo4j/gds/core/loading/Nodes.java

@@ -20,7 +20,6 @@
 package org.neo4j.gds.core.loading;
 
 import org.immutables.value.Value;
-import org.jetbrains.annotations.TestOnly;
 import org.neo4j.gds.annotation.ValueClass;
 import org.neo4j.gds.api.IdMap;
 import org.neo4j.gds.api.properties.nodes.NodePropertyStore;
@@ -29,10 +28,7 @@
 @ValueClass
 public interface Nodes {
 
-    @Value.Default
-    default NodeSchema schema() {
-        return NodeSchema.empty();
-    }
+    NodeSchema schema();
 
     IdMap idMap();
 
@@ -41,9 +37,4 @@ default NodePropertyStore properties() {
         return NodePropertyStore.empty();
     }
 
-    @TestOnly
-    static Nodes of(IdMap idmap) {
-        return ImmutableNodes.of(NodeSchema.empty(), idmap, NodePropertyStore.empty());
-    }
-
 }

core/src/test/java/org/neo4j/gds/config/WriteConfigTest.java

@@ -24,11 +24,12 @@
 import org.neo4j.gds.annotation.Configuration;
 import org.neo4j.gds.api.DatabaseId;
 import org.neo4j.gds.api.schema.GraphSchema;
+import org.neo4j.gds.api.schema.NodeSchema;
 import org.neo4j.gds.core.CypherMapWrapper;
 import org.neo4j.gds.core.huge.DirectIdMap;
 import org.neo4j.gds.core.loading.GraphStoreBuilder;
+import org.neo4j.gds.core.loading.ImmutableNodes;
 import org.neo4j.gds.core.loading.ImmutableStaticCapabilities;
-import org.neo4j.gds.core.loading.Nodes;
 import org.neo4j.gds.core.loading.RelationshipImportResult;
 
 import java.util.List;
@@ -44,11 +45,16 @@ void validateGraphStoreCapabilities(boolean isBackedByDatabase) {
         var config = CypherMapWrapper.empty();
         var testConfig = new TestWriteConfigImpl(config);
 
+        var nodes = ImmutableNodes.builder()
+            .idMap(new DirectIdMap(0))
+            .schema(NodeSchema.empty())
+            .build();
+
         var testGraphStore = new GraphStoreBuilder()
             .databaseId(DatabaseId.from("neo4j"))
             .capabilities(ImmutableStaticCapabilities.of(isBackedByDatabase))
             .schema(GraphSchema.empty())
-            .nodes(Nodes.of(new DirectIdMap(0)))
+            .nodes(nodes)
             .relationshipImportResult(RelationshipImportResult.of(Map.of()))
             .concurrency(1)
             .build();

cypher-aggregation/src/main/java/org/neo4j/gds/projection/GraphAggregator.java

@@ -652,7 +652,7 @@ private AdjacencyCompressor.ValueMapper buildNodesWithProperties(GraphStoreBuild
                 );
             });
 
-            graphStoreBuilder.nodes(nodesBuilder.build());
+            graphStoreBuilder.nodes(nodesBuilder.schema(nodeSchema).build());
 
             // Relationships are added using their intermediate node ids.
             // In order to map to the final internal ids, we need to use

io/core/src/test/java/org/neo4j/gds/core/io/file/GraphStoreRelationshipVisitorTest.java

@@ -27,8 +27,8 @@
 import org.neo4j.gds.api.RelationshipPropertyStore;
 import org.neo4j.gds.core.io.GraphStoreRelationshipVisitor;
 import org.neo4j.gds.core.loading.GraphStoreBuilder;
+import org.neo4j.gds.core.loading.ImmutableNodes;
 import org.neo4j.gds.core.loading.ImmutableStaticCapabilities;
-import org.neo4j.gds.core.loading.Nodes;
 import org.neo4j.gds.core.loading.RelationshipImportResult;
 import org.neo4j.gds.core.loading.construction.GraphFactory;
 import org.neo4j.gds.core.loading.construction.RelationshipsBuilder;
@@ -151,11 +151,16 @@ private Graph createGraph(
         var actualRelationships = FileToGraphStoreImporter.relationshipTopologyAndProperties(relationshipBuildersByType);
         assertThat(actualRelationships.importedRelationships()).isEqualTo(expectedImportedRelationshipsCount);
 
+        var nodes = ImmutableNodes.builder()
+            .idMap(expectedGraph)
+            .schema(expectedGraph.schema().nodeSchema())
+            .build();
+
         Map<RelationshipType, RelationshipPropertyStore> propertyStores = actualRelationships.properties();
         return new GraphStoreBuilder()
             .schema(expectedGraph.schema())
             .capabilities(ImmutableStaticCapabilities.of(true))
-            .nodes(Nodes.of(expectedGraph))
+            .nodes(nodes)
             .relationshipImportResult(RelationshipImportResult.of(
                 actualRelationships.topologies(),
                 propertyStores,