Merge pull request #10894 from adamnsch/int-random-seed

Allow integer random seeds

Author: breakanalysis

config-api/src/main/java/org/neo4j/gds/config/RandomSeedConfig.java

@@ -19,8 +19,30 @@
  */
 package org.neo4j.gds.config;
 
+import java.util.Map;
 import java.util.Optional;
 
+import org.jetbrains.annotations.Nullable;
+import org.neo4j.gds.annotation.Configuration;
+import org.neo4j.gds.core.CypherMapWrapper;
+
+@Configuration
 public interface RandomSeedConfig {
+    @Configuration.ConvertWith(method = "toLong")
     Optional<Long> randomSeed();
+
+    static Long toLong(Object obj) {
+        if (obj instanceof Integer) {
+            return ((Integer) obj).longValue();
+        } else if (obj instanceof Long) {
+            return (Long) obj;
+        } else {
+            throw new IllegalArgumentException("Object must be of type int, Integer, long, or Long");
+        }
+    }
+
+    static RandomSeedConfig of(@Nullable Map<String, ?> userInput) {
+        return new RandomSeedConfigImpl(CypherMapWrapper.create(userInput));
+    }
 }
+

config-api/src/test/java/RandomSeedConfigTest.java

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) "Neo4j"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Neo4j is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.neo4j.gds.config.RandomSeedConfig;
+
+import java.util.Collections;
+import java.util.Map;
+import java.util.Optional;
+
+class RandomSeedConfigTest {
+
+    @Test
+    void shouldAcceptInt() {
+        var config = RandomSeedConfig.of(Map.of("randomSeed", 42));
+        Assertions.assertEquals(42L, config.randomSeed().get());
+    }
+
+    @Test
+    void shouldAcceptLong() {
+        var config = RandomSeedConfig.of(Map.of("randomSeed", 42L));
+        Assertions.assertEquals(42L, config.randomSeed().get());
+    }
+
+    @Test
+    void shouldAcceptEmpty() {
+        var config = RandomSeedConfig.of(Collections.emptyMap());
+        Assertions.assertEquals(Optional.empty(), config.randomSeed());
+    }
+}