Skip to content

Commit 1b5e888

Browse files
soerenreichardtsoerenreichardt
committed
Throw on each method instead of constructor
1 parent e2439af commit 1b5e888

File tree

5 files changed

+105
-125
lines changed

5 files changed

+105
-125
lines changed

‎compatibility/5.1/storage-engine-adapter/src/main/java/org/neo4j/gds/compat/_51/InMemoryStorageEngineFactory.java‎

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,9 @@
6565
@ServiceProvider
6666
public class InMemoryStorageEngineFactory implements StorageEngineFactory {
6767

68-
public InMemoryStorageEngineFactory() {
69-
throw new UnsupportedOperationException("This should never be instantiated");
70-
}
71-
7268
@Override
7369
public String name() {
74-
return null;
70+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
7571
}
7672

7773
@Override
@@ -83,22 +79,22 @@ public StoreVersionCheck versionCheck(
8379
LogService logService,
8480
PageCacheTracer pageCacheTracer
8581
) {
86-
return null;
82+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
8783
}
8884

8985
@Override
9086
public StoreVersion versionInformation(String storeVersion) {
91-
return null;
87+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
9288
}
9389

9490
@Override
9591
public StoreVersion versionInformation(StoreId storeId) {
96-
return null;
92+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
9793
}
9894

9995
@Override
10096
public RollingUpgradeCompatibility rollingUpgradeCompatibility() {
101-
return null;
97+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
10298
}
10399

104100
@Override
@@ -111,7 +107,7 @@ public List<StoreMigrationParticipant> migrationParticipants(
111107
PageCacheTracer cacheTracer,
112108
MemoryTracker memoryTracker
113109
) {
114-
return null;
110+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
115111
}
116112

117113
@Override
@@ -136,18 +132,18 @@ public StorageEngine instantiate(
136132
DatabaseReadOnlyChecker readOnlyChecker,
137133
MemoryTracker memoryTracker
138134
) {
139-
return null;
135+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
140136
}
141137

142138
@Override
143139
public List<Path> listStorageFiles(FileSystemAbstraction fileSystem, DatabaseLayout databaseLayout) throws
144140
IOException {
145-
return null;
141+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
146142
}
147143

148144
@Override
149145
public boolean storageExists(FileSystemAbstraction fileSystem, DatabaseLayout databaseLayout, PageCache pageCache) {
150-
return false;
146+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
151147
}
152148

153149
@Override
@@ -157,7 +153,7 @@ public TransactionIdStore readOnlyTransactionIdStore(
157153
PageCache pageCache,
158154
CursorContext cursorContext
159155
) throws IOException {
160-
return null;
156+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
161157
}
162158

163159
@Override
@@ -166,7 +162,7 @@ public LogVersionRepository readOnlyLogVersionRepository(
166162
PageCache pageCache,
167163
CursorContext cursorContext
168164
) throws IOException {
169-
return null;
165+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
170166
}
171167

172168
@Override
@@ -178,7 +174,7 @@ public MetadataProvider transactionMetaDataStore(
178174
PageCacheTracer cacheTracer,
179175
DatabaseReadOnlyChecker readOnlyChecker
180176
) throws IOException {
181-
return null;
177+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
182178
}
183179

184180
@Override
@@ -188,7 +184,7 @@ public StoreId storeId(
188184
PageCache pageCache,
189185
CursorContext cursorContext
190186
) throws IOException {
191-
return null;
187+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
192188
}
193189

194190
@Override
@@ -201,7 +197,7 @@ public void setStoreId(
201197
long upgradeTxChecksum,
202198
long upgradeTxCommitTimestamp
203199
) throws IOException {
204-
200+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
205201
}
206202

207203
@Override
@@ -212,7 +208,7 @@ public void setExternalStoreUUID(
212208
CursorContext cursorContext,
213209
UUID externalStoreId
214210
) throws IOException {
215-
211+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
216212
}
217213

218214
@Override
@@ -222,7 +218,7 @@ public Optional<UUID> databaseIdUuid(
222218
PageCache pageCache,
223219
CursorContext cursorContext
224220
) {
225-
return Optional.empty();
221+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
226222
}
227223

228224
@Override
@@ -237,7 +233,7 @@ public SchemaRuleMigrationAccess schemaRuleMigrationAccess(
237233
CursorContext cursorContext,
238234
MemoryTracker memoryTracker
239235
) {
240-
return null;
236+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
241237
}
242238

243239
@Override
@@ -248,7 +244,7 @@ public List<SchemaRule> loadSchemaRules(
248244
DatabaseLayout databaseLayout,
249245
CursorContext cursorContext
250246
) {
251-
return null;
247+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
252248
}
253249

254250
@Override
@@ -257,16 +253,16 @@ public StorageFilesState checkStoreFileState(
257253
DatabaseLayout databaseLayout,
258254
PageCache pageCache
259255
) {
260-
return null;
256+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
261257
}
262258

263259
@Override
264260
public CommandReaderFactory commandReaderFactory() {
265-
return null;
261+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
266262
}
267263

268264
@Override
269265
public DatabaseLayout databaseLayout(Neo4jLayout neo4jLayout, String databaseName) {
270-
return null;
266+
throw new UnsupportedOperationException("5.1 storage engine requires JDK17");
271267
}
272268
}

‎compatibility/5.2/storage-engine-adapter/src/main/java/org/neo4j/gds/compat/_52/InMemoryStorageEngineFactory.java‎

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,9 @@
6565
@ServiceProvider
6666
public class InMemoryStorageEngineFactory implements StorageEngineFactory {
6767

68-
public InMemoryStorageEngineFactory() {
69-
throw new UnsupportedOperationException("This should never be instantiated");
70-
}
71-
7268
@Override
7369
public String name() {
74-
return null;
70+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
7571
}
7672

7773
@Override
@@ -83,22 +79,22 @@ public StoreVersionCheck versionCheck(
8379
LogService logService,
8480
PageCacheTracer pageCacheTracer
8581
) {
86-
return null;
82+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
8783
}
8884

8985
@Override
9086
public StoreVersion versionInformation(String storeVersion) {
91-
return null;
87+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
9288
}
9389

9490
@Override
9591
public StoreVersion versionInformation(StoreId storeId) {
96-
return null;
92+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
9793
}
9894

9995
@Override
10096
public RollingUpgradeCompatibility rollingUpgradeCompatibility() {
101-
return null;
97+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
10298
}
10399

104100
@Override
@@ -111,7 +107,7 @@ public List<StoreMigrationParticipant> migrationParticipants(
111107
PageCacheTracer cacheTracer,
112108
MemoryTracker memoryTracker
113109
) {
114-
return null;
110+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
115111
}
116112

117113
@Override
@@ -136,18 +132,18 @@ public StorageEngine instantiate(
136132
DatabaseReadOnlyChecker readOnlyChecker,
137133
MemoryTracker memoryTracker
138134
) {
139-
return null;
135+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
140136
}
141137

142138
@Override
143139
public List<Path> listStorageFiles(FileSystemAbstraction fileSystem, DatabaseLayout databaseLayout) throws
144140
IOException {
145-
return null;
141+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
146142
}
147143

148144
@Override
149145
public boolean storageExists(FileSystemAbstraction fileSystem, DatabaseLayout databaseLayout, PageCache pageCache) {
150-
return false;
146+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
151147
}
152148

153149
@Override
@@ -157,7 +153,7 @@ public TransactionIdStore readOnlyTransactionIdStore(
157153
PageCache pageCache,
158154
CursorContext cursorContext
159155
) throws IOException {
160-
return null;
156+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
161157
}
162158

163159
@Override
@@ -166,7 +162,7 @@ public LogVersionRepository readOnlyLogVersionRepository(
166162
PageCache pageCache,
167163
CursorContext cursorContext
168164
) throws IOException {
169-
return null;
165+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
170166
}
171167

172168
@Override
@@ -178,7 +174,7 @@ public MetadataProvider transactionMetaDataStore(
178174
PageCacheTracer cacheTracer,
179175
DatabaseReadOnlyChecker readOnlyChecker
180176
) throws IOException {
181-
return null;
177+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
182178
}
183179

184180
@Override
@@ -188,7 +184,7 @@ public StoreId storeId(
188184
PageCache pageCache,
189185
CursorContext cursorContext
190186
) throws IOException {
191-
return null;
187+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
192188
}
193189

194190
@Override
@@ -201,7 +197,7 @@ public void setStoreId(
201197
long upgradeTxChecksum,
202198
long upgradeTxCommitTimestamp
203199
) throws IOException {
204-
200+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
205201
}
206202

207203
@Override
@@ -212,7 +208,7 @@ public void setExternalStoreUUID(
212208
CursorContext cursorContext,
213209
UUID externalStoreId
214210
) throws IOException {
215-
211+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
216212
}
217213

218214
@Override
@@ -222,7 +218,7 @@ public Optional<UUID> databaseIdUuid(
222218
PageCache pageCache,
223219
CursorContext cursorContext
224220
) {
225-
return Optional.empty();
221+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
226222
}
227223

228224
@Override
@@ -237,7 +233,7 @@ public SchemaRuleMigrationAccess schemaRuleMigrationAccess(
237233
CursorContext cursorContext,
238234
MemoryTracker memoryTracker
239235
) {
240-
return null;
236+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
241237
}
242238

243239
@Override
@@ -248,7 +244,7 @@ public List<SchemaRule> loadSchemaRules(
248244
DatabaseLayout databaseLayout,
249245
CursorContext cursorContext
250246
) {
251-
return null;
247+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
252248
}
253249

254250
@Override
@@ -257,16 +253,16 @@ public StorageFilesState checkStoreFileState(
257253
DatabaseLayout databaseLayout,
258254
PageCache pageCache
259255
) {
260-
return null;
256+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
261257
}
262258

263259
@Override
264260
public CommandReaderFactory commandReaderFactory() {
265-
return null;
261+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
266262
}
267263

268264
@Override
269265
public DatabaseLayout databaseLayout(Neo4jLayout neo4jLayout, String databaseName) {
270-
return null;
266+
throw new UnsupportedOperationException("5.2 storage engine requires JDK17");
271267
}
272268
}

0 commit comments

Comments
 (0)