the little wcc stub should not unilaterally decide to close progress trackers or not; have the algorithms decide that

Author: lassewesth

algo/src/main/java/org/neo4j/gds/similarity/nodesim/NodeSimilarity.java

@@ -221,7 +221,7 @@ private LongUnaryOperator initComponents() {
         // run WCC to determine components
         progressTracker.beginSubTask();
         var wccParameters = new WccParameters(0D, concurrency);
-        var disjointSets = wccStub.wcc(graph, wccParameters, ProgressTracker.NULL_TRACKER);
+        var disjointSets = wccStub.wcc(graph, wccParameters, ProgressTracker.NULL_TRACKER, false);
         progressTracker.endSubTask();
         return disjointSets::setIdOf;
     }

algo/src/main/java/org/neo4j/gds/wcc/WccStub.java

@@ -40,7 +40,12 @@ public WccStub(TerminationFlag terminationFlag, AlgorithmMachinery algorithmMach
         this.algorithmMachinery = algorithmMachinery;
     }
 
-    public DisjointSetStruct wcc(Graph graph, WccParameters parameters, ProgressTracker progressTracker) {
+    public DisjointSetStruct wcc(
+        Graph graph,
+        WccParameters parameters,
+        ProgressTracker progressTracker,
+        boolean shouldReleaseProgressTracker
+    ) {
         var algorithm = new Wcc(
             graph,
             DefaultPool.INSTANCE,
@@ -50,6 +55,11 @@ public DisjointSetStruct wcc(Graph graph, WccParameters parameters, ProgressTrac
             terminationFlag
         );
 
-        return algorithmMachinery.runAlgorithmsAndManageProgressTracker(algorithm, progressTracker, true, parameters.concurrency());
+        return algorithmMachinery.runAlgorithmsAndManageProgressTracker(
+            algorithm,
+            progressTracker,
+            shouldReleaseProgressTracker,
+            parameters.concurrency()
+        );
     }
 }

algo/src/test/java/org/neo4j/gds/wcc/WccTest.java

@@ -309,7 +309,7 @@ private void assertResults(TestGraph graph) {
             var wccStub = new WccStub(TerminationFlag.RUNNING_TRUE, new AlgorithmMachinery());
 
             var parameters = new WccParameters(0D, new Concurrency(4));
-            var dss = wccStub.wcc(graph, parameters, ProgressTracker.NULL_TRACKER);
+            var dss = wccStub.wcc(graph, parameters, ProgressTracker.NULL_TRACKER, true);
 
             var actualCommunities = new ArrayList<Long>();
             graph.forEachNode(node -> actualCommunities.add(dss.setIdOf(node)));

applications/algorithms/community/src/main/java/org/neo4j/gds/applications/algorithms/community/CommunityAlgorithms.java

@@ -463,7 +463,7 @@ public DisjointSetStruct wcc(Graph graph, WccBaseConfig configuration) {
 
         var wccStub = new WccStub(terminationFlag, algorithmMachinery);
 
-        return wccStub.wcc(graph, configuration.toParameters(), progressTracker);
+        return wccStub.wcc(graph, configuration.toParameters(), progressTracker, true);
     }
 
     private Task constructKMeansProgressTask(Graph graph, KmeansBaseConfig configuration) {