Implement new PropertyValues::maxIndex

This can be used to find out the highest index to check if you want to retrieve every value.

Author: FlorentinD

algo-common/src/main/java/org/neo4j/gds/scaling/ScaleProperties.java

@@ -228,6 +228,11 @@ public double doubleValue(long nodeId) {
             public long valuesStored() {
                 return property.valuesStored();
             }
+
+            @Override
+            public long maxIndex() {
+                return property.maxIndex();
+            }
         };
     }
 
@@ -247,6 +252,11 @@ public double doubleValue(long nodeId) {
             public long valuesStored() {
                 return property.valuesStored();
             }
+
+            @Override
+            public long maxIndex() {
+                return property.maxIndex();
+            }
         };
     }
 
@@ -266,6 +276,11 @@ public double doubleValue(long nodeId) {
             public long valuesStored() {
                 return property.valuesStored();
             }
+
+            @Override
+            public long maxIndex() {
+                return property.maxIndex();
+            }
         };
     }
 

algo/src/main/java/org/neo4j/gds/modularityoptimization/ModularityOptimization.java

@@ -419,6 +419,11 @@ public long longValue(long nodeId) {
             public long valuesStored() {
                 return currentCommunities.size();
             }
+
+            @Override
+            public long maxIndex() {
+                return graph.nodeCount();
+            }
         };
     }
 }

algo/src/main/java/org/neo4j/gds/pagerank/EigenvectorComputation.java

@@ -119,6 +119,11 @@ public long valuesStored() {
                 return context.nodeCount();
             }
 
+            @Override
+            public long maxIndex() {
+                return context.nodeCount();
+            }
+
             @Override
             public double doubleValue(long nodeId) {
                 return context.doubleNodeValue(nodeId, NEXT_RANK);

algo/src/main/java/org/neo4j/gds/similarity/knn/metrics/LongArrayPropertySimilarityComputer.java

@@ -55,7 +55,7 @@ static final class SortedLongArrayPropertyValues implements LongArrayNodePropert
         private final HugeObjectArray<long[]> properties;
 
         SortedLongArrayPropertyValues(NodePropertyValues nodePropertyValues) {
-            this.properties = HugeObjectArray.newArray(long[].class, nodePropertyValues.valuesStored());
+            this.properties = HugeObjectArray.newArray(long[].class, nodePropertyValues.maxIndex());
             this.properties.setAll(i -> {
                 long[] input = nodePropertyValues.longArrayValue(i);
 
@@ -74,6 +74,11 @@ public long valuesStored() {
             return properties.size();
         }
 
+        @Override
+        public long maxIndex() {
+            return properties.size();
+        }
+
         @Override
         public long[] longArrayValue(long nodeId) {
             return properties.get(nodeId);

algo/src/main/java/org/neo4j/gds/similarity/knn/metrics/NullCheckingNodePropertyValues.java

@@ -90,6 +90,11 @@ public long valuesStored() {
         return properties.valuesStored();
     }
 
+    @Override
+    public long maxIndex() {
+        return properties.maxIndex();
+    }
+
     private void check(long nodeId, @Nullable Object value) {
         if (value == null) {
             throw new IllegalArgumentException(formatWithLocale(

algo/src/test/java/org/neo4j/gds/similarity/knn/GenerateRandomNeighborsTest.java

@@ -25,6 +25,7 @@
 import org.eclipse.collections.api.tuple.primitive.IntIntPair;
 import org.neo4j.gds.api.properties.nodes.LongNodePropertyValues;
 import org.neo4j.gds.core.huge.DirectIdMap;
+import org.neo4j.gds.core.utils.IdentityPropertyValues;
 import org.neo4j.gds.core.utils.paged.HugeObjectArray;
 import org.neo4j.gds.core.utils.partition.Partition;
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
@@ -51,17 +52,7 @@ void neighborsForKEqualsNMinus1startWithEachOtherAsNeighbors(
             nodeCount
         );
 
-        var nodeProperties = new LongNodePropertyValues() {
-            @Override
-            public long longValue(long nodeId) {
-                return nodeId;
-            }
-
-            @Override
-            public long valuesStored() {
-                return nodeCount;
-            }
-        };
+        var nodeProperties = new IdentityPropertyValues(nodeCount);
 
         var similarityComputer = SimilarityComputer.ofProperty(
             idMap,

algo/src/test/java/org/neo4j/gds/similarity/knn/metrics/LongArrayPropertySimilarityComputerTest.java

@@ -40,6 +40,11 @@ public long[] longArrayValue(long nodeId) {
             public long valuesStored() {
                 return 2;
             }
+
+            @Override
+            public long maxIndex() {
+                return 3;
+            }
         };
 
         var sortedValues = new LongArrayPropertySimilarityComputer.SortedLongArrayPropertyValues(sparseProperties);

algo/src/test/java/org/neo4j/gds/similarity/knn/metrics/SimilarityComputerTest.java

@@ -266,6 +266,11 @@ public long[] longArrayValue(long nodeId) {
 
             @Override
             public long valuesStored() {
+                return 0;
+            }
+
+            @Override
+            public long maxIndex() {
                 return nodeCount;
             }
         };

alpha/alpha-proc/src/main/java/org/neo4j/gds/centrality/HarmonicCentralityWriteProc.java

@@ -96,6 +96,11 @@ public long valuesStored() {
                         return computationResult.graph().nodeCount();
                     }
 
+                    @Override
+                    public long maxIndex() {
+                        return computationResult.graph().nodeCount();
+                    }
+
                     @Override
                     public double doubleValue(long nodeId) {
                         return computationResult.result().getCentralityScore(nodeId);

alpha/alpha-proc/src/main/java/org/neo4j/gds/influenceMaximization/CelfNodeProperties.java

@@ -34,6 +34,11 @@ class CelfNodeProperties implements DoubleNodePropertyValues {
 
     @Override
     public long valuesStored() {
+        return celfSeedSet.size();
+    }
+
+    @Override
+    public long maxIndex() {
         return totalGraphNodeCount;
     }