Clique counting requires undirected

Co-authored-by: Alfred Clemedtson <alfred.clemedtson@neo4j.com>

Author: IoannisPanagiotas

procedures/facade-api/configs/community-configs/src/main/java/org/neo4j/gds/cliquecounting/CliqueCountingBaseConfig.java

@@ -19,10 +19,18 @@
  */
 package org.neo4j.gds.cliquecounting;
 
+import org.neo4j.gds.NodeLabel;
+import org.neo4j.gds.RelationshipType;
 import org.neo4j.gds.annotation.Configuration;
+import org.neo4j.gds.api.GraphStore;
 import org.neo4j.gds.config.AlgoBaseConfig;
 
+import java.util.Collection;
 import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.neo4j.gds.utils.StringFormatting.formatWithLocale;
 
 @Configuration
 public interface CliqueCountingBaseConfig extends AlgoBaseConfig {
@@ -45,5 +53,21 @@ default CliqueCountingParameters toParameters() {
         );
     }
 
+    @Configuration.GraphStoreValidationCheck
+    default void validateTargetRelIsUndirected(
+        GraphStore graphStore,
+        Collection<NodeLabel> ignored,
+        Collection<RelationshipType> selectedRelationshipTypes
+    ) {
+        if (!graphStore.schema().filterRelationshipTypes(Set.copyOf(selectedRelationshipTypes)).isUndirected()) {
+            throw new IllegalArgumentException(formatWithLocale(
+                "Clique counting requires relationship projections to be UNDIRECTED. " +
+                    "Selected relationships `%s` are not all undirected.",
+                selectedRelationshipTypes.stream().map(RelationshipType::name).collect(Collectors.toSet())
+            ));
+        }
+    }
+
+
 
 }

procedures/facade-api/configs/community-configs/src/test/java/org/neo4j/gds/cliquecounting/CliqueCountingBaseConfigTest.java

@@ -0,0 +1,67 @@
+/*
+ * Copyright (c) "Neo4j"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Neo4j is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.neo4j.gds.cliquecounting;
+
+import org.junit.jupiter.api.Test;
+import org.neo4j.gds.NodeLabel;
+import org.neo4j.gds.RelationshipType;
+import org.neo4j.gds.api.GraphStore;
+import org.neo4j.gds.extension.GdlExtension;
+import org.neo4j.gds.extension.GdlGraph;
+import org.neo4j.gds.extension.Inject;
+import org.neo4j.gds.kcore.KCoreDecompositionBaseConfig;
+
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyList;
+import static org.mockito.Mockito.doCallRealMethod;
+import static org.mockito.Mockito.spy;
+
+@GdlExtension
+class CliqueCountingBaseConfigTest {
+
+    @GdlGraph
+    private static final String DB_CYPHER =
+        "CREATE " +
+            "  (a:node)," +
+            "  (b:node)," +
+            "(a)-[:R]->(b)";
+
+
+    @Inject
+    private GraphStore graphStore;
+
+    @Test
+    void shouldThrowForDirected() {
+        var mockConfig = spy(KCoreDecompositionBaseConfig.class);
+
+        doCallRealMethod().when(mockConfig).validateTargetRelIsUndirected(any(), anyList(), anyList());
+
+        assertThatThrownBy(() -> mockConfig.validateTargetRelIsUndirected(
+            graphStore,
+            List.of(NodeLabel.ALL_NODES),
+            List.of(RelationshipType.of("R"))
+        ))
+            .hasMessageContaining("Selected relationships `[R]` are not all undirected");
+    }
+}
+