Make some fields final

Author: jjaderberg

algo/src/main/java/org/neo4j/gds/steiner/ShortestPathsSteinerAlgorithm.java

@@ -39,8 +39,8 @@
 
 public class ShortestPathsSteinerAlgorithm extends Algorithm<SteinerTreeResult> {
 
-    public static long ROOTNODE = -1;
-    public static long PRUNED = -2;
+    public static final long ROOT_NODE = -1;
+    public static final long PRUNED = -2;
     private final Graph graph;
     private final long sourceId;
     private final List<Long> terminals;
@@ -49,7 +49,7 @@ public class ShortestPathsSteinerAlgorithm extends Algorithm<SteinerTreeResult>
     private final boolean applyRerouting;
     private final double delta;
     private final ExecutorService executorService;
-    private int binSizeThreshold;
+    private final int binSizeThreshold;
 
     public ShortestPathsSteinerAlgorithm(
         Graph graph,
@@ -156,7 +156,7 @@ public void release() {
     }
 
     private void initForSource(HugeLongArray parent, HugeDoubleArray parentCost) {
-        parent.set(sourceId, ROOTNODE);
+        parent.set(sourceId, ROOT_NODE);
         parentCost.set(sourceId, 0);
     }
 
@@ -249,7 +249,7 @@ private LinkCutTree createLinkCutTree(HugeLongArray parent) {
         var tree = new LinkCutTree(graph.nodeCount());
         for (long nodeId = 0; nodeId < graph.nodeCount(); ++nodeId) {
             var parentId = parent.get(nodeId);
-            if (parentId != PRUNED && parentId != ROOTNODE) {
+            if (parentId != PRUNED && parentId != ROOT_NODE) {
                 tree.link(parentId, nodeId);
             }
         }
@@ -279,7 +279,7 @@ private void cutNodesAfterRerouting(
         }
 
         ParallelUtil.parallelForEachNode(graph.nodeCount(), concurrency, nodeId -> {
-            if (parent.get(nodeId) != PRUNED && parent.get(nodeId) != ROOTNODE) {
+            if (parent.get(nodeId) != PRUNED && parent.get(nodeId) != ROOT_NODE) {
                 if (!endsAtTerminal.get(nodeId)) {
                     parent.set(nodeId, PRUNED);
                     totalCost.add(-parentCost.get(nodeId));
@@ -311,7 +311,7 @@ private void reroute(
                     var parentId = parent.get(t);
                     double targetParentCost = parentCost.get(t);
                     //we want to see if replacing t's parent with nodeId makes sense (i.e., smaller cost)
-                    if (parentId != PRUNED && parentId != ROOTNODE && w < targetParentCost) {
+                    if (parentId != PRUNED && parentId != ROOT_NODE && w < targetParentCost) {
                         boolean shouldReconnect = checkIfRerouteIsValid(tree, s, t, parentId);
                         if (shouldReconnect) { //yes we can replace t's parent with s
                             didReroutes.setTrue();

algo/src/test/java/org/neo4j/gds/steiner/ShortestPathSteinerAlgorithmExtendedTest.java

@@ -170,7 +170,7 @@ void shouldWorkCorrectly(double delta, int binSizeThreshold) {
             ProgressTracker.NULL_TRACKER
         ).compute();
 
-        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOTNODE, a[0], a[1], a[2], a[3], a[4]};
+        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOT_NODE, a[0], a[1], a[2], a[3], a[4]};
         double[] parentCostArray = new double[]{0, 1.0, 1.0, 1.0, 1.0, 4.1};
         SteinerTestUtils.assertTreeIsCorrect(idFunction, steinerTreeResult, parentArray, parentCostArray, 8.1);
     }
@@ -191,7 +191,7 @@ void shouldWorkCorrectlyWithLineGraph() {
         )
             .compute();
 
-        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOTNODE, a[0], a[1], a[2], a[3]};
+        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOT_NODE, a[0], a[1], a[2], a[3]};
 
         double[] parentCostArray = new double[]{0, 1, 1, 1, 1};
 
@@ -243,7 +243,7 @@ void shouldWorkIfRevisitsVertices() {
         ).compute();
 
         long[] parentArray = new long[]{
-            ShortestPathsSteinerAlgorithm.ROOTNODE,
+            ShortestPathsSteinerAlgorithm.ROOT_NODE,
             a[0],
             a[1],
             a[6],
@@ -271,7 +271,7 @@ void shouldWorkOnTriangle() {
             ProgressTracker.NULL_TRACKER
         ).compute();
 
-        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOTNODE, a[0], a[1], a[2]};
+        long[] parentArray = new long[]{ShortestPathsSteinerAlgorithm.ROOT_NODE, a[0], a[1], a[2]};
         double[] parentCostArray = new double[]{0, 15, 3, 6};
 
         SteinerTestUtils.assertTreeIsCorrect(triangleIdFunction, steinerTreeResult, parentArray, parentCostArray, 24);

algo/src/test/java/org/neo4j/gds/steiner/ShortestPathsSteinerAlgorithmReroutingTest.java

@@ -134,7 +134,7 @@ void rerouteShouldNotCreateLoops() {
         ).compute();
         var parent = steinerResult.parentArray().toArray();
 
-        assertThat(parent[(int) idFunction.of("a0")]).isEqualTo(ShortestPathsSteinerAlgorithm.ROOTNODE);
+        assertThat(parent[(int) idFunction.of("a0")]).isEqualTo(ShortestPathsSteinerAlgorithm.ROOT_NODE);
         assertThat(parent[(int) idFunction.of("a1")]).isEqualTo(idFunction.of("a0"));
         assertThat(parent[(int) idFunction.of("a2")]).isEqualTo(idFunction.of("a1"));
         assertThat(parent[(int) idFunction.of("a3")]).isEqualTo(idFunction.of("a2"));

algo/src/test/java/org/neo4j/gds/steiner/ShortestPathsSteinerAlgorithmTest.java

@@ -83,7 +83,7 @@ void shouldWorkCorrectly() {
             ProgressTracker.NULL_TRACKER
         ).compute();
         var pruned = ShortestPathsSteinerAlgorithm.PRUNED;
-        var rootnode = ShortestPathsSteinerAlgorithm.ROOTNODE;
+        var rootnode = ShortestPathsSteinerAlgorithm.ROOT_NODE;
         long[] parentArray = new long[]{
             rootnode,
             pruned,