Add overload to NodePropertyValues::dimension to specify nodeId

Author: breakanalysis

algo/src/main/java/org/neo4j/gds/similarity/knn/metrics/NullCheckingNodePropertyValues.java

@@ -80,8 +80,8 @@ public ValueType valueType() {
     }
 
     @Override
-    public Optional<Integer> dimension() {
-        return properties.dimension();
+    public Optional<Integer> dimension(long nodeId) {
+        return properties.dimension(nodeId);
     }
 
     @Override

core-api/src/main/java/org/neo4j/gds/api/properties/nodes/NodePropertyValues.java

@@ -67,7 +67,19 @@ default long[] longArrayValue(long nodeId) {
      *
      * @return the dimension of the properties stored, or empty if the dimension cannot easily be retrieved.
      */
-    Optional<Integer> dimension();
+    default Optional<Integer> dimension() {
+        return dimension(0L);
+    }
+
+    /**
+     * The dimension of the properties.
+     * For scalar values, this is 1.
+     * For arrays, this is the length of the array stored for the given node id.
+     * If that array is {@code null}, this method returns {@link Optional#empty()}.
+     *
+     * @return the dimension of the properties stored, or empty if the dimension cannot easily be retrieved.
+     */
+    Optional<Integer> dimension(long nodeId);
 
     /**
      * @return the maximum long value contained in the mapping or an empty {@link OptionalLong} if the mapping is

core/src/main/java/org/neo4j/gds/api/properties/nodes/BinaryArrayNodePropertyValues.java

@@ -59,7 +59,7 @@ public Object getObject(long nodeId) {
     }
 
     @Override
-    public Optional<Integer> dimension() {
+    public Optional<Integer> dimension(long nodeId) {
         return Optional.of(embeddingDimension);
     }
 

core/src/main/java/org/neo4j/gds/api/properties/nodes/DoubleArrayNodePropertyValues.java

@@ -54,8 +54,8 @@ default ValueType valueType() {
     }
 
     @Override
-    default Optional<Integer> dimension() {
-        var value = doubleArrayValue(0);
+    default Optional<Integer> dimension(long nodeId) {
+        var value = doubleArrayValue(nodeId);
         if (value == null) {
             return Optional.empty();
         }

core/src/main/java/org/neo4j/gds/api/properties/nodes/DoubleNodePropertyValues.java

@@ -41,7 +41,7 @@ default ValueType valueType() {
     }
 
     @Override
-    default Optional<Integer> dimension() {
+    default Optional<Integer> dimension(long nodeId) {
         return Optional.of(1);
     }
 

core/src/main/java/org/neo4j/gds/api/properties/nodes/FloatArrayNodePropertyValues.java

@@ -55,8 +55,8 @@ default ValueType valueType() {
     }
 
     @Override
-    default Optional<Integer> dimension() {
-        var value = floatArrayValue(0);
+    default Optional<Integer> dimension(long nodeId) {
+        var value = floatArrayValue(nodeId);
         if (value == null) {
             return Optional.empty();
         }

core/src/main/java/org/neo4j/gds/api/properties/nodes/LongArrayNodePropertyValues.java

@@ -39,8 +39,8 @@ default ValueType valueType() {
     }
 
     @Override
-    default Optional<Integer> dimension() {
-        var value = longArrayValue(0);
+    default Optional<Integer> dimension(long nodeId) {
+        var value = longArrayValue(nodeId);
         if (value == null) {
             return Optional.empty();
         }

core/src/main/java/org/neo4j/gds/api/properties/nodes/LongNodePropertyValues.java

@@ -43,7 +43,7 @@ default ValueType valueType() {
     }
 
     @Override
-    default Optional<Integer> dimension() {
+    default Optional<Integer> dimension(long nodeId) {
         return Optional.of(1);
     }
 

core/src/main/java/org/neo4j/gds/core/huge/FilteredNodePropertyValues.java

@@ -77,8 +77,8 @@ public ValueType valueType() {
     }
 
     @Override
-    public Optional<Integer> dimension() {
-        return properties.dimension();
+    public Optional<Integer> dimension(long nodeId) {
+        return properties.dimension(translateId(nodeId));
     }
 
     @Override

core/src/main/java/org/neo4j/gds/core/loading/NullPropertyMap.java

@@ -34,7 +34,7 @@
 public abstract class NullPropertyMap implements NodePropertyValues {
 
     @Override
-    public Optional<Integer> dimension() {
+    public Optional<Integer> dimension(long nodeId) {
         return Optional.of(1);
     }