migrate estimation cli degree centrality to application layer

Author: lassewesth

algo/src/main/java/org/neo4j/gds/degree/DegreeCentralityFactory.java

@@ -19,8 +19,14 @@
  */
 package org.neo4j.gds.degree;
 
-final class Constants {
-    static final String DEGREE_CENTRALITY_DESCRIPTION = "Degree centrality measures the number of incoming and outgoing relationships from a node.";
+import org.neo4j.gds.api.IdMap;
+import org.neo4j.gds.core.utils.progress.tasks.Task;
+import org.neo4j.gds.core.utils.progress.tasks.Tasks;
 
-    private Constants() {}
+public final class DegreeCentralityTask {
+    private DegreeCentralityTask() {}
+
+    public static Task create(IdMap idMap) {
+        return Tasks.leaf("DegreeCentrality", idMap.nodeCount());
+    }
 }

…java/org/neo4j/gds/degree/Constants.java …o4j/gds/degree/DegreeCentralityTask.javaalgorithm-specifications/src/main/java/org/neo4j/gds/degree/Constants.java renamed to algo/src/main/java/org/neo4j/gds/degree/DegreeCentralityTask.java algorithm-specifications/src/main/java/org/neo4j/gds/degree/Constants.java renamed to algo/src/main/java/org/neo4j/gds/degree/DegreeCentralityTask.java

@@ -22,11 +22,11 @@
 import org.neo4j.gds.GraphAlgorithmFactory;
 import org.neo4j.gds.api.Graph;
 import org.neo4j.gds.core.concurrency.DefaultPool;
+import org.neo4j.gds.degree.DegreeCentralityTask;
 import org.neo4j.gds.mem.MemoryEstimation;
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
 import org.neo4j.gds.core.utils.progress.tasks.Task;
 import org.neo4j.gds.core.utils.progress.tasks.Tasks;
-import org.neo4j.gds.degree.DegreeCentralityFactory;
 import org.neo4j.gds.termination.TerminationFlag;
 
 import java.util.ArrayList;
@@ -62,7 +62,7 @@ public Task progressTask(
     ) {
         var tasks = new ArrayList<Task>();
         if (graph.hasRelationshipProperty()) {
-            tasks.add(DegreeCentralityFactory.degreeCentralityProgressTask(graph));
+            tasks.add(DegreeCentralityTask.create(graph));
         }
         tasks.add(Tasks.leaf("create walks", graph.nodeCount()));
 

algo/src/main/java/org/neo4j/gds/traversal/RandomWalkAlgorithmFactory.java

@@ -156,7 +156,7 @@ void testProgressLogging(boolean weighted) {
         var concurrency = new Concurrency(4);
         var orientation = Orientation.NATURAL;
 
-        var progressTask = DegreeCentralityFactory.degreeCentralityProgressTask(graph);
+        var progressTask = DegreeCentralityTask.create(graph);
         var log = new GdsTestLog();
         var progressTracker = new TestProgressTracker(progressTask, log, new Concurrency(1), EmptyTaskRegistryFactory.INSTANCE);
         var degreeCentrality = new DegreeCentrality(

algo/src/test/java/org/neo4j/gds/degree/DegreeCentralityTest.java

@@ -29,7 +29,7 @@
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
 import org.neo4j.gds.core.utils.progress.tasks.Task;
 import org.neo4j.gds.core.utils.progress.tasks.Tasks;
-import org.neo4j.gds.degree.DegreeCentralityFactory;
+import org.neo4j.gds.degree.DegreeCentralityTask;
 import org.neo4j.gds.embeddings.fastrp.FastRP;
 import org.neo4j.gds.embeddings.fastrp.FastRPBaseConfig;
 import org.neo4j.gds.embeddings.fastrp.FastRPConfigTransformer;
@@ -284,7 +284,7 @@ private static Task createHashGnnTask(Graph graph, HashGNNConfig configuration)
     private Task createNode2VecTask(Graph graph, Node2VecBaseConfig configuration) {
         var randomWalkTasks = new ArrayList<Task>();
         if (graph.hasRelationshipProperty()) {
-            randomWalkTasks.add(DegreeCentralityFactory.degreeCentralityProgressTask(graph));
+            randomWalkTasks.add(DegreeCentralityTask.create(graph));
         }
         randomWalkTasks.add(Tasks.leaf("create walks", graph.nodeCount()));
 

algorithm-specifications/src/main/java/org/neo4j/gds/degree/DegreeCentralityMutateSpecification.java

@@ -42,7 +42,7 @@
 import org.neo4j.gds.dag.topologicalsort.TopologicalSort;
 import org.neo4j.gds.dag.topologicalsort.TopologicalSortBaseConfig;
 import org.neo4j.gds.dag.topologicalsort.TopologicalSortResult;
-import org.neo4j.gds.degree.DegreeCentralityFactory;
+import org.neo4j.gds.degree.DegreeCentralityTask;
 import org.neo4j.gds.kspanningtree.KSpanningTree;
 import org.neo4j.gds.kspanningtree.KSpanningTreeBaseConfig;
 import org.neo4j.gds.paths.astar.AStar;
@@ -249,7 +249,7 @@ PathFindingResult longestPath(Graph graph, AlgoBaseConfig configuration) {
     Stream<long[]> randomWalk(Graph graph, RandomWalkBaseConfig configuration) {
         var tasks = new ArrayList<Task>();
         if (graph.hasRelationshipProperty()) {
-            tasks.add(DegreeCentralityFactory.degreeCentralityProgressTask(graph));
+            tasks.add(DegreeCentralityTask.create(graph));
         }
         tasks.add(Tasks.leaf("create walks", graph.nodeCount()));
         var task = Tasks.task(AlgorithmLabel.RandomWalk.asString(), tasks);
@@ -297,7 +297,7 @@ PrizeSteinerTreeResult pcst(Graph graph, PCSTBaseConfig configuration) {
     HugeAtomicLongArray randomWalkCountingNodeVisits(Graph graph, RandomWalkBaseConfig configuration) {
         var tasks = new ArrayList<Task>();
         if (graph.hasRelationshipProperty()) {
-            tasks.add(DegreeCentralityFactory.degreeCentralityProgressTask(graph));
+            tasks.add(DegreeCentralityTask.create(graph));
         }
         Task task;
         if (tasks.isEmpty()) {