Skip to content

Commit 46f8794

Browse files
committed
Add manual parts of 5.6 compat
1 parent cf09ef5 commit 46f8794

File tree

3 files changed

+22
-2
lines changed

3 files changed

+22
-2
lines changed

neo4j-adapter/src/main/java/org/neo4j/gds/compat/Neo4jVersion.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public enum Neo4jVersion {
3333
V_5_3,
3434
V_5_4,
3535
V_5_5,
36+
V_5_6,
3637
V_RC;
3738

3839
@Override
@@ -50,6 +51,8 @@ public String toString() {
5051
return "5.4";
5152
case V_5_5:
5253
return "5.5";
54+
case V_5_6:
55+
return "5.6";
5356
case V_RC:
5457
return "rc";
5558
default:
@@ -59,7 +62,7 @@ public String toString() {
5962

6063
public MajorMinorVersion semanticVersion() {
6164
if (this == V_RC) {
62-
return ImmutableMajorMinorVersion.of(5, 6);
65+
return ImmutableMajorMinorVersion.of(5, 7);
6366
}
6467
String version = toString();
6568
var subVersions = version.split("\\.");
@@ -132,6 +135,8 @@ static Neo4jVersion parse(String version) {
132135
} else if (minorVersion == 5) {
133136
return Neo4jVersion.V_5_5;
134137
} else if (minorVersion == 6) {
138+
return Neo4jVersion.V_5_6;
139+
} else if (minorVersion == 7) {
135140
return Neo4jVersion.V_RC;
136141
}
137142
}

neo4j-adapter/src/test/java/org/neo4j/gds/compat/Neo4jVersionTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ class Neo4jVersionTest {
4646
"5.3.0, V_5_3",
4747
"5.4.0, V_5_4",
4848
"5.5.0, V_5_5",
49-
"5.6.0, V_RC",
49+
"5.6.0, V_5_6",
50+
"5.7.0, V_RC",
5051
})
5152
void testParse(String input, Neo4jVersion expected) {
5253
assertEquals(expected.name(), Neo4jVersion.parse(input).name());
@@ -84,6 +85,7 @@ void shouldNotRespectVersionOverride() {
8485
"5.3.0, 5, 3",
8586
"5.4.0, 5, 4",
8687
"5.5.0, 5, 5",
88+
"5.6.0, 5, 6",
8789
})
8890
void semanticVersion(String input, int expectedMajor, int expectedMinor) {
8991
Neo4jVersion version = Neo4jVersion.parse(input);

proc/sysinfo/src/test/java/org/neo4j/gds/SysInfoProcTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ class SysInfoProcTest extends BaseProcTest {
7676
"Neo4j Settings 5.5",
7777
"Neo4j Settings 5.5 (placeholder)",
7878

79+
"Neo4j 5.6",
80+
"Neo4j 5.6 (placeholder)",
81+
"Neo4j Settings 5.6",
82+
"Neo4j Settings 5.6 (placeholder)",
83+
7984
"Neo4j RC",
8085
"Neo4j RC (placeholder)",
8186
"Neo4j Settings RC",
@@ -171,6 +176,14 @@ void testSysInfoProc() throws IOException {
171176
"Neo4j 5.5"
172177
);
173178
break;
179+
case V_5_6:
180+
expectedCompatibilities = Set.of(
181+
"Neo4j Settings 5.6 (placeholder)",
182+
"Neo4j Settings 5.6",
183+
"Neo4j 5.6 (placeholder)",
184+
"Neo4j 5.6"
185+
);
186+
break;
174187
case V_RC:
175188
expectedCompatibilities = Set.of(
176189
"Neo4j Settings RC (placeholder)",

0 commit comments

Comments
 (0)