Skip to content

Commit 4c4dbf8

Browse files
committed
Use Nodes directly in FileToGraphStoreImporter
1 parent cebc115 commit 4c4dbf8

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

io/core/src/main/java/org/neo4j/gds/core/io/file/FileToGraphStoreImporter.java

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,9 @@
3232
import org.neo4j.gds.core.concurrency.Pools;
3333
import org.neo4j.gds.core.io.GraphStoreGraphPropertyVisitor;
3434
import org.neo4j.gds.core.io.GraphStoreRelationshipVisitor;
35-
import org.neo4j.gds.core.loading.CSRGraphStoreUtil;
3635
import org.neo4j.gds.core.loading.GraphStoreBuilder;
37-
import org.neo4j.gds.core.loading.ImmutableNodes;
3836
import org.neo4j.gds.core.loading.ImmutableStaticCapabilities;
37+
import org.neo4j.gds.core.loading.Nodes;
3938
import org.neo4j.gds.core.loading.RelationshipImportResult;
4039
import org.neo4j.gds.core.loading.construction.GraphFactory;
4140
import org.neo4j.gds.core.loading.construction.NodesBuilder;
@@ -138,11 +137,11 @@ private void importGraphStore(FileInput fileInput) {
138137
graphStoreBuilder.capabilities(fileInput.capabilities());
139138

140139
var nodes = importNodes(fileInput);
141-
importRelationships(fileInput, nodes);
140+
importRelationships(fileInput, nodes.idMap());
142141
importGraphProperties(fileInput);
143142
}
144143

145-
private IdMap importNodes(FileInput fileInput) {
144+
private Nodes importNodes(FileInput fileInput) {
146145
progressTracker.beginSubTask();
147146
NodeSchema nodeSchema = fileInput.nodeSchema();
148147
graphSchemaBuilder.nodeSchema(nodeSchema);
@@ -165,19 +164,12 @@ private IdMap importNodes(FileInput fileInput) {
165164
ParallelUtil.run(tasks, Pools.DEFAULT);
166165

167166
var nodes = nodesBuilder.build();
168-
var nodeImportResultBuilder = ImmutableNodes.builder().idMap(nodes.idMap());
169167

170-
var schemaProperties = nodeSchema.unionProperties();
171-
CSRGraphStoreUtil.extractNodeProperties(
172-
nodeImportResultBuilder,
173-
schemaProperties::get,
174-
nodes.properties().propertyValues()
175-
);
168+
this.graphStoreBuilder.nodes(nodes);
176169

177-
graphStoreBuilder.nodes(nodeImportResultBuilder.build());
170+
this.progressTracker.endSubTask();
178171

179-
progressTracker.endSubTask();
180-
return nodes.idMap();
172+
return nodes;
181173
}
182174

183175
private void importRelationships(FileInput fileInput, IdMap nodes) {

0 commit comments

Comments
 (0)