Skip to content

Commit 4fba851

Browse files
authored
Merge pull request #10293 from vnickolov/remote-centrality-stats
remote centrality stats
2 parents dfef181 + 179d8f9 commit 4fba851

File tree

2 files changed

+16
-55
lines changed

2 files changed

+16
-55
lines changed

procedures/facade-api/centrality-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/centrality/CELFStatsResult.java

Lines changed: 6 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -20,42 +20,17 @@
2020
package org.neo4j.gds.procedures.algorithms.centrality;
2121

2222
import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
23-
import org.neo4j.gds.result.AbstractResultBuilder;
2423

2524
import java.util.Map;
2625

27-
public final class CELFStatsResult {
28-
public final long computeMillis;
29-
public final double totalSpread;
30-
public final long nodeCount;
31-
public final Map<String, Object> configuration;
32-
33-
34-
public CELFStatsResult(long computeMillis, double totalSpread, long nodeCount, Map<String, Object> configuration) {
35-
this.computeMillis = computeMillis;
36-
this.totalSpread = totalSpread;
37-
this.nodeCount = nodeCount;
38-
this.configuration = configuration;
39-
}
40-
41-
public static Builder builder() {
42-
return new Builder();
43-
}
26+
public record CELFStatsResult(
27+
long computeMillis,
28+
double totalSpread,
29+
long nodeCount,
30+
Map<String, Object> configuration
31+
) {
4432

4533
static CELFStatsResult emptyFrom(AlgorithmProcessingTimings timings, Map<String, Object> configurationMap) {
4634
return new CELFStatsResult(timings.computeMillis, 0, 0, configurationMap);
4735
}
48-
49-
public static class Builder extends AbstractResultBuilder<CELFStatsResult> {
50-
private double totalSpread;
51-
52-
public Builder withTotalSpread(double totalSpread) {
53-
this.totalSpread = totalSpread;
54-
return this;
55-
}
56-
57-
public CELFStatsResult build() {
58-
return new CELFStatsResult(computeMillis, totalSpread, nodeCount, config.toMap());
59-
}
60-
}
6136
}

procedures/facade-api/centrality-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/centrality/PageRankStatsResult.java

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,21 @@
1919
*/
2020
package org.neo4j.gds.procedures.algorithms.centrality;
2121

22-
import org.neo4j.gds.api.ProcedureReturnColumns;
2322
import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
24-
import org.neo4j.gds.core.concurrency.Concurrency;
23+
import org.neo4j.gds.procedures.algorithms.results.StatsResult;
2524

2625
import java.util.Collections;
2726
import java.util.Map;
2827

29-
public record PageRankStatsResult(long ranIterations, boolean didConverge, Map<String, Object> centralityDistribution,
30-
long preProcessingMillis, long computeMillis, long postProcessingMillis,
31-
Map<String, Object> configuration) {
28+
public record PageRankStatsResult(
29+
long ranIterations,
30+
boolean didConverge,
31+
Map<String, Object> centralityDistribution,
32+
long preProcessingMillis,
33+
long computeMillis,
34+
long postProcessingMillis,
35+
Map<String, Object> configuration
36+
) implements StatsResult {
3237

3338
static PageRankStatsResult emptyFrom(AlgorithmProcessingTimings timings, Map<String, Object> configurationMap) {
3439
return new PageRankStatsResult(
@@ -41,23 +46,4 @@ static PageRankStatsResult emptyFrom(AlgorithmProcessingTimings timings, Map<Str
4146
configurationMap
4247
);
4348
}
44-
45-
public static class Builder extends PageRankProcCompanion.PageRankResultBuilder<PageRankStatsResult> {
46-
public Builder(ProcedureReturnColumns returnColumns, Concurrency concurrency) {
47-
super(returnColumns, concurrency);
48-
}
49-
50-
@Override
51-
public PageRankStatsResult buildResult() {
52-
return new PageRankStatsResult(
53-
ranIterations,
54-
didConverge,
55-
centralityHistogram,
56-
preProcessingMillis,
57-
computeMillis,
58-
postProcessingMillis,
59-
config.toMap()
60-
);
61-
}
62-
}
6349
}

0 commit comments

Comments
 (0)