Remove Neo4j version support

When releasing GDS 2.3+ Neo4j 4.3 will be EOL.

Author: FlorentinD

README.adoc

@@ -77,12 +77,11 @@ If you are using Neo4j Desktop you can simply add the Graph Data Science library
 
 .4+<.^|GDS 2.2.x
 |Neo4j 4.3.15 - 4.3.22
-.8+.^|Java 11 & Java 17
+.7+.^|Java 11 & Java 17
 |Neo4j 4.4.9 - 4.4.15
 |Neo4j 5.1.0
 |Neo4j 5.2.0
-.4+<.^|GDS 2.3.x
-|Neo4j 4.3.15 - 4.3.22
+.3+<.^|GDS 2.3.x
 |Neo4j 4.4.9 - 4.4.15
 |Neo4j 5.1.0
 |Neo4j 5.2.0

compatibility/4.4/neo4j-kernel-adapter/src/main/java/org/neo4j/gds/compat/_44/SettingProxyFactoryImpl.java

@@ -29,8 +29,7 @@ public class SettingProxyFactoryImpl implements SettingProxyFactory {
 
     @Override
     public boolean canLoad(Neo4jVersion version) {
-        return version == Neo4jVersion.V_4_3 ||
-               version == Neo4jVersion.V_4_4;
+        return version == Neo4jVersion.V_4_4;
     }
 
     @Override
@@ -40,6 +39,6 @@ public SettingProxyApi load() {
 
     @Override
     public String description() {
-        return "Neo4j Settings 4.x";
+        return "Neo4j Settings 4.4";
     }
 }

cypher/cypher-test/src/test/java/org/neo4j/gds/storageengine/InMemoryNodeCursorTest.java

@@ -104,15 +104,13 @@ void testLabels() {
     }
 
     @Test
-    @EnableForNeo4jVersion(Neo4jVersion.V_4_3)
     void shouldHaveProperties43() {
         nodeCursor.next();
         assertThat(nodeCursor.hasProperties()).isTrue();
         assertThat(nodeCursor.propertiesReference()).isEqualTo(0L);
     }
 
     @Test
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     void shouldHaveProperties() {
         nodeCursor.next();
         assertThat(nodeCursor.hasProperties()).isTrue();

cypher/cypher-test/src/test/java/org/neo4j/gds/storageengine/InMemoryRelationshipTraversalCursorTest.java

@@ -128,7 +128,6 @@ void shouldSetCorrectIdsAndTypes() {
 
     @ParameterizedTest
     @MethodSource("propertyFilterAndExpectedValues")
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     void shouldGetPropertyValues(Map<String, Double> expectedValues) {
         var relTypeToken = tokenHolders.relationshipTypeTokens().getIdByName("REL");
 

doc/modules/ROOT/pages/installation/supported-neo4j-versions.adoc

@@ -13,11 +13,10 @@ Time to upgrade!
 [opts=header]
 |===
 | Neo4j Graph Data Science | Neo4j version
-.4+<.^|`2.3`
+.3+<.^|`2.3`
 | `5.1`
 | `5.2`
 | `4.4`, at least `4.4.9`
-| `4.3`, at least `4.3.15`
 .4+<.^|`2.2`
 | `5.1`
 | `5.2`

gradle/dependencies.gradle

@@ -1,6 +1,5 @@
 ext {
     neos = [
-        '4.3'           : properties.getOrDefault('neo4jVersion43', '4.3.22'),
         '4.4'           : properties.getOrDefault('neo4jVersion44', '4.4.15'),
         '5.1'           : properties.getOrDefault('neo4jVersion51', '5.1.0'),
         '5.2'           : properties.getOrDefault('neo4jVersion52', '5.2.0'),

neo4j-adapter/src/main/java/org/neo4j/gds/compat/Neo4jVersion.java

@@ -27,7 +27,6 @@
 import java.util.stream.IntStream;
 
 public enum Neo4jVersion {
-    V_4_3,
     V_4_4,
     V_5_1,
     V_5_2,
@@ -37,8 +36,6 @@ public enum Neo4jVersion {
     @Override
     public String toString() {
         switch (this) {
-            case V_4_3:
-                return "4.3";
             case V_4_4:
                 return "4.4";
             case V_5_1:
@@ -116,12 +113,8 @@ static Neo4jVersion parse(String version) {
         var majorVersion = majorMinorVersion[0];
         var minorVersion = majorMinorVersion[1];
 
-        if (majorVersion == 4) {
-            if (minorVersion == 3) {
-                return Neo4jVersion.V_4_3;
-            } else if (minorVersion == 4) {
-                return Neo4jVersion.V_4_4;
-            }
+        if (majorVersion == 4 && minorVersion == 4) {
+            return Neo4jVersion.V_4_4;
         } else if (majorVersion == 5) {
             if (minorVersion == 1) {
                 return Neo4jVersion.V_5_1;

neo4j-adapter/src/test/java/org/neo4j/gds/compat/Neo4jVersionTest.java

@@ -35,8 +35,7 @@ class Neo4jVersionTest {
 
     @ParameterizedTest
     @CsvSource({
-        "4.3.0-drop04, V_4_3",
-        "4.3.0, V_4_3",
+        "4.4.0-drop04, V_4_4",
         "4.4.0, V_4_4",
         "4.4.14, V_4_4",
         "5.1.0, V_5_1",
@@ -54,6 +53,7 @@ void testParse(String input, Neo4jVersion expected) {
     @ParameterizedTest
     @CsvSource({
         "dev",
+        "4.3", // EOL
         "5.dev",
         "dev.5",
         "5.0", // 5.0 was never released to the public
@@ -75,8 +75,7 @@ void shouldNotRespectVersionOverride() {
 
     @ParameterizedTest
     @CsvSource({
-        "4.3.0-drop04, 4, 3",
-        "4.3.0, 4, 3",
+        "4.4.0-drop04, 4, 4",
         "4.4.14, 4, 4",
         "5.1.0, 5, 1",
         "5.2.0, 5, 2",

proc/catalog/src/test/java/org/neo4j/gds/catalog/GraphStoreExportProcTest.java

@@ -91,7 +91,6 @@ void teardown() {
         GraphStoreCatalog.removeAllLoadedGraphs();
     }
 
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     @Test
     void exportGraph() {
         projectGraph();
@@ -109,7 +108,6 @@ void exportGraph() {
         });
     }
 
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     @Test
     void exportGraphWithAdditionalNodeProperties() {
         projectGraph();
@@ -135,7 +133,6 @@ void exportGraphWithAdditionalNodeProperties() {
         });
     }
 
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     @Test
     void exportGraphWithAdditionalNodePropertiesShortHandSyntax() {
         projectGraph();
@@ -161,7 +158,6 @@ void exportGraphWithAdditionalNodePropertiesShortHandSyntax() {
         });
     }
 
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     @Test
     void exportGraphWithAdditionalNodePropertiesDuplicateProperties() {
         projectGraph();
@@ -294,7 +290,6 @@ void failIfExportLocationIsNotSet() {
     }
 
 
-    @DisableForNeo4jVersion(Neo4jVersion.V_4_3)
     @Test
     void exportCsvWithAdditionalNodePropertiesDuplicateProperties() {
         projectGraph();

proc/sysinfo/src/test/java/org/neo4j/gds/SysInfoProcTest.java

@@ -119,9 +119,6 @@ void testSysInfoProc() throws IOException {
 
         Set<String> expectedCompatibilities;
         switch (neo4jVersion) {
-            case V_4_3:
-                expectedCompatibilities = Set.of("Neo4j 4.3", "Neo4j Settings 4.x");
-                break;
             case V_4_4:
                 expectedCompatibilities = Set.of("Neo4j 4.4", "Neo4j Settings 4.x");
                 break;