Add deprecated procedures service to GDS Facade

Co-authored-by: Ioannis Panagiotas <ioannis.panagiotas@neotechnology.com>

Author: vnickolov

proc/community/src/test/java/org/neo4j/gds/k1coloring/K1ColoringStreamProcTest.java

@@ -222,7 +222,8 @@ void shouldRegisterTaskWithCorrectJobId() {
                     null,
                     algorithmsStreamBusinessFacade,
                     null
-                )
+                ),
+                null
             );
             var someJobId = new JobId();
             Map<String, Object> configMap = Map.of("jobId", someJobId);

proc/community/src/test/java/org/neo4j/gds/labelpropagation/LabelPropagationMutateProcTest.java

@@ -326,7 +326,8 @@ void testWriteBackGraphMutationOnFilteredGraph() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
 
             ProcedureMethodHelper.mutateMethods(procedure)
@@ -456,7 +457,8 @@ void testMutateFailsOnExistingToken() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
 
             ProcedureMethodHelper.mutateMethods(procedure)
@@ -515,7 +517,8 @@ void testRunOnEmptyGraph() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
 
             var methods = ProcedureMethodHelper.mutateMethods(procedure).collect(Collectors.toList());
@@ -577,7 +580,8 @@ private GraphStore runMutation(String graphName, Map<String, Object> config) {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
             ProcedureMethodHelper.mutateMethods(procedure)
                 .forEach(mutateMethod -> {

proc/community/src/test/java/org/neo4j/gds/modularityoptimization/ModularityOptimizationMutateProcTest.java

@@ -595,7 +595,8 @@ private GraphDataScience createFacade() {
                 mock(CommunityAlgorithmsStatsBusinessFacade.class),
                 mock(CommunityAlgorithmsStreamBusinessFacade.class),
                 mock(CommunityAlgorithmsWriteBusinessFacade.class)
-            )
+            ),
+            null
         );
     }
 }

proc/community/src/test/java/org/neo4j/gds/wcc/WccMutateProcTest.java

@@ -356,7 +356,8 @@ void testWriteBackGraphMutationOnFilteredGraph() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
 
             ProcedureMethodHelper.mutateMethods(procedure)
@@ -491,7 +492,8 @@ void testMutateFailsOnExistingToken() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
                 ProcedureMethodHelper.mutateMethods(procedure)
                     .forEach(mutateMethod -> {
@@ -550,7 +552,8 @@ void testRunOnEmptyGraph() {
                     null,
                     null,
                     null
-                )
+                ),
+                null
             );
 
             var methods = ProcedureMethodHelper.mutateMethods(proc).collect(Collectors.toList());
@@ -633,7 +636,8 @@ private GraphStore runMutation(String graphName, Map<String, Object> additionalC
                             null,
                             null,
                             null
-                        )
+                        ),
+                        null
                     );
                     Map<String, Object> config = new HashMap<>(additionalConfig);
                     config.put("mutateProperty", MUTATE_PROPERTY);

proc/community/src/test/java/org/neo4j/gds/wcc/WccStatsProcTest.java

@@ -299,7 +299,8 @@ private GraphDataScience createFacade() {
                 statsBusinessFacade,
                 null,
                 null
-            )
+            ),
+            null
         );
     }
 

proc/community/src/test/java/org/neo4j/gds/wcc/WccWriteProcTest.java

@@ -506,7 +506,8 @@ void testRunOnEmptyGraph() {
                             null,
                             null,
                             algorithmsBusinessFacade
-                        )
+                        ),
+                        null
                     );
 
                     Map<String, Object> configMap = Map.of("writeProperty", WRITE_PROPERTY);

procedures/facade/src/main/java/org/neo4j/gds/procedures/GraphDataScience.java

@@ -20,18 +20,26 @@
 package org.neo4j.gds.procedures;
 
 import org.neo4j.gds.logging.Log;
+import org.neo4j.gds.metrics.procedures.DeprecatedProceduresMetricService;
 import org.neo4j.gds.procedures.catalog.CatalogFacade;
 import org.neo4j.gds.procedures.community.CommunityProcedureFacade;
 
 public class GraphDataScience {
     private final Log log;
     private final CatalogFacade catalogFacade;
     private final CommunityProcedureFacade communityProcedureFacade;
+    private final DeprecatedProceduresMetricService deprecatedProceduresMetricService;
 
-    public GraphDataScience(Log log, CatalogFacade catalogFacade, CommunityProcedureFacade communityProcedureFacade) {
+    public GraphDataScience(
+        Log log,
+        CatalogFacade catalogFacade,
+        CommunityProcedureFacade communityProcedureFacade,
+        DeprecatedProceduresMetricService deprecatedProceduresMetricService
+    ) {
         this.log = log;
         this.catalogFacade = catalogFacade;
         this.communityProcedureFacade = communityProcedureFacade;
+        this.deprecatedProceduresMetricService = deprecatedProceduresMetricService;
     }
 
     public Log log() {
@@ -45,4 +53,8 @@ public CatalogFacade catalog() {
     public CommunityProcedureFacade community() {
         return communityProcedureFacade;
     }
+
+    public DeprecatedProceduresMetricService deprecatedProcedures() {
+        return deprecatedProceduresMetricService;
+    }
 }

procedures/integration/src/main/java/org/neo4j/gds/procedures/integration/ExtensionBuilder.java

@@ -207,7 +207,7 @@ public ThrowingFunction<Context, GraphDataScience, ProcedureException> gdsProvid
             metricsFacade
         );
 
-        return new GraphDataScienceProvider(log, catalogFacadeProvider, communityProcedureProvider);
+        return new GraphDataScienceProvider(log, catalogFacadeProvider, communityProcedureProvider, metricsFacade.deprecatedProcedures());
     }
 
     private CatalogFacadeProvider createCatalogFacadeProvider(

procedures/integration/src/main/java/org/neo4j/gds/procedures/integration/GraphDataScienceProvider.java

@@ -21,6 +21,7 @@
 
 import org.neo4j.function.ThrowingFunction;
 import org.neo4j.gds.logging.Log;
+import org.neo4j.gds.metrics.procedures.DeprecatedProceduresMetricService;
 import org.neo4j.gds.procedures.GraphDataScience;
 import org.neo4j.internal.kernel.api.exceptions.ProcedureException;
 import org.neo4j.kernel.api.procedure.Context;
@@ -32,22 +33,25 @@ public class GraphDataScienceProvider implements ThrowingFunction<Context, Graph
     private final Log log;
     private final CatalogFacadeProvider catalogFacadeProvider;
     private final CommunityProcedureProvider communityProcedureProvider;
+    private final DeprecatedProceduresMetricService deprecatedProceduresMetricService;
 
     public GraphDataScienceProvider(
         Log log,
         CatalogFacadeProvider catalogFacadeProvider,
-        CommunityProcedureProvider communityProcedureProvider
+        CommunityProcedureProvider communityProcedureProvider,
+        DeprecatedProceduresMetricService deprecatedProceduresMetricService
     ) {
         this.log = log;
         this.catalogFacadeProvider = catalogFacadeProvider;
         this.communityProcedureProvider = communityProcedureProvider;
+        this.deprecatedProceduresMetricService = deprecatedProceduresMetricService;
     }
 
     @Override
     public GraphDataScience apply(Context context) throws ProcedureException {
         var catalogFacade = catalogFacadeProvider.createCatalogFacade(context);
         var communityProcedureFacade = communityProcedureProvider.createCommunityProcedureFacade(context);
 
-        return new GraphDataScience(log, catalogFacade, communityProcedureFacade);
+        return new GraphDataScience(log, catalogFacade, communityProcedureFacade, deprecatedProceduresMetricService);
     }
 }