Skip to content

Commit 56be30a

Browse files
Always run cleanup query in doc tests
1 parent 4edb267 commit 56be30a

File tree

4 files changed

+25
-6
lines changed

4 files changed

+25
-6
lines changed

doc-test-tools/src/main/java/org/neo4j/gds/doc/DocExampleQueryParser.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public ParseResult parseAndCollect() {
6161
return new ParseResult(
6262
queryProcessor.getBeforeEachQueries(),
6363
queryProcessor.getBeforeAllQueries(),
64+
queryProcessor.getAfterAllQueries(),
6465
queryProcessor.getQueryExampleGroups()
6566
);
6667
}
@@ -76,6 +77,7 @@ private List<File> adocFiles() {
7677
public record ParseResult(
7778
List<DocQuery> beforeEachQueries,
7879
List<DocQuery> beforeAllQueries,
79-
List<QueryExampleGroup> queryExampleGroups) {
80-
}
80+
List<QueryExample> afterAllQueries,
81+
List<QueryExampleGroup> queryExampleGroups
82+
) {}
8183
}

doc-test-tools/src/main/java/org/neo4j/gds/doc/DocumentationTestToolsConstants.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ final class DocumentationTestToolsConstants {
3636
static final String CODE_BLOCK_CONTEXT = ":listing";
3737
static final String TABLE_CONTEXT = ":table";
3838
static final String SETUP_QUERY_ROLE = "setup-query";
39+
static final String CLEANUP_QUERY_ROLE = "cleanup-query";
3940
static final String GRAPH_PROJECT_QUERY_ROLE = "graph-project-query";
4041
static final String QUERY_EXAMPLE_ROLE = "query-example";
4142
static final String TEST_TYPE_NO_RESULT = "no-result";

doc-test-tools/src/main/java/org/neo4j/gds/doc/QueryCollectingTreeProcessor.java

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import java.util.UUID;
3737
import java.util.stream.Collectors;
3838

39+
import static org.neo4j.gds.doc.DocumentationTestToolsConstants.CLEANUP_QUERY_ROLE;
3940
import static org.neo4j.gds.doc.DocumentationTestToolsConstants.CODE_BLOCK_CONTEXT;
4041
import static org.neo4j.gds.doc.DocumentationTestToolsConstants.GRAPH_PROJECT_QUERY_ROLE;
4142
import static org.neo4j.gds.doc.DocumentationTestToolsConstants.QUERY_EXAMPLE_ROLE;
@@ -70,6 +71,8 @@ public class QueryCollectingTreeProcessor extends Treeprocessor {
7071

7172
private final List<DocQuery> beforeEachQueries = new ArrayList<>();
7273

74+
private final List<QueryExample> afterAllQueries = new ArrayList<>();
75+
7376
/**
7477
* "Group encounter order" is preserved if we use a LinkedHashMap, and while that is not strictly necessary, I think
7578
* it is a nice touch. Not sure if JUnit UI reflects it, TBD.
@@ -86,6 +89,7 @@ public Document process(Document document) {
8689
collectBeforeAllQueries(document);
8790
collectBeforeEachQueries(document);
8891
collectQueryExamples(document);
92+
collectAfterAllExampleQueries(document);
8993

9094
return document;
9195
}
@@ -98,6 +102,10 @@ public List<DocQuery> getBeforeEachQueries() {
98102
return beforeEachQueries;
99103
}
100104

105+
public List<QueryExample> getAfterAllQueries() {
106+
return afterAllQueries;
107+
}
108+
101109
/**
102110
* Do grouping into QueryExampleGroups
103111
*/
@@ -111,16 +119,24 @@ public List<QueryExampleGroup> getQueryExampleGroups() {
111119
}
112120

113121
private void collectBeforeAllQueries(StructuralNode document) {
114-
var queries = CollectSetupQueries(document, SETUP_QUERY_ROLE);
122+
var queries = collectSetupQueries(document, SETUP_QUERY_ROLE);
115123
beforeAllQueries.addAll(queries);
116124
}
117125

118126
private void collectBeforeEachQueries(StructuralNode document) {
119-
var queries = CollectSetupQueries(document, GRAPH_PROJECT_QUERY_ROLE);
127+
var queries = collectSetupQueries(document, GRAPH_PROJECT_QUERY_ROLE);
120128
beforeEachQueries.addAll(queries);
121129
}
122130

123-
private static List<DocQuery> CollectSetupQueries(StructuralNode node, String setupQueryType) {
131+
private void collectAfterAllExampleQueries(StructuralNode document) {
132+
var examples = document.findBy(Map.of(ROLE_SELECTOR, CLEANUP_QUERY_ROLE));
133+
for (StructuralNode example : examples) {
134+
var queryExample = convertToQueryExample(example);
135+
afterAllQueries.add(queryExample);
136+
}
137+
}
138+
139+
private static List<DocQuery> collectSetupQueries(StructuralNode node, String setupQueryType) {
124140
var nodes = node.findBy(Map.of(ROLE_SELECTOR, setupQueryType));
125141

126142
return nodes.stream()

doc/modules/ROOT/pages/installation/aura-graph-analytics-serverless.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ RETURN communityCount, modularity
620620

621621
Finally, drop the projected graph, which will also delete the GDS Session.
622622

623-
[role=query-example]
623+
[role=cleanup-query]
624624
--
625625
.Drop the graph 'myGraph':
626626
[source, cypher]

0 commit comments

Comments
 (0)