Rename maxIdx nodeCount/valueCount

Also replace all usage of `valuesStored`

Author: FlorentinD

algo-common/src/main/java/org/neo4j/gds/scaling/ScaleProperties.java

@@ -225,13 +225,8 @@ public double doubleValue(long nodeId) {
             }
 
             @Override
-            public long valuesStored() {
-                return property.valuesStored();
-            }
-
-            @Override
-            public long maxIndex() {
-                return property.maxIndex();
+            public long nodeCount() {
+                return property.nodeCount();
             }
         };
     }
@@ -249,13 +244,8 @@ public double doubleValue(long nodeId) {
             }
 
             @Override
-            public long valuesStored() {
-                return property.valuesStored();
-            }
-
-            @Override
-            public long maxIndex() {
-                return property.maxIndex();
+            public long nodeCount() {
+                return property.nodeCount();
             }
         };
     }
@@ -273,13 +263,8 @@ public double doubleValue(long nodeId) {
             }
 
             @Override
-            public long valuesStored() {
-                return property.valuesStored();
-            }
-
-            @Override
-            public long maxIndex() {
-                return property.maxIndex();
+            public long nodeCount() {
+                return property.nodeCount();
             }
         };
     }

algo/src/main/java/org/neo4j/gds/modularityoptimization/ModularityOptimization.java

@@ -414,14 +414,8 @@ public LongNodePropertyValues asNodeProperties() {
             public long longValue(long nodeId) {
                 return getCommunityId(nodeId);
             }
-
-            @Override
-            public long valuesStored() {
-                return currentCommunities.size();
-            }
-
-            @Override
-            public long maxIndex() {
+           @Override
+            public long nodeCount() {
                 return graph.nodeCount();
             }
         };

algo/src/main/java/org/neo4j/gds/pagerank/EigenvectorComputation.java

@@ -115,12 +115,7 @@ public boolean masterCompute(MasterComputeContext<PageRankConfig> context) {
 
         var properties = new DoubleNodePropertyValues() {
             @Override
-            public long valuesStored() {
-                return context.nodeCount();
-            }
-
-            @Override
-            public long maxIndex() {
+            public long nodeCount() {
                 return context.nodeCount();
             }
 

algo/src/main/java/org/neo4j/gds/similarity/knn/metrics/LongArrayPropertySimilarityComputer.java

@@ -55,7 +55,7 @@ static final class SortedLongArrayPropertyValues implements LongArrayNodePropert
         private final HugeObjectArray<long[]> properties;
 
         SortedLongArrayPropertyValues(NodePropertyValues nodePropertyValues) {
-            this.properties = HugeObjectArray.newArray(long[].class, nodePropertyValues.maxIndex());
+            this.properties = HugeObjectArray.newArray(long[].class, nodePropertyValues.nodeCount());
             this.properties.setAll(i -> {
                 long[] input = nodePropertyValues.longArrayValue(i);
 
@@ -70,12 +70,7 @@ static final class SortedLongArrayPropertyValues implements LongArrayNodePropert
         }
 
         @Override
-        public long valuesStored() {
-            return properties.size();
-        }
-
-        @Override
-        public long maxIndex() {
+        public long nodeCount() {
             return properties.size();
         }
 

algo/src/main/java/org/neo4j/gds/similarity/knn/metrics/NullCheckingNodePropertyValues.java

@@ -86,13 +86,8 @@ public Value value(long nodeId) {
     }
 
     @Override
-    public long valuesStored() {
-        return properties.valuesStored();
-    }
-
-    @Override
-    public long maxIndex() {
-        return properties.maxIndex();
+    public long nodeCount() {
+        return properties.nodeCount();
     }
 
     private void check(long nodeId, @Nullable Object value) {

algo/src/test/java/org/neo4j/gds/similarity/knn/metrics/LongArrayPropertySimilarityComputerTest.java

@@ -37,13 +37,8 @@ public long[] longArrayValue(long nodeId) {
             }
 
             @Override
-            public long valuesStored() {
-                return 2;
-            }
-
-            @Override
-            public long maxIndex() {
-                return 3;
+            public long nodeCount() {
+                return inputValues.length;
             }
         };
 

algo/src/test/java/org/neo4j/gds/similarity/knn/metrics/SimilarityComputerTest.java

@@ -265,12 +265,7 @@ public long[] longArrayValue(long nodeId) {
             }
 
             @Override
-            public long valuesStored() {
-                return 0;
-            }
-
-            @Override
-            public long maxIndex() {
+            public long nodeCount() {
                 return nodeCount;
             }
         };

alpha/alpha-proc/src/main/java/org/neo4j/gds/centrality/HarmonicCentralityWriteProc.java

@@ -92,12 +92,7 @@ public ComputationResultConsumer<HarmonicCentrality, HarmonicCentrality, Harmoni
 
                 var properties = new DoubleNodePropertyValues() {
                     @Override
-                    public long valuesStored() {
-                        return computationResult.graph().nodeCount();
-                    }
-
-                    @Override
-                    public long maxIndex() {
+                    public long nodeCount() {
                         return computationResult.graph().nodeCount();
                     }
 

alpha/alpha-proc/src/main/java/org/neo4j/gds/influenceMaximization/CelfNodeProperties.java

@@ -33,12 +33,7 @@ class CelfNodeProperties implements DoubleNodePropertyValues {
     }
 
     @Override
-    public long valuesStored() {
-        return celfSeedSet.size();
-    }
-
-    @Override
-    public long maxIndex() {
+    public long nodeCount() {
         return totalGraphNodeCount;
     }
 

alpha/alpha-proc/src/main/java/org/neo4j/gds/scaling/ScalePropertiesProc.java

@@ -33,12 +33,7 @@ static NodePropertyValues nodeProperties(ComputationResult<ScaleProperties, Scal
 
         return new DoubleArrayNodePropertyValues() {
             @Override
-            public long valuesStored() {
-                return scaledProperties.size();
-            }
-
-            @Override
-            public long maxIndex() {
+            public long nodeCount() {
                 return size;
             }