Don't log any percentage if logProgress is disabled

Co-authored-by: Ioannis Panagiotas <ioannis.panagiotas@neotechnology.com>

Author: vnickolov

algo/src/test/java/org/neo4j/gds/similarity/nodesim/NodeSimilarityTest.java

@@ -816,15 +816,13 @@ void shouldNotLogMessagesWhenLoggingIsDisabled(int topK, int concurrency) {
         nodeSimilarity.compute();
 
         assertThat(progressLog.getMessages(INFO))
-            .as("When progress logging is disabled we only log `start`, `100%` and `finished`.")
+            .as("When progress logging is disabled we only log `start` and `finished`.")
             .extracting(removingThreadId())
             .containsExactly(
                 "NodeSimilarity :: Start",
                 "NodeSimilarity :: prepare :: Start",
-                "NodeSimilarity :: prepare 100%",
                 "NodeSimilarity :: prepare :: Finished",
                 "NodeSimilarity :: compare node pairs :: Start",
-                "NodeSimilarity :: compare node pairs 100%",
                 "NodeSimilarity :: compare node pairs :: Finished",
                 "NodeSimilarity :: Finished"
             );

core/src/main/java/org/neo4j/gds/core/utils/progress/tasks/TaskProgressLogger.java

@@ -29,12 +29,18 @@
 class TaskProgressLogger extends BatchingProgressLogger {
 
     private final Task baseTask;
-    private final LoggingLeafTaskVisitor loggingLeafTaskVisitor;
+    private final TaskVisitor loggingLeafTaskVisitor;
 
     TaskProgressLogger(Log log, Task baseTask, int concurrency) {
         super(log, baseTask, concurrency);
         this.baseTask = baseTask;
         this.loggingLeafTaskVisitor = new LoggingLeafTaskVisitor(this);
+
+    }
+    TaskProgressLogger(Log log, Task baseTask, int concurrency, TaskVisitor leafTaskVisitor) {
+        super(log, baseTask, concurrency);
+        this.baseTask = baseTask;
+        this.loggingLeafTaskVisitor = leafTaskVisitor;
     }
 
     void logBeginSubTask(Task task, Task parentTask) {

core/src/main/java/org/neo4j/gds/core/utils/progress/tasks/TaskProgressTracker.java

@@ -58,12 +58,26 @@ public TaskProgressTracker(Task baseTask, Log log, int concurrency, TaskRegistry
     }
 
     public TaskProgressTracker(
-        Task baseTask, Log log, int concurrency, JobId jobId, TaskRegistryFactory taskRegistryFactory,
+        Task baseTask,
+        Log log,
+        int concurrency,
+        JobId jobId,
+        TaskRegistryFactory taskRegistryFactory,
+        UserLogRegistryFactory userLogRegistryFactory
+    ) {
+        this(baseTask, jobId, taskRegistryFactory, new TaskProgressLogger(log, baseTask, concurrency), userLogRegistryFactory);
+    }
+
+    protected TaskProgressTracker(
+        Task baseTask,
+        JobId jobId,
+        TaskRegistryFactory taskRegistryFactory,
+        TaskProgressLogger taskProgressLogger,
         UserLogRegistryFactory userLogRegistryFactory
     ) {
         this.baseTask = baseTask;
         this.taskRegistry = taskRegistryFactory.newInstance(jobId);
-        this.taskProgressLogger = new TaskProgressLogger(log, baseTask, concurrency);
+        this.taskProgressLogger = taskProgressLogger;
         this.currentTask = Optional.empty();
         this.currentTotalSteps = UNKNOWN_STEPS;
         this.progressLeftOvers = 0;

core/src/main/java/org/neo4j/gds/core/utils/progress/tasks/TaskTreeProgressTracker.java

@@ -34,7 +34,18 @@ public TaskTreeProgressTracker(
         TaskRegistryFactory taskRegistryFactory,
         UserLogRegistryFactory userLogRegistryFactory
     ) {
-        super(baseTask, log, concurrency, jobId, taskRegistryFactory, userLogRegistryFactory);
+        super(
+            baseTask,
+            jobId,
+            taskRegistryFactory,
+            new TaskProgressLogger(
+                log,
+                baseTask,
+                concurrency,
+                new PassThroughTaskVisitor()
+            ),
+            userLogRegistryFactory
+        );
     }
 
     @Override
@@ -51,4 +62,11 @@ public void logProgress(long value) {
     public void logProgress(long value, String messageTemplate) {
         // NOOP
     }
+
+    private static class PassThroughTaskVisitor implements TaskVisitor {
+        @Override
+        public void visitLeafTask(LeafTask leafTask) {
+            // NOOP --> just pass through
+        }
+    }
 }

proc/test/src/test/java/org/neo4j/gds/test/ProgressTrackingTest.java

@@ -85,12 +85,11 @@ void shouldNotLogProgress() {
         factory.build(graph, testConfig, log, taskRegistryFactoryMock).compute();
 
         assertThat(log.getMessages(TestLog.INFO))
-            .as("When `logProgress` is set to `false` there should only be `start`, `100%` and `finished` log messages")
+            .as("When `logProgress` is set to `false` there should only be `start` and `finished` log messages")
             .extracting(removingThreadId())
             .extracting(replaceTimings())
             .containsExactly(
                 "TestAlgorithm :: Start",
-                "TestAlgorithm 100%",
                 "TestAlgorithm :: Finished"
             );