Avoid creation of Nodes without node schema

Co-authored-by: Martin Junghanns <martin.junghanns@neotechnology.com>

Author: soerenreichardt

core/src/main/java/org/neo4j/gds/core/loading/CSRGraphStoreUtil.java

@@ -104,7 +104,7 @@ public static CSRGraphStore createFromGraph(
             // TODO: is it correct that we only use this for generated graphs?
             .capabilities(ImmutableStaticCapabilities.of(false))
             .schema(schema)
-            .nodes(Nodes.of(graph.idMap(), nodeProperties))
+            .nodes(ImmutableNodes.of(schema.nodeSchema(), graph.idMap(), nodeProperties))
             .relationshipImportResult(relationshipImportResult)
             .graphProperties(GraphPropertyStore.empty())
             .concurrency(concurrency)

core/src/main/java/org/neo4j/gds/core/loading/Nodes.java

@@ -20,6 +20,7 @@
 package org.neo4j.gds.core.loading;
 
 import org.immutables.value.Value;
+import org.jetbrains.annotations.TestOnly;
 import org.neo4j.gds.NodeLabel;
 import org.neo4j.gds.PropertyMapping;
 import org.neo4j.gds.PropertyMappings;
@@ -50,14 +51,11 @@ default NodePropertyStore properties() {
         return NodePropertyStore.empty();
     }
 
+    @TestOnly
     static Nodes of(IdMap idmap) {
         return ImmutableNodes.of(NodeSchema.empty(), idmap, NodePropertyStore.empty());
     }
 
-    static Nodes of(IdMap idmap, NodePropertyStore nodePropertyStore) {
-        return ImmutableNodes.of(NodeSchema.empty(), idmap, nodePropertyStore);
-    }
-
     static Nodes of(
         IdMap idMap,
         Map<NodeLabel, PropertyMappings> propertyMappingsByLabel,

graph-sampling/src/main/java/org/neo4j/gds/graphsampling/GraphSampleConstructor.java

@@ -33,7 +33,7 @@
 import org.neo4j.gds.core.concurrency.Pools;
 import org.neo4j.gds.core.concurrency.RunWithConcurrency;
 import org.neo4j.gds.core.loading.GraphStoreBuilder;
-import org.neo4j.gds.core.loading.Nodes;
+import org.neo4j.gds.core.loading.ImmutableNodes;
 import org.neo4j.gds.core.loading.RelationshipImportResult;
 import org.neo4j.gds.core.loading.construction.GraphFactory;
 import org.neo4j.gds.core.loading.construction.NodeLabelTokens;
@@ -124,7 +124,7 @@ public double evaluate(EvaluationContext context) {
             .databaseId(inputGraphStore.databaseId())
             .capabilities(inputGraphStore.capabilities())
             .schema(filteredSchema)
-            .nodes(Nodes.of(idMap, nodePropertyStore))
+            .nodes(ImmutableNodes.of(filteredSchema.nodeSchema(), idMap, nodePropertyStore))
             .relationshipImportResult(relationshipImportResult)
             .concurrency(config.concurrency())
             .build();

subgraph-filtering/src/main/java/org/neo4j/gds/beta/filter/GraphStoreFilter.java

@@ -34,7 +34,7 @@
 import org.neo4j.gds.beta.filter.expression.ValidationContext;
 import org.neo4j.gds.config.GraphProjectFromGraphConfig;
 import org.neo4j.gds.core.loading.GraphStoreBuilder;
-import org.neo4j.gds.core.loading.Nodes;
+import org.neo4j.gds.core.loading.ImmutableNodes;
 import org.neo4j.gds.core.loading.RelationshipImportResult;
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
 import org.neo4j.gds.core.utils.progress.tasks.Task;
@@ -121,7 +121,7 @@ public static GraphStore filter(
                 .databaseId(graphStore.databaseId())
                 .capabilities(graphStore.capabilities())
                 .schema(filteredSchema)
-                .nodes(Nodes.of(filteredNodes.idMap(), filteredNodes.propertyStores()))
+                .nodes(ImmutableNodes.of(filteredSchema.nodeSchema(), filteredNodes.idMap(), filteredNodes.propertyStores()))
                 .relationshipImportResult(RelationshipImportResult.of(filteredRelationships))
                 .concurrency(config.concurrency())
                 .build();