Skip to content

Commit 7d4f681

Browse files
Remote clique counting memory estimation
Co-authored-by: Ioannis Panagiotas <ioannis.panagiotas@neo4j.com>
1 parent 363a14c commit 7d4f681

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

algo/src/main/java/org/neo4j/gds/cliqueCounting/CliqueCountingResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@
2424
public record CliqueCountingResult(
2525
long[] globalCount,
2626
HugeObjectArray<long[]> perNodeCount,
27-
long[][] perSubcliqueCount //todo: turn this into a map of long[] instead?
27+
long[][] perSubcliqueCount
2828
){}

proc/community/src/integrationTest/java/org/neo4j/gds/cliquecounting/CliqueCountingStatsProcTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@
3737

3838
class CliqueCountingStatsProcTest extends BaseProcTest {
3939

40-
//todo
41-
4240
private static final String CLIQUE_COUNTING_GRAPH = "myGraph";
4341

4442
@Neo4jGraph
@@ -102,7 +100,7 @@ void testRunOnEmptyGraph() {
102100
GraphStoreCatalog.removeAllLoadedGraphs();
103101

104102
String projectQuery = GdsCypher.call("foo")
105-
.graphProject().loadEverything(Orientation.UNDIRECTED).yields();
103+
.graphProject().loadEverything(Orientation.UNDIRECTED).yields();
106104
runQuery(projectQuery);
107105

108106
String query = GdsCypher.call("foo")

proc/community/src/integrationTest/java/org/neo4j/gds/cliquecounting/CliqueCountingWriteProcTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.intellij.lang.annotations.Language;
2525
import org.junit.jupiter.api.AfterEach;
2626
import org.junit.jupiter.api.BeforeEach;
27-
import org.junit.jupiter.api.Disabled;
2827
import org.junit.jupiter.api.Test;
2928
import org.neo4j.gds.BaseProcTest;
3029
import org.neo4j.gds.GdsCypher;
@@ -120,10 +119,8 @@ void testWriting() {
120119
Assertions.assertThat(cliqueCountingResult.get("e")).isEmpty();
121120
}
122121

123-
@Disabled
122+
@Test
124123
void testWritingEstimate() {
125-
//todo?
126-
127124
@Language("Cypher")
128125
String query = GdsCypher.call(CLIQUE_COUNTING_GRAPH).algo("gds.cliqueCounting")
129126
.estimationMode(GdsCypher.ExecutionModes.WRITE)

procedures/facade-api/community-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/community/CommunityProcedureFacade.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Stream<CliqueCountingStatsResult> cliqueCountingStats(
7070
Map<String, Object> configuration
7171
);
7272

73-
Stream<MemoryEstimateResult> cliqueCountingStatsEstimate( //todo
73+
Stream<MemoryEstimateResult> cliqueCountingStatsEstimate(
7474
Object graphNameOrConfiguration,
7575
Map<String, Object> rawConfiguration
7676
);
@@ -80,7 +80,7 @@ Stream<CliqueCountingStreamResult> cliqueCountingStream(
8080
Map<String, Object> configuration
8181
);
8282

83-
Stream<MemoryEstimateResult> cliqueCountingStreamEstimate( //todo
83+
Stream<MemoryEstimateResult> cliqueCountingStreamEstimate(
8484
Object graphNameOrConfiguration,
8585
Map<String, Object> rawConfiguration
8686
);
@@ -90,7 +90,7 @@ Stream<CliqueCountingWriteResult> cliqueCountingWrite(
9090
Map<String, Object> configuration
9191
);
9292

93-
Stream<MemoryEstimateResult> cliqueCountingWriteEstimate( //todo
93+
Stream<MemoryEstimateResult> cliqueCountingWriteEstimate(
9494
Object graphNameOrConfiguration,
9595
Map<String, Object> rawConfiguration
9696
);

0 commit comments

Comments
 (0)