Validate concurrency in GraphStreamRelationshipsConfig

Author: FlorentinD

core/src/main/java/org/neo4j/gds/config/GraphStreamRelationshipsConfig.java

@@ -23,7 +23,6 @@
 import org.neo4j.gds.ElementProjection;
 import org.neo4j.gds.RelationshipType;
 import org.neo4j.gds.annotation.Configuration;
-import org.neo4j.gds.annotation.ValueClass;
 import org.neo4j.gds.api.GraphStore;
 import org.neo4j.gds.core.CypherMapWrapper;
 
@@ -36,9 +35,8 @@
 
 import static org.neo4j.gds.utils.StringFormatting.formatWithLocale;
 
-@ValueClass
 @Configuration
-public interface GraphStreamRelationshipsConfig extends BaseConfig {
+public interface GraphStreamRelationshipsConfig extends BaseConfig, ConcurrencyConfig  {
 
     @Configuration.Parameter
     Optional<String> graphName();
@@ -49,11 +47,6 @@ default List<String> relationshipTypes() {
         return Collections.singletonList(ElementProjection.PROJECT_ALL);
     }
 
-    @Value.Default
-    default int concurrency() {
-        return ConcurrencyConfig.DEFAULT_CONCURRENCY;
-    }
-
     @Configuration.Ignore
     default Collection<RelationshipType> relationshipTypeIdentifiers(GraphStore graphStore) {
         return relationshipTypes().contains(ElementProjection.PROJECT_ALL)

core/src/test/java/org/neo4j/gds/config/GraphStreamRelationshipsConfigTest.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) "Neo4j"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Neo4j is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.neo4j.gds.config;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+class GraphStreamRelationshipsConfigTest {
+
+    @Test
+    void validateConcurrency() {
+        var builder = GraphStreamRelationshipsConfigImpl.builder()
+            .graphName(Optional.of("g"))
+            .relationshipTypes(List.of("*"))
+            .concurrency(42);
+
+        assertThatThrownBy(builder::build).hasMessageContaining("Community users cannot exceed concurrency");
+    }
+
+}

proc/catalog/src/test/java/org/neo4j/gds/catalog/GraphStreamRelationshipsProcTest.java

@@ -133,7 +133,7 @@ void shouldStreamInParallel() {
         runQuery("CALL gds.beta.graph.generate('generatedGraph', 10000, 5)");
 
         var actualRelationships = new ArrayList<TopologyResult>();
-        runQueryWithRowConsumer("CALL gds.beta.graph.relationships.stream('generatedGraph', ['*'], { concurrency: 4 })", row -> actualRelationships.add(
+        runQueryWithRowConsumer("CALL gds.beta.graph.relationships.stream('generatedGraph', ['*'], { concurrency: 10 })", row -> actualRelationships.add(
             relationship(
                 row.getNumber("sourceNodeId").longValue(),
                 row.getNumber("targetNodeId").longValue(),