Nitfix confusing optional and returns

Author: jjaderberg

procedures/pipelines-facade/src/main/java/org/neo4j/gds/procedures/pipelines/LinkPredictionPredictPipelineBaseConfig.java

@@ -149,7 +149,9 @@ default void validateParameterCombinations() {
             );
             validateStrategySpecificParameters(approximateStrategyParameters, "less than 1");
 
-            topN().orElseThrow(() -> MissingParameterExceptions.missingValueFor("topN", Collections.emptyList()));
+            if (topN().isEmpty()) {
+                throw MissingParameterExceptions.missingValueFor("topN", Collections.emptyList());
+            }
         }
     }
 

procedures/pipelines-facade/src/main/java/org/neo4j/gds/procedures/pipelines/NodeRegressionPredictConfigPreProcessor.java

@@ -40,7 +40,7 @@ public class NodeRegressionPredictConfigPreProcessor {
 
     void enhanceInputWithPipelineParameters(Map<String, Object> userInput) {
         Optional.ofNullable(userInput.get("modelName"))
-            .map(modelName -> {
+            .ifPresent(modelName -> {
                 assert modelCatalog != null : "ModelCatalog should have been set in the ExecutionContext by this point!!!";
 
                 var trainedModel = modelCatalog.get(
@@ -61,7 +61,6 @@ void enhanceInputWithPipelineParameters(Map<String, Object> userInput) {
 
                 userInput.put("targetNodeLabels", combinedTargetNodeLabels);
                 userInput.put("relationshipTypes", combinedRelationshipTypes);
-                return userInput;
             });
     }
 }