Skip to content

Commit 960434a

Browse files
committed
added 5.17 enum on 2.6
1 parent 2a395bd commit 960434a

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

neo4j-adapter/src/main/java/org/neo4j/gds/compat/Neo4jVersion.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ public enum Neo4jVersion {
3434
V_5_14,
3535
V_5_15,
3636
V_5_16,
37+
V_5_17,
3738
V_RC;
3839

39-
private static final int MINOR_DEV_VERSION = 17;
40+
private static final int MINOR_DEV_VERSION = 18;
4041

4142
static Neo4jVersion parse(String version) {
4243
var versionSegments = Pattern.compile("[.-]")
@@ -73,6 +74,8 @@ static Neo4jVersion parse(String version) {
7374
return Neo4jVersion.V_5_15;
7475
case 16:
7576
return Neo4jVersion.V_5_16;
77+
case 17:
78+
return Neo4jVersion.V_5_17;
7679
default:
7780
if (minorVersion >= MINOR_DEV_VERSION) {
7881
return Neo4jVersion.V_RC;
@@ -143,6 +146,8 @@ public String toString() {
143146
return "5.15";
144147
case V_5_16:
145148
return "5.16";
149+
case V_5_17:
150+
return "5.17";
146151
case V_RC:
147152
return "dev";
148153
default:

neo4j-adapter/src/test/java/org/neo4j/gds/compat/Neo4jVersionTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ class Neo4jVersionTest {
4444
"5.14.0, V_5_14",
4545
"5.15.0, V_5_15",
4646
"5.16.0, V_5_16",
47-
"5.17.0, V_RC",
47+
"5.17.0, V_5_17",
48+
"5.18.0, V_RC",
4849
})
4950
void testParse(String input, Neo4jVersion expected) {
5051
assertEquals(expected.name(), Neo4jVersion.parse(input).name());
@@ -91,6 +92,7 @@ void shouldNotRespectVersionOverride() {
9192
"5.14.0, 5, 14",
9293
"5.15.0, 5, 15",
9394
"5.16.0, 5, 16",
95+
"5.17.0, 5, 17",
9496
}
9597
)
9698
void semanticVersion(String input, int expectedMajor, int expectedMinor) {

proc/sysinfo/src/test/java/org/neo4j/gds/SysInfoProcTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ class SysInfoProcTest extends BaseProcTest {
7575
"Neo4j 5.16",
7676
"Neo4j 5.16 (placeholder)",
7777

78+
"Neo4j 5.17",
79+
"Neo4j 5.17 (placeholder)",
80+
7881
"Neo4j DEV",
7982
"Neo4j DEV (placeholder)",
8083

@@ -179,6 +182,14 @@ void testSysInfoProc() throws IOException {
179182
"Neo4j 5.16"
180183
);
181184
break;
185+
case V_5_17:
186+
expectedCompatibilities = Set.of(
187+
"Neo4j Settings 5.x (placeholder)",
188+
"Neo4j Settings 5.x",
189+
"Neo4j 5.17 (placeholder)",
190+
"Neo4j 5.17"
191+
);
192+
break;
182193
case V_RC:
183194
expectedCompatibilities = Set.of(
184195
"Neo4j Settings 5.x",

0 commit comments

Comments
 (0)