Merge pull request #10319 from vnickolov/remote-community-write

remote community write

Author: vnickolov

procedures/facade-api/community-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/community/K1ColoringWriteResult.java

@@ -23,38 +23,16 @@
 
 import java.util.Map;
 
-public class K1ColoringWriteResult {
-    public final long preProcessingMillis;
-    public final long computeMillis;
-    public final long writeMillis;
-
-    public final long nodeCount;
-    public final long colorCount;
-    public final long ranIterations;
-    public final boolean didConverge;
-
-    public Map<String, Object> configuration;
-
-    public K1ColoringWriteResult(
-        long preProcessingMillis,
-        long computeMillis,
-        long writeMillis,
-        long nodeCount,
-        long colorCount,
-        long ranIterations,
-        boolean didConverge,
-        Map<String, Object> configuration
-    ) {
-        this.preProcessingMillis = preProcessingMillis;
-        this.computeMillis = computeMillis;
-        this.writeMillis = writeMillis;
-        this.nodeCount = nodeCount;
-        this.colorCount = colorCount;
-        this.ranIterations = ranIterations;
-        this.didConverge = didConverge;
-        this.configuration = configuration;
-    }
-
+public record K1ColoringWriteResult(
+    long preProcessingMillis,
+    long computeMillis,
+    long writeMillis,
+    long nodeCount,
+    long colorCount,
+    long ranIterations,
+    boolean didConverge,
+    Map<String, Object> configuration
+) {
     static K1ColoringWriteResult emptyFrom(AlgorithmProcessingTimings timings, Map<String, Object> configurationMap) {
         return new K1ColoringWriteResult(
             timings.preProcessingMillis,

procedures/facade-api/community-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/community/KCoreDecompositionWriteResult.java

@@ -20,28 +20,19 @@
 package org.neo4j.gds.procedures.algorithms.community;
 
 import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
-import org.neo4j.gds.procedures.algorithms.results.StandardWriteResult;
-import org.neo4j.gds.result.AbstractResultBuilder;
+import org.neo4j.gds.procedures.algorithms.results.WriteNodePropertiesResult;
 
 import java.util.Map;
 
-public class KCoreDecompositionWriteResult extends StandardWriteResult {
-    public final long nodePropertiesWritten;
-    public final long degeneracy;
-
-    public KCoreDecompositionWriteResult(
-        long nodePropertiesWritten,
-        long degeneracy,
-        long preProcessingMillis,
-        long computeMillis,
-        long postProcessingMillis,
-        long writeMillis,
-        Map<String, Object> configuration
-    ) {
-        super(preProcessingMillis, computeMillis, postProcessingMillis, writeMillis, configuration);
-        this.nodePropertiesWritten = nodePropertiesWritten;
-        this.degeneracy = degeneracy;
-    }
+public record KCoreDecompositionWriteResult(
+    long nodePropertiesWritten,
+    long degeneracy,
+    long preProcessingMillis,
+    long computeMillis,
+    long postProcessingMillis,
+    long writeMillis,
+    Map<String, Object> configuration
+) implements WriteNodePropertiesResult {
 
     static KCoreDecompositionWriteResult emptyFrom(
         AlgorithmProcessingTimings timings,
@@ -57,25 +48,4 @@ static KCoreDecompositionWriteResult emptyFrom(
             configurationMap
         );
     }
-
-    public static final class Builder extends AbstractResultBuilder<KCoreDecompositionWriteResult> {
-        private long degeneracy;
-
-        public Builder withDegeneracy(long degeneracy) {
-            this.degeneracy = degeneracy;
-            return this;
-        }
-
-        public KCoreDecompositionWriteResult build() {
-            return new KCoreDecompositionWriteResult(
-                nodePropertiesWritten,
-                degeneracy,
-                preProcessingMillis,
-                computeMillis,
-                -1L,
-                writeMillis,
-                config.toMap()
-            );
-        }
-    }
 }

procedures/facade-api/community-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/community/ModularityOptimizationWriteResult.java

@@ -19,51 +19,24 @@
  */
 package org.neo4j.gds.procedures.algorithms.community;
 
-import org.neo4j.gds.api.ProcedureReturnColumns;
 import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
-import org.neo4j.gds.core.concurrency.Concurrency;
 
 import java.util.Collections;
 import java.util.Map;
 
-public class ModularityOptimizationWriteResult {
-    public final long preProcessingMillis;
-    public final long computeMillis;
-    public final long writeMillis;
-    public final long postProcessingMillis;
-    public final long nodes;
-    public boolean didConverge;
-    public long ranIterations;
-    public double modularity;
-    public final long communityCount;
-    public final Map<String, Object> communityDistribution;
-    public final Map<String, Object> configuration;
-
-    public ModularityOptimizationWriteResult(
-        long preProcessingMillis,
-        long computeMillis,
-        long postProcessingMillis,
-        long writeMillis,
-        long nodes,
-        boolean didConverge,
-        long ranIterations,
-        double modularity,
-        long communityCount,
-        Map<String, Object> communityDistribution,
-        Map<String, Object> configuration
-    ) {
-        this.preProcessingMillis = preProcessingMillis;
-        this.computeMillis = computeMillis;
-        this.writeMillis = writeMillis;
-        this.postProcessingMillis = postProcessingMillis;
-        this.nodes = nodes;
-        this.didConverge = didConverge;
-        this.ranIterations = ranIterations;
-        this.modularity = modularity;
-        this.communityCount = communityCount;
-        this.communityDistribution = communityDistribution;
-        this.configuration = configuration;
-    }
+public record ModularityOptimizationWriteResult(
+    long preProcessingMillis,
+    long computeMillis,
+    long postProcessingMillis,
+    long writeMillis,
+    long nodes,
+    boolean didConverge,
+    long ranIterations,
+    double modularity,
+    long communityCount,
+    Map<String, Object> communityDistribution,
+    Map<String, Object> configuration
+) {
 
     static ModularityOptimizationWriteResult emptyFrom(
         AlgorithmProcessingTimings timings,
@@ -83,30 +56,4 @@ static ModularityOptimizationWriteResult emptyFrom(
             configurationMap
         );
     }
-
-    public static class Builder extends ModularityOptimizationResultBuilder<ModularityOptimizationWriteResult> {
-        public Builder(
-            ProcedureReturnColumns returnColumns,
-            Concurrency concurrency
-        ) {
-            super(returnColumns, concurrency);
-        }
-
-        @Override
-        protected ModularityOptimizationWriteResult buildResult() {
-            return new ModularityOptimizationWriteResult(
-                preProcessingMillis,
-                computeMillis,
-                postProcessingDuration,
-                writeMillis,
-                nodeCount,
-                didConverge,
-                ranIterations,
-                modularity,
-                maybeCommunityCount.orElse(0),
-                communityHistogramOrNull(),
-                config.toMap()
-            );
-        }
-    }
 }