Almost purge RW config from algo code

Author: jjaderberg

algo/src/main/java/org/neo4j/gds/traversal/RandomWalk.java

@@ -54,15 +54,18 @@ public final class RandomWalk extends Algorithm<Stream<long[]>> {
 
     public static RandomWalk create(
         Graph graph,
-        RandomWalkBaseConfig config,
+        int concurrency,
         WalkParameters walkParameters,
+        List<Long> sourceNodes,
+        int walkBufferSize,
+        Optional<Long> randomSeed,
         ProgressTracker progressTracker,
         ExecutorService executorService
     ) {
         if (graph.hasRelationshipProperty()) {
             EmbeddingUtils.validateRelationshipWeightPropertyValue(
                 graph,
-                config.concurrency(),
+                concurrency,
                 weight -> weight >= 0,
                 "RandomWalk only supports non-negative weights.",
                 executorService
@@ -71,15 +74,12 @@ public static RandomWalk create(
 
         return new RandomWalk(
             graph,
-            config.concurrency(),
+            concurrency,
             executorService,
-            config.walkBufferSize(),
-            walkParameters.walksPerNode,
-            walkParameters.walkLength,
-            walkParameters.returnFactor,
-            walkParameters.inOutFactor,
-            config.sourceNodes(),
-            config.randomSeed(),
+            walkParameters,
+            sourceNodes,
+            walkBufferSize,
+            randomSeed,
             progressTracker
         );
     }
@@ -88,12 +88,9 @@ private RandomWalk(
         Graph graph,
         int concurrency,
         ExecutorService executorService,
-        int walkBufferSize,
-        int walksPerNode,
-        int walkLength,
-        double returnFactor,
-        double inOutFactor,
+        WalkParameters walkParameters,
         List<Long> sourceNodes,
+        int walkBufferSize,
         Optional<Long> maybeRandomSeed,
         ProgressTracker progressTracker
     ) {
@@ -115,10 +112,7 @@ private RandomWalk(
             nextNodeSupplier,
             cumulativeWeightSupplier,
             walks,
-            walksPerNode,
-            walkLength,
-            returnFactor,
-            inOutFactor,
+            walkParameters,
             randomSeed,
             progressTracker,
             externalTerminationFlag

algo/src/main/java/org/neo4j/gds/traversal/RandomWalkAlgorithmFactory.java

@@ -45,7 +45,16 @@ public RandomWalk build(
         RandomWalkBaseConfig configuration,
         ProgressTracker progressTracker
     ) {
-        return RandomWalk.create(graph, configuration, configuration.walkParameters(), progressTracker, DefaultPool.INSTANCE);
+        return RandomWalk.create(
+            graph,
+            configuration.concurrency(),
+            configuration.walkParameters(),
+            configuration.sourceNodes(),
+            configuration.walkBufferSize(),
+            configuration.randomSeed(),
+            progressTracker,
+            DefaultPool.INSTANCE
+        );
     }
 
     @Override

algo/src/main/java/org/neo4j/gds/traversal/RandomWalkTaskSupplier.java

@@ -32,10 +32,7 @@ class RandomWalkTaskSupplier implements Supplier<RandomWalkTask> {
     private final NextNodeSupplier nextNodeSupplier;
     private final RandomWalkSampler.CumulativeWeightSupplier cumulativeWeightSupplier;
     private final BlockingQueue<long[]> walks;
-    private final int walksPerNode;
-    private final int walkLength;
-    private final double returnFactor;
-    private final double inOutFactor;
+    private final WalkParameters walkParameters;
     private final long randomSeed;
     private final ProgressTracker progressTracker;
     private final TerminationFlag terminationFlag;
@@ -45,10 +42,7 @@ class RandomWalkTaskSupplier implements Supplier<RandomWalkTask> {
         NextNodeSupplier nextNodeSupplier,
         RandomWalkSampler.CumulativeWeightSupplier cumulativeWeightSupplier,
         BlockingQueue<long[]> walks,
-        int walksPerNode,
-        int walkLength,
-        double returnFactor,
-        double inOutFactor,
+        WalkParameters walkParameters,
         long randomSeed,
         ProgressTracker progressTracker,
         TerminationFlag terminationFlag
@@ -57,10 +51,7 @@ class RandomWalkTaskSupplier implements Supplier<RandomWalkTask> {
         this.nextNodeSupplier = nextNodeSupplier;
         this.cumulativeWeightSupplier = cumulativeWeightSupplier;
         this.walks = walks;
-        this.walksPerNode = walksPerNode;
-        this.walkLength = walkLength;
-        this.returnFactor = returnFactor;
-        this.inOutFactor = inOutFactor;
+        this.walkParameters = walkParameters;
         this.randomSeed = randomSeed;
         this.progressTracker = progressTracker;
         this.terminationFlag = terminationFlag;
@@ -73,10 +64,10 @@ public RandomWalkTask get() {
             nextNodeSupplier,
             cumulativeWeightSupplier,
             walks,
-            walksPerNode,
-            walkLength,
-            returnFactor,
-            inOutFactor,
+            walkParameters.walksPerNode,
+            walkParameters.walkLength,
+            walkParameters.returnFactor,
+            walkParameters.inOutFactor,
             randomSeed,
             progressTracker,
             terminationFlag