Attempt to reduce contention

- Use get + getAndSet instead of just getAndSet
- Use one AtomicBoolean instead of two

Author: pontusmelke

cypher-aggregation/src/main/java/org/neo4j/gds/projection/GraphAggregator.java

@@ -157,6 +157,7 @@ void projectNextRelationship(
         NodeLabelToken sourceNodeLabels = NodeLabelTokens.missing();
         NodeLabelToken targetNodeLabels = NodeLabelTokens.missing();
 
+        this.configValidator.validateConfigs(nodesConfig, relationshipConfig);
         if (nodesConfig instanceof MapValue) {
             sourceNodePropertyValues = GraphImporter.propertiesConfig("sourceNodeProperties", (MapValue) nodesConfig);
             sourceNodeLabels = labelsConfig("sourceNodeLabels", (MapValue) nodesConfig);
@@ -168,8 +169,6 @@ void projectNextRelationship(
                 );
                 targetNodeLabels = labelsConfig("targetNodeLabels", (MapValue) nodesConfig);
             }
-
-            this.configValidator.validateNodesConfig((MapValue) nodesConfig);
         }
 
         var data = initGraphData(
@@ -309,18 +308,27 @@ private static final class ConfigValidator {
             "relationshipType"
         );
 
-        private final AtomicBoolean validateNodes = new AtomicBoolean(true);
-        private final AtomicBoolean validateRelationships = new AtomicBoolean(true);
-
-        void validateNodesConfig(MapValue nodesConfig) {
-            if (this.validateNodes.getAndSet(false)) {
-                ConfigKeyValidation.requireOnlyKeysFrom(NODES_CONFIG_KEYS, nodesConfig.keySet());
-            }
-        }
 
-        void validateRelationshipsConfig(MapValue relationshipConfig) {
-            if (this.validateRelationships.getAndSet(false)) {
-                ConfigKeyValidation.requireOnlyKeysFrom(RELATIONSHIPS_CONFIG_KEYS, relationshipConfig.keySet());
+        private final AtomicBoolean validate = new AtomicBoolean(true);
+
+        void validateConfigs(AnyValue nodesConfig, AnyValue relationshipConfig) {
+            if (nodesConfig instanceof MapValue || relationshipConfig instanceof MapValue) {
+                if (this.validate.get()) {
+                    if (this.validate.getAndSet(false)) {
+                        if (nodesConfig instanceof MapValue) {
+                            ConfigKeyValidation.requireOnlyKeysFrom(
+                                NODES_CONFIG_KEYS,
+                                ((MapValue) nodesConfig).keySet()
+                            );
+                        }
+                        if (relationshipConfig instanceof MapValue) {
+                            ConfigKeyValidation.requireOnlyKeysFrom(
+                                NODES_CONFIG_KEYS,
+                                ((MapValue) relationshipConfig).keySet()
+                            );
+                        }
+                    }
+                }
             }
         }
     }
@@ -465,8 +473,6 @@ void update(
             if (relationshipConfig instanceof MapValue) {
                 relationshipProperties = propertiesConfig("properties", (MapValue) relationshipConfig);
                 relationshipType = typeConfig("relationshipType", (MapValue) relationshipConfig);
-
-                configValidator.validateRelationshipsConfig((MapValue) relationshipConfig);
             }
 
             var intermediateSourceId = loadNode(sourceNode, sourceNodeLabels, sourceNodePropertyValues);
@@ -723,6 +729,7 @@ static MapValue propertiesConfig(
             @NotNull MapValue propertiesConfig
         ) {
             var nodeProperties = propertiesConfig.get(propertyKey);
+
             if (nodeProperties instanceof MapValue) {
                 return (MapValue) nodeProperties;
             }