Refactor FastRPParameters

Author: vnickolov

algo-params/node-embeddings-params/src/main/java/org/neo4j/gds/embeddings/fastrp/FastRPParameters.java

@@ -31,10 +31,14 @@ public record FastRPParameters(
     List<String> featureProperties,
     List<Number> iterationWeights,
     int embeddingDimension,
-    int propertyDimension,
+    double propertyRatio,
     Optional<String> relationshipWeightProperty,
     float normalizationStrength,
     Number nodeSelfInfluence,
     Concurrency concurrency,
     Optional<Long> randomSeed
-)  implements AlgorithmParameters { }
+)  implements AlgorithmParameters {
+    public int propertyDimension() {
+        return (int) (embeddingDimension() * propertyRatio());
+    }
+}

algo/src/main/java/org/neo4j/gds/embeddings/fastrp/FastRPConfigTransformer.java

@@ -28,7 +28,7 @@ public static FastRPParameters toParameters(FastRPBaseConfig config) {
             config.featureProperties(),
             config.iterationWeights(),
             config.embeddingDimension(),
-            config.propertyDimension(),
+            config.propertyRatio(),
             config.relationshipWeightProperty(),
             config.normalizationStrength(),
             config.nodeSelfInfluence(),

algo/src/test/java/org/neo4j/gds/embeddings/fastrp/FastRPTest.java

@@ -130,7 +130,7 @@ void shouldSwapInitialRandomVectors() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -176,7 +176,7 @@ void shouldAverageNeighbors() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -219,7 +219,7 @@ void shouldAddInitialVectors() {
             List.of("f1", "f2", "f3"),
             List.of(0.0D),
             embeddingDimension,
-            (int) (0.5 * embeddingDimension),
+            0.5,
             Optional.empty(),
             0.0F,
             0.6,
@@ -297,7 +297,7 @@ void shouldInitialisePropertyEmbeddingsCorrectly() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -754,7 +754,7 @@ void shouldBeDeterministicInParallel() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -766,7 +766,7 @@ void shouldBeDeterministicInParallel() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -818,7 +818,7 @@ void shouldAverageNeighborsWeighted() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.of("weight"),
             0.0F,
             0,
@@ -866,7 +866,7 @@ void shouldDistributeValuesCorrectly() {
             List.of(),
             List.of(1.0D),
             512,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.125,
             Optional.empty(),
             0.0F,
             0,
@@ -924,7 +924,7 @@ void shouldYieldEmptyEmbeddingForIsolatedNodes() {
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -1036,7 +1036,7 @@ void shouldFailWhenNodePropertiesAreMissing() {
                 List.of("prop"),
                 List.of(1.0D, 1.0D, 1.0D, 1.0D),
                 64,
-                0,
+                0.5,
                 Optional.empty(),
                 0.0F,
                 0,
@@ -1075,7 +1075,7 @@ void shouldFailWhenRelationshipWeightIsMissing() {
                 List.of(),
                 List.of(1.0D),
                 DEFAULT_EMBEDDING_DIMENSION,
-                0,
+                0.5,
                 Optional.of("weight"),
                 0.0F,
                 0,
@@ -1174,7 +1174,7 @@ void shouldBeDeterministicGivenSameOriginalIds() {
             List.of(),
             List.of(1.0D),
             embeddingDimension,
-            0,
+            0.5,
             Optional.empty(),
             0.0F,
             0,
@@ -1217,7 +1217,7 @@ private HugeObjectArray<float[]> embeddings(Graph graph, List<String> properties
             List.of("f1", "f2", "f3"),
             List.of(1.0D),
             DEFAULT_EMBEDDING_DIMENSION,
-            (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+            0.5,
             Optional.empty(),
             0.0F,
             0,

algorithms-compute-facade/src/test/java/org/neo4j/gds/embeddings/NodeEmbeddingComputeFacadeTest.java

@@ -118,7 +118,7 @@ void fastRP() {
                 List.of("f"),
                 List.of(1.0D),
                 DEFAULT_EMBEDDING_DIMENSION,
-                (int) (0.5 * DEFAULT_EMBEDDING_DIMENSION),
+                0.0,
                 Optional.empty(),
                 0.0F,
                 0,