Add validation for ToUndirected config options

Author: DarthMax

proc/beta/src/main/java/org/neo4j/gds/beta/undirected/ToUndirectedSpec.java

@@ -21,6 +21,7 @@
 
 import org.neo4j.gds.MutateComputationResultConsumer;
 import org.neo4j.gds.RelationshipType;
+import org.neo4j.gds.config.ElementTypeValidator;
 import org.neo4j.gds.core.loading.SingleTypeRelationshipImportResult;
 import org.neo4j.gds.executor.AlgorithmSpec;
 import org.neo4j.gds.executor.ComputationResult;
@@ -29,9 +30,12 @@
 import org.neo4j.gds.executor.ExecutionMode;
 import org.neo4j.gds.executor.GdsCallable;
 import org.neo4j.gds.executor.NewConfigFunction;
+import org.neo4j.gds.executor.validation.AfterLoadValidation;
+import org.neo4j.gds.executor.validation.ValidationConfiguration;
 import org.neo4j.gds.result.AbstractResultBuilder;
 import org.neo4j.gds.results.StandardMutateResult;
 
+import java.util.List;
 import java.util.Map;
 import java.util.stream.Stream;
 
@@ -80,6 +84,21 @@ protected void updateGraphStore(
         };
     }
 
+    @Override
+    public ValidationConfiguration<ToUndirectedConfig> validationConfig() {
+        return new ValidationConfiguration<>() {
+            @Override
+            public List<AfterLoadValidation<ToUndirectedConfig>> afterLoadValidations() {
+                return List.of(
+                    (graphStore, graphProjectConfig, config) -> {
+                        var relationshipType = RelationshipType.of(config.relationshipType());
+                        ElementTypeValidator.validateTypes(graphStore, List.of(relationshipType), "`relationshipType`");
+                    }
+                );
+            }
+        };
+    }
+
     public static final class MutateResult extends StandardMutateResult {
         public final long inputRelationships;
         public final long relationshipsWritten;

proc/beta/src/test/java/org/neo4j/gds/beta/undirected/ToUndirectedProcTest.java

@@ -28,13 +28,18 @@
 import org.neo4j.gds.catalog.GraphProjectProc;
 import org.neo4j.gds.core.loading.GraphStoreCatalog;
 import org.neo4j.gds.extension.Neo4jGraph;
+import org.neo4j.graphdb.QueryExecutionException;
 
 import java.util.List;
 import java.util.Map;
 
 import static org.hamcrest.Matchers.instanceOf;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.neo4j.gds.TestSupport.assertGraphEquals;
 import static org.neo4j.gds.TestSupport.fromGdl;
+import static org.neo4j.gds.utils.ExceptionUtil.rootCause;
+import static org.neo4j.gds.utils.StringFormatting.formatWithLocale;
 
 class ToUndirectedProcTest extends BaseProcTest {
 
@@ -62,7 +67,7 @@ void setup() throws Exception {
     }
 
     @Test
-    void convertToUndirect() {
+    void convertToUndirected() {
         String query = "CALL gds.beta.graph.relationships.toUndirected('graph', {relationshipType: 'REL', mutateRelationshipType: 'REL2'})";
 
         assertCypherResult(query, List.of(Map.of("inputRelationships", 3L,
@@ -78,4 +83,28 @@ void convertToUndirect() {
         var graph = gs.graphStore().getGraph(RelationshipType.of("REL2"));
         assertGraphEquals(fromGdl(DB.replace("REL", "REL2"), Orientation.UNDIRECTED), graph);
     }
+
+    @Test
+    void shouldFailIfMutateRelationshipTypeExists() {
+        String query = "CALL gds.beta.graph.relationships.toUndirected('graph', {relationshipType: 'REL', mutateRelationshipType: 'REL'})";
+
+        Throwable throwable = rootCause(assertThrows(QueryExecutionException.class, () -> runQuery(query)));
+        assertEquals(IllegalArgumentException.class, throwable.getClass());
+        String expectedMessage = formatWithLocale(
+            "Relationship type `REL` already exists in the in-memory graph."
+        );
+        assertEquals(expectedMessage, throwable.getMessage());
+    }
+
+    @Test
+    void shouldFailIfRelationshipTypeDoesNotExists() {
+        String query = "CALL gds.beta.graph.relationships.toUndirected('graph', {relationshipType: 'REL2', mutateRelationshipType: 'REL2'})";
+
+        Throwable throwable = rootCause(assertThrows(QueryExecutionException.class, () -> runQuery(query)));
+        assertEquals(IllegalArgumentException.class, throwable.getClass());
+        String expectedMessage = formatWithLocale(
+            "Could not find the specified `relationshipType` of ['REL2']. Available relationship types are ['REL']."
+        );
+        assertEquals(expectedMessage, throwable.getMessage());
+    }
 }