Demolish stats inheritence everywhere; probablly destroy everything else

Author: IoannisPanagiotas

proc/pregel/src/main/java/org/neo4j/gds/pregel/proc/PregelStatsResult.java

@@ -19,15 +19,17 @@
  */
 package org.neo4j.gds.pregel.proc;
 
-import org.neo4j.gds.procedures.algorithms.results.StandardStatsResult;
-
 import java.util.Map;
 
 @SuppressWarnings("unused")
-public final class PregelStatsResult extends StandardStatsResult {
+public final class PregelStatsResult  {
 
+    public final long preProcessingMillis;
+    public final long computeMillis;
+    public final Map<String, Object> configuration;
     public final long ranIterations;
     public final boolean didConverge;
+    public final long postProcessingMillis;
 
     private PregelStatsResult(
         long preProcessingMillis,
@@ -36,16 +38,25 @@ private PregelStatsResult(
         boolean didConverge,
         Map<String, Object> configuration
     ) {
-        super(preProcessingMillis, computeMillis, 0L, configuration);
         this.ranIterations = ranIterations;
         this.didConverge = didConverge;
+        this.preProcessingMillis = preProcessingMillis;
+        this.postProcessingMillis = 0;
+        this.computeMillis = computeMillis;
+        this.configuration = configuration;
     }
 
     public static class Builder extends AbstractPregelResultBuilder<PregelStatsResult> {
 
         @Override
         public PregelStatsResult build() {
-            return new PregelStatsResult(preProcessingMillis, computeMillis, ranIterations, didConverge, config.toMap());
+            return new PregelStatsResult(
+                preProcessingMillis,
+                computeMillis,
+                ranIterations,
+                didConverge,
+                config.toMap()
+            );
         }
     }
 }

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/centrality/BetaClosenessCentralityResultBuilderForWriteMode.java

@@ -57,14 +57,14 @@ public Stream<BetaClosenessCentralityWriteResult> build(
 
         return Stream.of(
             new BetaClosenessCentralityWriteResult(
-                writeResult.nodePropertiesWritten,
-                writeResult.preProcessingMillis,
-                writeResult.computeMillis,
-                writeResult.postProcessingMillis,
-                writeResult.writeMillis,
+                writeResult.nodePropertiesWritten(),
+                writeResult.preProcessingMillis(),
+                writeResult.computeMillis(),
+                writeResult.postProcessingMillis(),
+                writeResult.writeMillis(),
                 configuration.writeProperty(),
-                writeResult.centralityDistribution,
-                writeResult.configuration
+                writeResult.centralityDistribution(),
+                writeResult.configuration()
             )
         );
     }

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/centrality/GenericCentralityResultBuilderForStatsMode.java

@@ -39,7 +39,7 @@ public <CONFIGURATION extends ConcurrencyConfig & ToMapConvertible> CentralitySt
     ) {
         var configurationMap = configuration.toMap();
 
-        if (result.isEmpty()) return CentralityMutateResult.emptyFrom(timings, configurationMap);
+        if (result.isEmpty()) return CentralityStatsResult.emptyFrom(timings, configurationMap);
 
         var centralityAlgorithmResult = result.get();
 

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/centrality/stubs/BetaClosenessCentralityResultBuilderForMutateMode.java

@@ -56,14 +56,14 @@ public BetaClosenessCentralityMutateResult build(
         );
 
         return new BetaClosenessCentralityMutateResult(
-            centralityMutateResult.nodePropertiesWritten,
-            centralityMutateResult.preProcessingMillis,
-            centralityMutateResult.computeMillis,
-            centralityMutateResult.postProcessingMillis,
-            centralityMutateResult.mutateMillis,
+            centralityMutateResult.nodePropertiesWritten(),
+            centralityMutateResult.preProcessingMillis(),
+            centralityMutateResult.computeMillis(),
+            centralityMutateResult.postProcessingMillis(),
+            centralityMutateResult.mutateMillis(),
             configuration.mutateProperty(),
-            centralityMutateResult.centralityDistribution,
-            centralityMutateResult.configuration
+            centralityMutateResult.centralityDistribution(),
+            centralityMutateResult.configuration()
         );
     }
 }

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/miscellaneous/ScalePropertiesResultBuilderForStatsMode.java

@@ -50,10 +50,9 @@ public Stream<ScalePropertiesStatsResult> build(
 
         var scalePropertiesResult = result.get();
 
-        var scalePropertiesStatsResult = new ScalePropertiesStatsResult(
+        var scalePropertiesStatsResult =  ScalePropertiesStatsResult.create(
             shouldDisplayScalerStatistics ? scalePropertiesResult.scalerStatistics() : null,
-            timings.preProcessingMillis,
-            timings.computeMillis,
+            timings,
             configuration.toMap()
         );
 

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/results/StandardModeResult.java

@@ -21,8 +21,12 @@
 
 import java.util.Map;
 
-public class StandardMutateResult extends StandardStatsResult {
+public class StandardMutateResult {
     public final long mutateMillis;
+    public final long preProcessingMillis;
+    public final long computeMillis;
+    public final long postProcessingMillis;
+    public final Map<String, Object> configuration;
 
     public StandardMutateResult(
         long preProcessingMillis,
@@ -31,7 +35,10 @@ public StandardMutateResult(
         long mutateMillis,
         Map<String, Object> configuration
     ) {
-        super(preProcessingMillis, computeMillis, postProcessingMillis, configuration);
         this.mutateMillis = mutateMillis;
+        this.postProcessingMillis = postProcessingMillis;
+        this.preProcessingMillis = preProcessingMillis;
+        this.configuration = configuration;
+        this.computeMillis = computeMillis;
     }
 }