Skip to content

Commit d197286

Browse files
Remote Scale properties stats
1 parent 4d0b07a commit d197286

File tree

4 files changed

+15
-80
lines changed

4 files changed

+15
-80
lines changed

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/miscellaneous/ScalePropertiesResultBuilderForWriteMode.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public Stream<ScalePropertiesWriteResult> build(
5353
timings.preProcessingMillis,
5454
timings.computeMillis,
5555
timings.sideEffectMillis,
56+
0,
5657
metadata.orElseThrow().value(),
5758
configuration.toMap()
5859
);

procedures/algorithms-facade/src/main/java/org/neo4j/gds/procedures/algorithms/miscellaneous/stubs/ScalePropertiesResultBuilderForMutateMode.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public ScalePropertiesMutateResult build(
5353
timings.preProcessingMillis,
5454
timings.computeMillis,
5555
timings.sideEffectMillis,
56+
0,
5657
metadata.orElseThrow().value(),
5758
configuration.toMap()
5859
);

procedures/facade-api/miscellaneous-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/miscellaneous/ScalePropertiesMutateResult.java

Lines changed: 3 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -20,35 +20,20 @@
2020
package org.neo4j.gds.procedures.algorithms.miscellaneous;
2121

2222
import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
23-
import org.neo4j.gds.procedures.algorithms.results.StandardMutateResult;
24-
import org.neo4j.gds.result.AbstractResultBuilder;
2523

2624
import java.util.Collections;
2725
import java.util.List;
2826
import java.util.Map;
2927

30-
public final class ScalePropertiesMutateResult extends StandardMutateResult {
31-
public final Map<String, Map<String, List<Double>>> scalerStatistics;
32-
public final long nodePropertiesWritten;
33-
34-
public ScalePropertiesMutateResult(
28+
public record ScalePropertiesMutateResult(
3529
Map<String, Map<String, List<Double>>> scalerStatistics,
3630
long preProcessingMillis,
3731
long computeMillis,
3832
long mutateMillis,
33+
long postProcessingMillis,
3934
long nodePropertiesWritten,
4035
Map<String, Object> configuration
4136
) {
42-
super(
43-
preProcessingMillis,
44-
computeMillis,
45-
0L,
46-
mutateMillis,
47-
configuration
48-
);
49-
this.scalerStatistics = scalerStatistics;
50-
this.nodePropertiesWritten = nodePropertiesWritten;
51-
}
5237

5338
public static ScalePropertiesMutateResult emptyFrom(
5439
AlgorithmProcessingTimings timings,
@@ -60,28 +45,9 @@ public static ScalePropertiesMutateResult emptyFrom(
6045
timings.computeMillis,
6146
timings.sideEffectMillis,
6247
0,
48+
0,
6349
configurationMap
6450
);
6551
}
6652

67-
public static class Builder extends AbstractResultBuilder<ScalePropertiesMutateResult> {
68-
private Map<String, Map<String, List<Double>>> scalerStatistics;
69-
70-
public Builder withScalerStatistics(Map<String, Map<String, List<Double>>> stats) {
71-
this.scalerStatistics = stats;
72-
return this;
73-
}
74-
75-
@Override
76-
public ScalePropertiesMutateResult build() {
77-
return new ScalePropertiesMutateResult(
78-
scalerStatistics,
79-
preProcessingMillis,
80-
computeMillis,
81-
mutateMillis,
82-
nodePropertiesWritten,
83-
config.toMap()
84-
);
85-
}
86-
}
8753
}

procedures/facade-api/miscellaneous-facade-api/src/main/java/org/neo4j/gds/procedures/algorithms/miscellaneous/ScalePropertiesWriteResult.java

Lines changed: 10 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -20,35 +20,20 @@
2020
package org.neo4j.gds.procedures.algorithms.miscellaneous;
2121

2222
import org.neo4j.gds.applications.algorithms.machinery.AlgorithmProcessingTimings;
23-
import org.neo4j.gds.procedures.algorithms.results.StandardWriteResult;
24-
import org.neo4j.gds.result.AbstractResultBuilder;
2523

2624
import java.util.Collections;
2725
import java.util.List;
2826
import java.util.Map;
2927

30-
public final class ScalePropertiesWriteResult extends StandardWriteResult {
31-
public final long nodePropertiesWritten;
32-
public final Map<String, Map<String, List<Double>>> scalerStatistics;
33-
34-
ScalePropertiesWriteResult(
35-
Map<String, Map<String, List<Double>>> scalerStatistics,
36-
long preProcessingMillis,
37-
long computeMillis,
38-
long writeMillis,
39-
long nodePropertiesWritten,
40-
Map<String, Object> configuration
41-
) {
42-
super(
43-
preProcessingMillis,
44-
computeMillis,
45-
0L,
46-
writeMillis,
47-
configuration
48-
);
49-
this.nodePropertiesWritten = nodePropertiesWritten;
50-
this.scalerStatistics = scalerStatistics;
51-
}
28+
public record ScalePropertiesWriteResult(
29+
Map<String, Map<String, List<Double>>> scalerStatistics,
30+
long preProcessingMillis,
31+
long computeMillis,
32+
long writeMillis,
33+
long postProcessingMillis,
34+
long nodePropertiesWritten,
35+
Map<String, Object> configuration
36+
){
5237

5338
static ScalePropertiesWriteResult emptyFrom(
5439
AlgorithmProcessingTimings timings,
@@ -60,28 +45,10 @@ static ScalePropertiesWriteResult emptyFrom(
6045
timings.computeMillis,
6146
timings.sideEffectMillis,
6247
0,
48+
0,
6349
configurationMap
6450
);
6551
}
6652

67-
public static class Builder extends AbstractResultBuilder<ScalePropertiesWriteResult> {
68-
private Map<String, Map<String, List<Double>>> scalerStatistics;
69-
70-
public Builder withScalerStatistics(Map<String, Map<String, List<Double>>> stats) {
71-
this.scalerStatistics = stats;
72-
return this;
73-
}
7453

75-
@Override
76-
public ScalePropertiesWriteResult build() {
77-
return new ScalePropertiesWriteResult(
78-
scalerStatistics,
79-
preProcessingMillis,
80-
computeMillis,
81-
writeMillis,
82-
nodePropertiesWritten,
83-
config.toMap()
84-
);
85-
}
86-
}
8754
}

0 commit comments

Comments
 (0)