Merge pull request #6530 from FlorentinD/skip-preaggregate-single-rel

knutwalker · web-flow · commit d5491f3879eb · 2022-11-22T09:28:28.000+01:00
Avoid pre-aggregation for single relationships
diff --git a/core/src/main/java/org/neo4j/gds/core/loading/AdjacencyBuffer.java b/core/src/main/java/org/neo4j/gds/core/loading/AdjacencyBuffer.java
@@ -212,7 +212,7 @@ void addAll(
                 if (propertyValues == null) {
                     compressedTargets.add(localId, targets, startOffset, endOffset, targetsToImport);
                 } else {
-                    if (aggregations[0] != Aggregation.NONE) {
+                    if (aggregations[0] != Aggregation.NONE && targetsToImport > 1) {
                         targetsToImport = preAggregate(targets, propertyValues, startOffset, endOffset, aggregations);
                     }
                     compressedTargets.add(localId, targets, propertyValues, startOffset, endOffset, targetsToImport);

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ void addAll(`
`212`	`212`	`if (propertyValues == null) {`
`213`	`213`	`compressedTargets.add(localId, targets, startOffset, endOffset, targetsToImport);`
`214`	`214`	`} else {`
`215`		`- if (aggregations[0] != Aggregation.NONE) {`
	`215`	`+ if (aggregations[0] != Aggregation.NONE && targetsToImport > 1) {`
`216`	`216`	`targetsToImport = preAggregate(targets, propertyValues, startOffset, endOffset, aggregations);`
`217`	`217`	`}`
`218`	`218`	`compressedTargets.add(localId, targets, propertyValues, startOffset, endOffset, targetsToImport);`