Skip to content

Commit d59fdac

Browse files
committed
KmeansResult is a record
1 parent 1188567 commit d59fdac

File tree

2 files changed

+10
-19
lines changed

2 files changed

+10
-19
lines changed

algo/src/main/java/org/neo4j/gds/kmeans/Kmeans.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public KmeansResult compute() {
121121
for (int i = 0; i < (int) graph.nodeCount(); ++i) {
122122
bestCentroids[i] = nodePropertyValues.doubleArrayValue(i);
123123
}
124-
return ImmutableKmeansResult.of(bestCommunities, distanceFromCentroid, bestCentroids, 0.0, silhouette, 0.0);
124+
return new KmeansResult(bestCommunities, distanceFromCentroid, bestCentroids, 0.0, silhouette, 0.0);
125125
}
126126
long nodeCount = graph.nodeCount();
127127

@@ -146,7 +146,7 @@ public KmeansResult compute() {
146146
calculateSilhouette();
147147
}
148148
progressTracker.endSubTask(); // KMeans end
149-
return ImmutableKmeansResult.of(
149+
return new KmeansResult(
150150
bestCommunities,
151151
distanceFromCentroid,
152152
bestCentroids,

algo/src/main/java/org/neo4j/gds/kmeans/KmeansResult.java

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,14 @@
2020
package org.neo4j.gds.kmeans;
2121

2222
import org.jetbrains.annotations.Nullable;
23-
import org.neo4j.gds.annotation.ValueClass;
2423
import org.neo4j.gds.collections.ha.HugeDoubleArray;
2524
import org.neo4j.gds.collections.ha.HugeIntArray;
2625

27-
28-
@ValueClass
29-
public interface KmeansResult {
30-
HugeIntArray communities();
31-
32-
HugeDoubleArray distanceFromCenter();
33-
34-
double[][] centers();
35-
36-
double averageDistanceToCentroid();
37-
38-
@Nullable
39-
HugeDoubleArray silhouette();
40-
41-
double averageSilhouette();
42-
}
26+
public record KmeansResult(
27+
HugeIntArray communities,
28+
HugeDoubleArray distanceFromCenter,
29+
double[][] centers,
30+
double averageDistanceToCentroid,
31+
@Nullable HugeDoubleArray silhouette,
32+
double averageSilhouette
33+
) {}

0 commit comments

Comments
 (0)