Skip to content

Commit e704124

Browse files
Mats-SXFlorentinD
andcommitted
Catch more exceptions to clean up task store
The failure conditions investigated in the wild (AuraDS) were very hard to analyse conclusively. This is an attempt at being more comprehensive in our cleaning up of the task store. Co-authored-by: Florentin Dörre <florentin.dorre@neo4j.com>
1 parent 20d2d5f commit e704124

File tree

1 file changed

+7
-7
lines changed
  • legacy-cypher-projection/src/main/java/org/neo4j/gds/legacycypherprojection

1 file changed

+7
-7
lines changed

legacy-cypher-projection/src/main/java/org/neo4j/gds/legacycypherprojection/CypherFactory.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ public GraphDimensions estimationDimensions() {
162162
@Override
163163
public CSRGraphStore build() {
164164
// Temporarily override the security context to enforce read-only access during load
165-
return readOnlyTransaction().apply((tx, ktx) -> {
166-
try {
165+
try {
166+
return readOnlyTransaction().apply((tx, ktx) -> {
167167
progressTracker.beginSubTask("Loading");
168168
BatchLoadResult nodeCount = new CountingCypherRecordLoader(
169169
cypherConfig.nodeQuery(),
@@ -198,11 +198,11 @@ public CSRGraphStore build() {
198198
logLoadingSummary(graphStore);
199199

200200
return graphStore;
201-
} catch (RuntimeException ex) {
202-
progressTracker.endSubTaskWithFailure();
203-
throw ex;
204-
}
205-
});
201+
});
202+
} catch (Throwable ex) {
203+
progressTracker.endSubTaskWithFailure();
204+
throw ex;
205+
}
206206
}
207207

208208
private ProgressTracker initProgressTracker() {

0 commit comments

Comments
 (0)