Align naming for retentionPeriod passed through classes

Author: FlorentinD

core/src/main/java/org/neo4j/gds/core/utils/progress/TaskStoreService.java

@@ -38,7 +38,7 @@ public class TaskStoreService {
     // private final Map<DatabaseId, TaskStore> taskStores = new ConcurrentHashMap();
 
     private final boolean progressTrackingEnabled;
-    private Duration retentionPeriod;
+    private final Duration retentionPeriod;
 
     public TaskStoreService(boolean progressTrackingEnabled, Duration retentionPeriod) {
         this.progressTrackingEnabled = progressTrackingEnabled;

proc/test/src/main/java/org/neo4j/gds/InvocationCountingTaskStore.java

@@ -36,8 +36,8 @@ public class InvocationCountingTaskStore extends PerDatabaseTaskStore {
     public int removeTaskInvocations;
     public Set<JobId> seenJobIds = new HashSet<>();
 
-    public InvocationCountingTaskStore(Duration finishedTaskTTL) {
-        super(finishedTaskTTL);
+    public InvocationCountingTaskStore(Duration retentionPeriod) {
+        super(retentionPeriod);
     }
 
     @Override

progress-tracking/src/main/java/org/neo4j/gds/core/utils/progress/PerDatabaseTaskStore.java

@@ -32,11 +32,11 @@
 public class PerDatabaseTaskStore extends ObservableTaskStore {
     private final Map<String, Map<JobId, UserTask>> registeredTasks;
 
-    public PerDatabaseTaskStore(Duration finishedTaskTTL) {
+    public PerDatabaseTaskStore(Duration retentionPeriod) {
         super(new HashSet<>());
         this.registeredTasks = new ConcurrentHashMap<>();
 
-        this.addListener(new TaskStoreCleaner(this, finishedTaskTTL));
+        this.addListener(new TaskStoreCleaner(this, retentionPeriod));
     }
 
     @Override

progress-tracking/src/main/java/org/neo4j/gds/core/utils/progress/TaskStoreCleaner.java

@@ -25,14 +25,14 @@
 import java.util.concurrent.ScheduledThreadPoolExecutor;
 
 class TaskStoreCleaner implements TaskStoreListener {
-    private final Duration finishedTaskTTL;
+    private final Duration retentionPeriod;
     private final ScheduledThreadPoolExecutor cleanerPool;
     private final TaskStore taskStore;
 
 
-    public TaskStoreCleaner(TaskStore taskStore, Duration finishedTaskTTL) {
+    public TaskStoreCleaner(TaskStore taskStore, Duration retentionPeriod) {
         this.taskStore = taskStore;
-        this.finishedTaskTTL = finishedTaskTTL;
+        this.retentionPeriod = retentionPeriod;
         this.cleanerPool = new ScheduledThreadPoolExecutor(1, ExecutorServiceUtil.DEFAULT_THREAD_FACTORY);
     }
 
@@ -44,13 +44,14 @@ public void onTaskAdded(UserTask userTask) {
     @Override
     public void onTaskCompleted(UserTask userTask) {
         // avoid scheduler if task should be cleaned up immediately
-        if (finishedTaskTTL.toMillis() == 0) {
+        if (retentionPeriod.toMillis() == 0) {
             taskStore.remove(userTask.username(), userTask.jobId());
+            return;
         }
 
         this.cleanerPool.schedule(
             () -> taskStore.remove(userTask.username(), userTask.jobId()),
-            finishedTaskTTL.toMillis(),
+            retentionPeriod.toMillis(),
             java.util.concurrent.TimeUnit.MILLISECONDS
         );
     }

progress-tracking/src/main/java/org/neo4j/gds/core/utils/progress/TaskStoreHolder.java

@@ -61,10 +61,10 @@ private TaskStoreHolder() {}
      * Not using DatabaseId directly, because that would mead to some awful dependencies.
      * And we will eliminate this in due course.
      */
-    public static TaskStore getTaskStore(String databaseName, Duration finishedTaskTTL) {
+    public static TaskStore getTaskStore(String databaseName, Duration retentionPeriod) {
         String normalizedDatabaseName = StringFormatting.toLowerCaseWithLocale(databaseName);
 
-        return TASK_STORES.computeIfAbsent(normalizedDatabaseName, __ -> new PerDatabaseTaskStore(finishedTaskTTL));
+        return TASK_STORES.computeIfAbsent(normalizedDatabaseName, __ -> new PerDatabaseTaskStore(retentionPeriod));
     }
 
     public static void purge(String databaseName) {