Verify that UNKNOWN_MAX_ID is handled correctly

Co-Authored-By: Sören Reichardt <soren.reichardt@neotechnology.com>

Author: s1ck

core/src/main/java/org/neo4j/gds/core/loading/ArrayIdMap.java

@@ -61,8 +61,8 @@ public class ArrayIdMap extends LabeledIdMap {
 
     private final long highestNeoId;
 
-    private final HugeLongArray graphIds;
-    private final HugeSparseLongArray nodeToGraphIds;
+    private final HugeLongArray internalToOriginalIds;
+    private final HugeSparseLongArray originalToInternalIds;
 
     public static MemoryEstimation memoryEstimation() {
         return ESTIMATION;
@@ -72,26 +72,26 @@ public static MemoryEstimation memoryEstimation() {
      * initialize the map with pre-built sub arrays
      */
     public ArrayIdMap(
-        HugeLongArray graphIds,
-        HugeSparseLongArray nodeToGraphIds,
+        HugeLongArray internalToOriginalIds,
+        HugeSparseLongArray originalToInternalIds,
         LabelInformation labelInformation,
         long nodeCount,
         long highestNeoId
     ) {
         super(labelInformation, nodeCount);
-        this.graphIds = graphIds;
-        this.nodeToGraphIds = nodeToGraphIds;
+        this.internalToOriginalIds = internalToOriginalIds;
+        this.originalToInternalIds = originalToInternalIds;
         this.highestNeoId = highestNeoId;
     }
 
     @Override
     public long toMappedNodeId(long originalNodeId) {
-        return nodeToGraphIds.get(originalNodeId);
+        return originalToInternalIds.get(originalNodeId);
     }
 
     @Override
     public long toOriginalNodeId(long mappedNodeId) {
-        return graphIds.get(mappedNodeId);
+        return internalToOriginalIds.get(mappedNodeId);
     }
 
     @Override
@@ -106,7 +106,7 @@ public IdMap rootIdMap() {
 
     @Override
     public boolean contains(final long originalNodeId) {
-        return nodeToGraphIds.contains(originalNodeId);
+        return originalToInternalIds.contains(originalNodeId);
     }
 
     @Override
@@ -141,7 +141,7 @@ public Optional<FilteredIdMap> withFilteredLabels(Collection<NodeLabel> nodeLabe
 
         HugeSparseLongArray newNodeToGraphIds = ArrayIdMapBuilderOps.buildSparseIdMap(
             newNodeCount,
-            nodeToGraphIds.capacity(),
+            originalToInternalIds.capacity(),
             concurrency,
             newGraphIds
         );

core/src/main/java/org/neo4j/gds/core/loading/ArrayIdMapBuilder.java

@@ -69,8 +69,8 @@ public IdMap build(
     ) {
         adders.close();
         long nodeCount = this.size();
-        var graphIds = this.array();
-        return ArrayIdMapBuilderOps.build(graphIds, nodeCount, labelInformationBuilder, highestNodeId, concurrency);
+        HugeLongArray internalToOriginalIds = this.array();
+        return ArrayIdMapBuilderOps.build(internalToOriginalIds, nodeCount, labelInformationBuilder, highestNodeId, concurrency);
     }
 
     public HugeLongArray array() {

core/src/main/java/org/neo4j/gds/core/loading/ArrayIdMapBuilderOps.java

@@ -31,28 +31,28 @@
 public final class ArrayIdMapBuilderOps {
 
     static ArrayIdMap build(
-        HugeLongArray graphIds,
+        HugeLongArray internalToOriginalIds,
         long nodeCount,
         LabelInformation.Builder labelInformationBuilder,
         long highestNodeId,
         int concurrency
     ) {
         if (highestNodeId == NodesBuilder.UNKNOWN_MAX_ID) {
-            highestNodeId = graphIds.asNodeProperties().getMaxLongPropertyValue().orElse(NodesBuilder.UNKNOWN_MAX_ID);
+            highestNodeId = internalToOriginalIds.asNodeProperties().getMaxLongPropertyValue().orElse(NodesBuilder.UNKNOWN_MAX_ID);
         }
 
-        HugeSparseLongArray nodeToGraphIds = buildSparseIdMap(
+        HugeSparseLongArray originalToInternalIds = buildSparseIdMap(
             nodeCount,
             highestNodeId,
             concurrency,
-            graphIds
+            internalToOriginalIds
         );
 
-        var labelInformation = labelInformationBuilder.build(nodeCount, nodeToGraphIds::get);
+        var labelInformation = labelInformationBuilder.build(nodeCount, originalToInternalIds::get);
 
         return new ArrayIdMap(
-            graphIds,
-            nodeToGraphIds,
+            internalToOriginalIds,
+            originalToInternalIds,
             labelInformation,
             nodeCount,
             highestNodeId