fix: don't use reserved names

Author: erezrokah

README.md

@@ -7,7 +7,8 @@ Inject secrets from AWS Secrets Manager into the Netlify build process.
 
 ## Prerequisites
 
-- `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` set as build environment variables with proper permissions, e.g.
+- `NETLIFY_AWS_ACCESS_KEY_ID` and `NETLIFY_AWS_SECRET_ACCESS_KEY` set as build environment variables with proper
+  permissions, e.g.
 
 ```json
 {
@@ -55,10 +56,10 @@ package = "@netlify/plugin-secrets-manager"
 
 ## Additional configuration
 
-- By default the plugin injects the secrets with a `AWS_SECRET_` prefix. You can override the default prefix using the
-  `AWS_SECRET_PREFIX` environment variable.
-- The plugin defaults to the `us-east-1` region. You can override the default region using the `AWS_DEFAULT_REGION`
-  environment variable.
+- By default the plugin injects the secrets with a `NETLIFY_AWS_SECRET_` prefix. You can override the default prefix
+  using the `NETLIFY_AWS_SECRET_PREFIX` environment variable.
+- The plugin defaults to the `us-east-1` region. You can override the default region using the
+  `NETLIFY_AWS_DEFAULT_REGION` environment variable.
 
 ## Contributors
 

netlify.toml

@@ -1,5 +1,5 @@
 [build]
-command = "echo $AWS_SECRET_SECRET_NAME"
+command = "echo $NETLIFY_AWS_SECRET_SECRET_NAME"
 publish = "public"
 [[plugins]]
 package = "."

src/main.js

@@ -33,23 +33,23 @@ const normalizeSecrets = async ({ client, secrets }) => {
   return Object.assign({}, ...values)
 }
 
-const SECRET_PREFIX = process.env.AWS_SECRET_PREFIX || 'AWS_SECRET_'
+const SECRET_PREFIX = process.env.NETLIFY_AWS_SECRET_PREFIX || 'NETLIFY_AWS_SECRET_'
 
 const getPrefixedKey = (key) => `${SECRET_PREFIX}${key}`
 
 module.exports = {
   async onPreBuild({ utils }) {
     const {
-      AWS_ACCESS_KEY_ID: accessKeyId,
-      AWS_SECRET_ACCESS_KEY: secretAccessKey,
-      AWS_DEFAULT_REGION: region = 'us-east-1',
+      NETLIFY_AWS_ACCESS_KEY_ID: accessKeyId,
+      NETLIFY_AWS_SECRET_ACCESS_KEY: secretAccessKey,
+      NETLIFY_AWS_DEFAULT_REGION: region = 'us-east-1',
     } = process.env
     if (!accessKeyId) {
-      return utils.build.failBuild(`Missing environment variable AWS_ACCESS_KEY_ID`)
+      return utils.build.failBuild(`Missing environment variable NETLIFY_AWS_ACCESS_KEY_ID`)
     }
 
     if (!secretAccessKey) {
-      return utils.build.failBuild(`Missing environment variable AWS_SECRET_ACCESS_KEY`)
+      return utils.build.failBuild(`Missing environment variable NETLIFY_AWS_SECRET_ACCESS_KEY`)
     }
 
     const client = new SecretsManagerClient({

test/main.js

@@ -3,7 +3,7 @@ const test = require('ava')
 
 const NETLIFY_CONFIG = `${__dirname}/../netlify.toml`
 
-test('Netlify Build fails when missing AWS_ACCESS_KEY_ID env variable', async (t) => {
+test('Netlify Build fails when missing NETLIFY_AWS_ACCESS_KEY_ID env variable', async (t) => {
   const { success, logs } = await netlifyBuild({
     env: {},
     config: NETLIFY_CONFIG,
@@ -13,25 +13,25 @@ test('Netlify Build fails when missing AWS_ACCESS_KEY_ID env variable', async (t
   t.is(success, false)
 
   const output = logs.stdout.join('')
-  t.true(output.includes('Missing environment variable AWS_ACCESS_KEY_ID'))
+  t.true(output.includes('Missing environment variable NETLIFY_AWS_ACCESS_KEY_ID'))
 })
 
-test('Netlify Build fails when missing AWS_SECRET_ACCESS_KEY env variable', async (t) => {
+test('Netlify Build fails when missing NETLIFY_AWS_SECRET_ACCESS_KEY env variable', async (t) => {
   const { success, logs } = await netlifyBuild({
-    env: { AWS_ACCESS_KEY_ID: 'test' },
+    env: { NETLIFY_AWS_ACCESS_KEY_ID: 'test' },
     config: NETLIFY_CONFIG,
     buffer: true,
   })
 
   t.is(success, false)
 
   const output = logs.stdout.join('')
-  t.true(output.includes('Missing environment variable AWS_SECRET_ACCESS_KEY'))
+  t.true(output.includes('Missing environment variable NETLIFY_AWS_SECRET_ACCESS_KEY'))
 })
 
-test('Netlify Build fails when AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are invalid', async (t) => {
+test('Netlify Build fails when NETLIFY_AWS_ACCESS_KEY_ID and NETLIFY_AWS_SECRET_ACCESS_KEY are invalid', async (t) => {
   const { success, logs } = await netlifyBuild({
-    env: { AWS_ACCESS_KEY_ID: 'test', AWS_SECRET_ACCESS_KEY: 'test' },
+    env: { NETLIFY_AWS_ACCESS_KEY_ID: 'test', NETLIFY_AWS_SECRET_ACCESS_KEY: 'test' },
     config: NETLIFY_CONFIG,
     buffer: true,
   })