Add ordering to inferenceMaps

Author: bjee19

internal/controller/nginx/config/maps.go

@@ -2,6 +2,7 @@ package config
 
 import (
 	"fmt"
+	"sort"
 	"strings"
 	gotemplate "text/template"
 
@@ -245,9 +246,17 @@ func buildInferenceMaps(groups []dataplane.BackendGroup) []shared.Map {
 		}
 	}
 
+	// Sort the map keys to ensure deterministic ordering
+	mapKeys := make([]string, 0, len(uniqueMaps))
+	for key := range uniqueMaps {
+		mapKeys = append(mapKeys, key)
+	}
+	sort.Strings(mapKeys)
+
+	// Build the result slice in sorted order
 	inferenceMaps := make([]shared.Map, 0, len(uniqueMaps))
-	for _, inferenceMap := range uniqueMaps {
-		inferenceMaps = append(inferenceMaps, inferenceMap)
+	for _, key := range mapKeys {
+		inferenceMaps = append(inferenceMaps, uniqueMaps[key])
 	}
 
 	return inferenceMaps

internal/controller/nginx/config/maps_test.go

@@ -408,25 +408,25 @@ func TestBuildInferenceMaps(t *testing.T) {
 		expectedMaps  int
 	}{
 		{
-			name: "unique backends with different failure modes",
+			name: "unique backends with different failure modes, result is ordered by upstream name",
 			backendGroups: []dataplane.BackendGroup{
 				{
 					Backends: []dataplane.Backend{
 						{
-							UpstreamName: "upstream1",
+							UpstreamName: "upstream2",
 							EndpointPickerConfig: &dataplane.EndpointPickerConfig{
 								NsName: "default",
 								EndpointPickerRef: &inference.EndpointPickerRef{
-									FailureMode: inference.EndpointPickerFailClose,
+									FailureMode: inference.EndpointPickerFailOpen,
 								},
 							},
 						},
 						{
-							UpstreamName: "upstream2",
+							UpstreamName: "upstream1",
 							EndpointPickerConfig: &dataplane.EndpointPickerConfig{
 								NsName: "default",
 								EndpointPickerRef: &inference.EndpointPickerRef{
-									FailureMode: inference.EndpointPickerFailOpen,
+									FailureMode: inference.EndpointPickerFailClose,
 								},
 							},
 						},